mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Timo Joannin <timo.joannin@gmail.com>
Cc: Orgad Shaneh <orgads@gmail.com>,
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mips: cavium-octeon: fix missing prototypes
Date: Tue, 17 Nov 2026 17:14:50 +0100	[thread overview]
Message-ID: <avx9enOXbOGmpirP@alpha.franken.de> (raw)
In-Reply-To: <20261108143140.157628-1-timo.joannin@gmail.com>

On Sun, Nov 08, 2026 at 03:31:40PM +0100, Timo Joannin wrote:
> The compiler throws -Wmissing-prototypes warnings for
> several functions in the cavium octeon architecture code.
> 
> It occurs due to a mix of hardcoded prototypes scattered
> across C files, a block-scoped extern declaration,
> and missing header files.
> 
> Fix the warnings by:
> - Moving the prototype for octeon_fill_mac_addresses() from
> setup.c to <asm/octeon/octeon.h>
> - Removing the block-scoped extern declaration for
> octeon_send_ipi_single() in mm/c-octeon.c and exposing via
> <asm/octeon/octeon.h>
> - Moving the prototype __cvmx_interrupt_gmxx_rxx_int_en_enable()
> from cvmx-interrupt-rsl.c to the cvmx-gmxx-defs shared header.
> - Adding the missing #include <asm/octeon/cvmx-helper-errata.h> to
> cvmx-helper-errata.c.
> 
> These changes pass the compiler's -Wmissing-prototypes safety
> checks without changing any runtime logic.
> 
> Signed-off-by: Timo Joannin <timo.joannin@gmail.com>
> ---
>  arch/mips/cavium-octeon/executive/cvmx-helper-errata.c | 1 +
>  arch/mips/cavium-octeon/executive/cvmx-interrupt-rsl.c | 2 --
>  arch/mips/cavium-octeon/setup.c                        | 2 --
>  arch/mips/include/asm/octeon/cvmx-gmxx-defs.h          | 2 ++
>  arch/mips/include/asm/octeon/octeon.h                  | 2 ++
>  arch/mips/mm/c-octeon.c                                | 1 -
>  6 files changed, 5 insertions(+), 5 deletions(-)

I've applied https://lore.kernel.org/all/20261101234657.1820661-1-rdunlap@infradead.org,
which also cleans up cavium octeon code. So your patch doesn't apply any
longer. Can you check, if all your warning fixes are applied, and if not
send an updates patch ?

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

  reply	other threads:[~2026-11-17 16:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-08 14:31 Timo Joannin
2026-11-17 16:14 ` Thomas Bogendoerfer [this message]
2026-11-17 17:02   ` Timo Joannin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avx9enOXbOGmpirP@alpha.franken.de \
    --to=tsbogend@alpha.franken.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=orgads@gmail.com \
    --cc=timo.joannin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®