From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Leonard Lausen <leonard@lausen.nl>
Cc: netdev@vger.kernel.org, David Ahern <dsahern@kernel.org>,
Ido Schimmel <idosch@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, Florian Westphal <fw@strlen.de>,
Phil Sutter <phil@nwl.cc>, Shuah Khan <shuah@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v4 0/2] ipv6: Honor suppress_prefixlength in fib6_lookup()
Date: Tue, 17 Nov 2026 13:56:53 +0100 [thread overview]
Message-ID: <avxPFYfEirXzTup8@chamomile> (raw)
In-Reply-To: <20261117110813.9894-2-leonard@lausen.nl>
On Tue, Nov 17, 2026 at 11:08:10AM +0000, Leonard Lausen wrote:
> This revision removes the cached-exception patch and its PMTU test, as
> requested. The series fixes the nftables regression introduced by
> 1c32b24c234b and leaves dst-based prefix suppression unchanged.
Is this a LLM finding? Or a real issue in production?
> The cached-exception work is deferred to net-next after the
> fib6_lookup() fix is present there. Interface-group suppression also
> remains deferred.
>
> Patch 1 makes fib6_lookup() honor suppress_prefixlength while preserving
> terminal reject results, including blackhole nexthop objects. Patch 2
> adds six checks to nft_fib.sh using its existing fixture.
>
> Changes since v3:
> - Drop the cached-exception fix and its PMTU regression case.
> - Remove the PMTU-only gateway and peer setup from the test fixture.
> - Renumber the remaining fix and test patches as a two-patch series.
>
> V3 review:
> https://lore.kernel.org/netdev/20261117091340.GA581197@shredder/T/#t
>
> The rebuilt v7.4-rc2-based laptop kernel now contains the v4 series,
> without the deferred cached-exception fix. All six added selftest checks
> pass in normal and eight-second-delayed runs; both full runs exit 0.
> Twelve separate reject-route controls also pass. The changed source
> compiles without warnings and passes 17 focused ASan/UBSan callback
> checks. Automated kernel-log checks were unavailable. Target-net runtime
> and full W=1 config builds remain unchecked.
>
> OpenAI Codex assisted with investigation, reproduction, implementation,
> tests and descriptions. Prompts asked it to investigate VPN failures,
> simplify the series and address review feedback.
>
> Leonard Lausen (2):
> ipv6: Honor suppress_prefixlength in fib6_lookup()
> selftests: netfilter: cover IPv6 FIB prefix suppression
>
> net/ipv6/fib6_rules.c | 6 ++
> .../selftests/net/netfilter/nft_fib.sh | 90 +++++++++++++++++++
> 2 files changed, 96 insertions(+)
>
>
> base-commit: 7475ea8b58616b33c04afb976cf0fbaad9dd63fb
> --
> 2.55.0
>
next prev parent reply other threads:[~2026-11-17 12:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 11:08 Leonard Lausen
2026-11-17 11:08 ` [PATCH net v4 1/2] " Leonard Lausen
2026-11-17 16:12 ` Ido Schimmel
2026-11-17 11:08 ` [PATCH net v4 2/2] selftests: netfilter: cover IPv6 FIB prefix suppression Leonard Lausen
2026-11-17 12:56 ` Pablo Neira Ayuso [this message]
2026-11-17 13:01 ` [PATCH net v4 0/2] ipv6: Honor suppress_prefixlength in fib6_lookup() Leonard Lausen
2026-11-17 13:07 ` Pablo Neira Ayuso
2026-11-17 15:24 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avxPFYfEirXzTup8@chamomile \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@kernel.org \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=leonard@lausen.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=phil@nwl.cc \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®