From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Badhri Jagan Sridharan <badhri@google.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH 7/8] usb: typec: fusb302: rework gpio_int_n_irq handling
Date: Tue, 17 Nov 2026 14:35:03 +0100 [thread overview]
Message-ID: <avxYB5S9_V2wy5Wh@black.igk.intel.com> (raw)
In-Reply-To: <20261113-fusb302-probe-cleanup-v1-7-e5c65a8c58c8@collabora.com>
On Fri, Nov 13, 2026 at 05:42:43PM +0100, Sebastian Reichel wrote:
> Improve the code readability, so that one does not need to jump
> into fusb302_init_irq() to understand that chip->gpio_int_n_irq
> is guranteed to be initialized.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
> drivers/usb/typec/tcpm/fusb302.c | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> index 76851e2b9ce5..6105f09f96aa 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c
> @@ -1656,8 +1656,7 @@ static int fusb302_init_irq(struct fusb302_chip *chip)
> if (ret < 0)
> return dev_err_probe(dev, ret, "cannot request IRQ for GPIO\n");
>
> - chip->gpio_int_n_irq = ret;
> - return 0;
> + return ret;
> }
>
> #define PDO_FIXED_FLAGS \
> @@ -1752,13 +1751,13 @@ static int fusb302_probe(struct i2c_client *client)
> if (ret < 0)
> return ret;
>
> - if (client->irq) {
> + if (client->irq)
> chip->gpio_int_n_irq = client->irq;
> - } else {
> - ret = fusb302_init_irq(chip);
> - if (ret < 0)
> - return ret;
> - }
> + else
> + chip->gpio_int_n_irq = fusb302_init_irq(chip);
> +
> + if (chip->gpio_int_n_irq < 0)
> + return chip->gpio_int_n_irq;
>
> chip->tcpc_dev.fwnode = fusb302_fwnode_get(dev);
> if (IS_ERR(chip->tcpc_dev.fwnode)) {
I think this is okay, but I now think that gpio_int_n_irq should be
renamed. It's a bit confusing. The irq is not always gpio.
And that said, I'm now wondering if fusb302_init_irq should be
something else after all. Maybe fusb302_init_gpio_irq, or something
like that?
Thanks,
--
heikki
next prev parent reply other threads:[~2026-11-17 13:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 16:42 [PATCH 0/8] usb: typec: fusb302: cleanup device driver probe Sebastian Reichel
2026-11-13 16:42 ` [PATCH 1/8] usb: typec: tcpm: allocate pd_list entries non device managed Sebastian Reichel
2026-11-13 16:42 ` [PATCH 2/8] usb: typec: tcpm: add device managed port registration Sebastian Reichel
2026-11-13 16:42 ` [PATCH 3/8] usb: typec: fusb302: Switch to device managed resources Sebastian Reichel
2026-11-13 16:42 ` [PATCH 4/8] usb: typec: fusb302: switch to devm_pm_set_wake_irq Sebastian Reichel
2026-11-17 13:20 ` Heikki Krogerus
2026-11-13 16:42 ` [PATCH 5/8] usb: typec: fusb302: rename init_gpio into fusb302_init_irq Sebastian Reichel
2026-11-17 13:23 ` Heikki Krogerus
2026-11-13 16:42 ` [PATCH 6/8] usb: typec: fusb302: move gpio_int_n into function local scope Sebastian Reichel
2026-11-17 13:24 ` Heikki Krogerus
2026-11-17 13:37 ` Heikki Krogerus
2026-11-13 16:42 ` [PATCH 7/8] usb: typec: fusb302: rework gpio_int_n_irq handling Sebastian Reichel
2026-11-17 13:35 ` Heikki Krogerus [this message]
2026-11-13 16:42 ` [PATCH 8/8] usb: typec: fusb302: drop custom gpio interrupt logic Sebastian Reichel
2026-11-16 8:32 ` [PATCH 0/8] usb: typec: fusb302: cleanup device driver probe Chaoyi Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avxYB5S9_V2wy5Wh@black.igk.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=badhri@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®