mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: CL Wang <cl634@andestech.com>
Cc: Linus Walleij <linusw@kernel.org>,
	 Bartosz Golaszewski <brgl@kernel.org>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-gpio@vger.kernel.org,  devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, tim609@andestech.com
Subject: Re: [PATCH 2/3] gpio: atcgpio100: Add ATCGPIO100 GPIO driver
Date: Tue, 17 Nov 2026 15:10:50 +0100	[thread overview]
Message-ID: <avxgGQL91z0ezLFH@monoceros> (raw)
In-Reply-To: <20261116040914.368298-3-cl634@andestech.com>

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

On Mon, Nov 16, 2026 at 12:09:13PM +0800, CL Wang wrote:
> +#include <linux/mod_devicetable.h>
> [...]
> +#include <linux/platform_device.h>

<linux/platform_device.h> already provides of_device_id and
<linux/mod_devicetable.h> adds a lot of unneeded build dependencies. So
please drop <linux/mod_devicetable.h>.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  parent reply	other threads:[~2026-11-17 14:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  4:09 [PATCH 0/3] gpio: Add support for Andes ATCGPIO100 GPIO controller CL Wang
2026-11-16  4:09 ` [PATCH 1/3] dt-bindings: gpio: Add support for " CL Wang
2026-11-16  4:09 ` [PATCH 2/3] gpio: atcgpio100: Add ATCGPIO100 GPIO driver CL Wang
2026-11-17 13:54   ` Bartosz Golaszewski
2026-11-17 14:10   ` Uwe Kleine-König [this message]
2026-11-16  4:09 ` [PATCH 3/3] MAINTAINERS: Add entry for Andes ATCGPIO100 GPIO CL Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avxgGQL91z0ezLFH@monoceros \
    --to=u.kleine-koenig@baylibre.com \
    --cc=brgl@kernel.org \
    --cc=cl634@andestech.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=tim609@andestech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®