From: Potnuri Bharat Teja <bharat@chelsio.com>
To: Artemii Mashanov <ralerrdirsardx@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@kernel.org" <edumazet@kernel.org>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] cxgb4: allocate the full ethtool filter location array
Date: Tue, 17 Nov 2026 19:40:17 +0530 [thread overview]
Message-ID: <avxgSZdRIe07WZfT@chelsio.com> (raw)
In-Reply-To: <20261117090608.33178-1-ralerrdirsardx@gmail.com>
On Tuesday, November 11/17/26, 2026 at 14:36:08 +0530, Artemii Mashanov wrote:
> The ethtool filter location array stores nentries u32 values, but
> cxgb4_init_ethtool_filters() passes nentries to kvzalloc() as a byte
> count. The insertion and lookup paths allow indices below nentries,
> which can address memory beyond the requested allocation.
>
> Allocate nentries elements with kvcalloc() and the element size.
> The array remains compatible with the existing kvfree() calls.
>
> The size mismatch was found by reviewing the allocation, the array
> declaration and the indexed accesses in the filter handlers.
>
> Fixes: d915c299f1da ("cxgb4: add skeleton for ethtool n-tuple filters")
> Signed-off-by: Artemii Mashanov <ralerrdirsardx@gmail.com>
> ---
> Compile-tested cxgb4_ethtool.o with GCC 14.2 on x86-64 net/main
> aa40afa831eb using W=1 and KCFLAGS=-Wno-error=format-truncation.
> Both baseline and patched builds reported the same get_drvinfo()
> format-truncation warning. Hardware validation is pending.
>
> drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c
> index 0092bc16f887..c72c0bcd45c8 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c
> @@ -2269,7 +2269,9 @@ int cxgb4_init_ethtool_filters(struct adapter *adap)
> eth_filter->nentries = nentries;
>
> for (i = 0; i < adap->params.nports; i++) {
> - eth_filter->port[i].loc_array = kvzalloc(nentries, GFP_KERNEL);
> + eth_filter->port[i].loc_array =
> + kvcalloc(nentries, sizeof(*eth_filter->port[i].loc_array),
> + GFP_KERNEL);
Thanks, Tested on T6, ethtool -N filters at high locations now insert and delete cleanly with KASAN enabled.
Reviewed-by: Potnuri Bharat Teja <bharat@chelsio.com>
Tested-by: Potnuri Bharat Teja <bharat@chelsio.com>
> if (!eth_filter->port[i].loc_array) {
> ret = -ENOMEM;
> goto free_eth_finfo;
prev parent reply other threads:[~2026-11-17 14:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 9:06 Artemii Mashanov
2026-11-17 14:10 ` Potnuri Bharat Teja [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avxgSZdRIe07WZfT@chelsio.com \
--to=bharat@chelsio.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ralerrdirsardx@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®