From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Volodymyr Chapman <volodymyrchapman@gmail.com>
Cc: Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
Griffin Kroah-Hartman <griffin@kroah.com>,
Hans de Goede <hansg@kernel.org>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: flash: Add driver for the TI LM3554
Date: Tue, 17 Nov 2026 15:14:40 +0100 [thread overview]
Message-ID: <avxg_XjFo88nIzU3@monoceros> (raw)
In-Reply-To: <20261116180809.26946-1-volodymyrchapman@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 489 bytes --]
On Mon, Nov 16, 2026 at 06:08:09PM +0000, Volodymyr Chapman wrote:
> +#include <linux/i2c.h>
> [..]
> +#include <linux/mod_devicetable.h>
Don't include <linux/mod_devicetable.h>. <linux/i2c.h> already provides
acpi_device_id, so you can just drop <linux/mod_devicetable.h>.
> [...]
> +static const struct acpi_device_id lm3554_acpi_match[] = {
> + { "INTCF1C" },
Please make this:
{ .id = "INTCF1C" },
> + { }
> +};
> +MODULE_DEVICE_TABLE(acpi, lm3554_acpi_match);
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2026-11-17 14:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 18:08 Volodymyr Chapman
2026-11-17 14:14 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avxg_XjFo88nIzU3@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=griffin@kroah.com \
--cc=hansg@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=volodymyrchapman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®