mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Volodymyr Chapman <volodymyrchapman@gmail.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
	 Mauro Carvalho Chehab <mchehab@kernel.org>,
	Dan Scally <dan.scally@ideasonboard.com>,
	 Hans de Goede <hansg@kernel.org>,
	Andy Shevchenko <andy@kernel.org>,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] media: i2c: Add Sony IMX175 sensor driver
Date: Tue, 17 Nov 2026 15:13:01 +0100	[thread overview]
Message-ID: <avxghetYnw4cMzDQ@monoceros> (raw)
In-Reply-To: <20261116175151.20150-2-volodymyrchapman@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 462 bytes --]

On Mon, Nov 16, 2026 at 05:51:49PM +0000, Volodymyr Chapman wrote:
> +#include <linux/i2c.h>
> +#include <linux/mod_devicetable.h>

Please don't include <linux/mod_devicetable.h>. <linux/i2c.h> already
provides i2c_device_id, so you can just drop it.

> [...]
> +static const struct acpi_device_id imx175_acpi_ids[] = {
> +	{ "INTCF1A" },

Please make this:

	{ .id = "INTCF1A" },


> +	{ }
> +};
> +MODULE_DEVICE_TABLE(acpi, imx175_acpi_ids);

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  parent reply	other threads:[~2026-11-17 14:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 17:51 [PATCH 0/3] media: Add Sony IMX175 sensor driver (Lenovo ThinkPad 10 rear camera) Volodymyr Chapman
2026-11-16 17:51 ` [PATCH 1/3] media: i2c: Add Sony IMX175 sensor driver Volodymyr Chapman
2026-11-16 19:25   ` Dave Stevenson
2026-11-16 23:09     ` Volodymyr Chapman
2026-11-17 14:13   ` Uwe Kleine-König [this message]
2026-11-16 17:51 ` [PATCH 2/3] media: ipu-bridge: Add Sony IMX175 (INTCF1A) Volodymyr Chapman
2026-11-17  9:57   ` Andy Shevchenko
2026-11-16 17:51 ` [PATCH 3/3] media: atomisp: csi2-bridge: Add IMX175 sensor config Volodymyr Chapman
2026-11-17 10:08 ` [PATCH 0/3] media: Add Sony IMX175 sensor driver (Lenovo ThinkPad 10 rear camera) Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avxghetYnw4cMzDQ@monoceros \
    --to=u.kleine-koenig@baylibre.com \
    --cc=andy@kernel.org \
    --cc=dan.scally@ideasonboard.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hansg@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=volodymyrchapman@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®