mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Arnav Kapoor <kapoorarnav43@gmail.com>,
	Matti Vaittinen <mazziesaccount@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	"Mudit Sharma" <muditsharma.info@gmail.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: light: bh1745: fix 16-bit register accesses
Date: Tue, 17 Nov 2026 16:21:20 +0200	[thread overview]
Message-ID: <avxi4BBJ_Ztg-aN7@ashevche-desk.local> (raw)
In-Reply-To: <20261117110327.198084-1-kapoorarnav43@gmail.com>

+ Cc: Matti (even he is not listed as maintainer) for possible another pair of
eyes and/or having an answer why this was missed at the time of the driver
submission (from my perspective this patch is correct).

On Tue, Nov 17, 2026 at 04:33:25PM +0530, Arnav Kapoor wrote:
> The 16-bit colour data and threshold registers are little-endian
> LSB/MSB pairs, but the driver accesses them through regmap_bulk_read()
> and regmap_bulk_write() with an int or u16 buffer and no byte-order
> conversion:
> 
> - bh1745_read_raw() reads 2 bytes into an uninitialised int, so the
>   upper 16 bits returned to user space are stack contents.
> - bh1745_read_thresh() reads 2 bytes straight into *val, which the IIO
>   core leaves uninitialised, with the same result for the event
>   threshold attributes.
> - bh1745_write_thresh() writes the first 2 bytes of an int, which are
>   the upper (zero) bytes on big-endian.
> - bh1745_trigger_handler() pushes the raw register bytes, which are
>   little-endian, in a u16 to a buffer whose scan type is IIO_CPU, so
>   user space gets the samples byte-swapped on big-endian.
> 
> Use an __le16 buffer for all of them and convert with le16_to_cpu() /
> cpu_to_le16().
> 
> Fixes: eab35358aae7 ("iio: light: ROHM BH1745 colour sensor")
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> Signed-off-by: Arnav Kapoor <kapoorarnav43@gmail.com>
> ---
> Changes in v2:
> - Include asm/byteorder.h for le16_to_cpu() / cpu_to_le16() (Andy)
> - Reword the trigger handler bullet: the samples are byte-swapped on
>   big-endian because the scan type is IIO_CPU (Andy)
> - Add Andy's Reviewed-by
> 
> v1: https://lore.kernel.org/all/20261116194214.45174-1-kapoorarnav43@gmail.com/
> 
> Compile-tested only (W=1, checkpatch --strict clean); I don't have
> BH1745 hardware.
> 
>  drivers/iio/light/bh1745.c | 31 +++++++++++++++++++++----------
>  1 file changed, 21 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/iio/light/bh1745.c b/drivers/iio/light/bh1745.c
> index 2b8ff36071b8..e2c03cd0d1e3 100644
> --- a/drivers/iio/light/bh1745.c
> +++ b/drivers/iio/light/bh1745.c
> @@ -17,6 +17,8 @@
>  #include <linux/bits.h>
>  #include <linux/bitfield.h>
>  
> +#include <asm/byteorder.h>
> +
>  #include <linux/iio/iio.h>
>  #include <linux/iio/sysfs.h>
>  #include <linux/iio/trigger.h>
> @@ -421,19 +423,20 @@ static int bh1745_read_raw(struct iio_dev *indio_dev,
>  			   int *val, int *val2, long mask)
>  {
>  	struct bh1745_data *data = iio_priv(indio_dev);
> +	__le16 value;
>  	int ret;
> -	int value;
>  
>  	switch (mask) {
>  	case IIO_CHAN_INFO_RAW:
>  		if (!iio_device_claim_direct(indio_dev))
>  			return -EBUSY;
>  
> -		ret = regmap_bulk_read(data->regmap, chan->address, &value, 2);
> +		ret = regmap_bulk_read(data->regmap, chan->address, &value,
> +				       sizeof(value));
>  		iio_device_release_direct(indio_dev);
>  		if (ret)
>  			return ret;
> -		*val = value;
> +		*val = le16_to_cpu(value);
>  
>  		return IIO_VAL_INT;
>  
> @@ -503,6 +506,7 @@ static int bh1745_read_thresh(struct iio_dev *indio_dev,
>  			      enum iio_event_info info, int *val, int *val2)
>  {
>  	struct bh1745_data *data = iio_priv(indio_dev);
> +	__le16 value;
>  	int ret;
>  
>  	switch (info) {
> @@ -510,18 +514,22 @@ static int bh1745_read_thresh(struct iio_dev *indio_dev,
>  		switch (dir) {
>  		case IIO_EV_DIR_RISING:
>  			ret = regmap_bulk_read(data->regmap, BH1745_TH_LSB,
> -					       val, 2);
> +					       &value, sizeof(value));
>  			if (ret)
>  				return ret;
>  
> +			*val = le16_to_cpu(value);
> +
>  			return IIO_VAL_INT;
>  
>  		case IIO_EV_DIR_FALLING:
>  			ret = regmap_bulk_read(data->regmap, BH1745_TL_LSB,
> -					       val, 2);
> +					       &value, sizeof(value));
>  			if (ret)
>  				return ret;
>  
> +			*val = le16_to_cpu(value);
> +
>  			return IIO_VAL_INT;
>  
>  		default:
> @@ -547,6 +555,7 @@ static int bh1745_write_thresh(struct iio_dev *indio_dev,
>  			       enum iio_event_info info, int val, int val2)
>  {
>  	struct bh1745_data *data = iio_priv(indio_dev);
> +	__le16 value;
>  	int ret;
>  
>  	switch (info) {
> @@ -554,10 +563,12 @@ static int bh1745_write_thresh(struct iio_dev *indio_dev,
>  		if (val < 0x0 || val > 0xFFFF)
>  			return -EINVAL;
>  
> +		value = cpu_to_le16(val);
> +
>  		switch (dir) {
>  		case IIO_EV_DIR_RISING:
>  			ret = regmap_bulk_write(data->regmap, BH1745_TH_LSB,
> -						&val, 2);
> +						&value, sizeof(value));
>  			if (ret)
>  				return ret;
>  
> @@ -565,7 +576,7 @@ static int bh1745_write_thresh(struct iio_dev *indio_dev,
>  
>  		case IIO_EV_DIR_FALLING:
>  			ret = regmap_bulk_write(data->regmap, BH1745_TL_LSB,
> -						&val, 2);
> +						&value, sizeof(value));
>  			if (ret)
>  				return ret;
>  
> @@ -741,18 +752,18 @@ static irqreturn_t bh1745_trigger_handler(int interrupt, void *p)
>  		u16 chans[4];
>  		aligned_s64 timestamp;
>  	} scan = { };
> -	u16 value;
> +	__le16 value;
>  	int ret;
>  	int i;
>  	int j = 0;
>  
>  	iio_for_each_active_channel(indio_dev, i) {
>  		ret = regmap_bulk_read(data->regmap, BH1745_RED_LSB + 2 * i,
> -				       &value, 2);
> +				       &value, sizeof(value));
>  		if (ret)
>  			goto err;
>  
> -		scan.chans[j++] = value;
> +		scan.chans[j++] = le16_to_cpu(value);
>  	}
>  
>  	iio_push_to_buffers_with_ts(indio_dev, &scan, sizeof(scan),
> 
> base-commit: a6d9114f68c4b5507b2d945bd6d1e37415f913c5

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-11-17 14:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 11:03 Arnav Kapoor
2026-11-17 14:21 ` Andy Shevchenko [this message]
2026-11-17 14:23   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avxi4BBJ_Ztg-aN7@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=kapoorarnav43@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mazziesaccount@gmail.com \
    --cc=muditsharma.info@gmail.com \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®