From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Imre Kaloz <kaloz@kernel.org>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] MIPS: sgi-ip32: Clear latched CRIME errors at boot
Date: Tue, 17 Nov 2026 17:55:56 +0100 [thread overview]
Message-ID: <avyHHHEjSpmUDEa2@alpha.franken.de> (raw)
In-Reply-To: <20261013094554.16804-2-kaloz@kernel.org>
On Tue, Oct 13, 2026 at 11:45:52AM +0200, Imre Kaloz wrote:
> Errors already latched in CRIME when the kernel starts are reported as
> new, as a "CRIME memory error" or a "CRIME CPU error", once the error
> interrupts are enabled. Clear both status registers in crime_init().
>
> Signed-off-by: Imre Kaloz <kaloz@kernel.org>
> ---
> arch/mips/sgi-ip32/crime.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/mips/sgi-ip32/crime.c b/arch/mips/sgi-ip32/crime.c
> index b8a0e4cfa9ce..d9f5fe939bfe 100644
> --- a/arch/mips/sgi-ip32/crime.c
> +++ b/arch/mips/sgi-ip32/crime.c
> @@ -34,6 +34,10 @@ void __init crime_init(void)
> crime = ioremap(CRIME_BASE, sizeof(struct sgi_crime));
> mace = ioremap(MACE_BASE, sizeof(struct sgi_mace));
>
> + /* Errors latched before the kernel starts would be reported as new */
> + crime->mem_error_stat = 0;
> + crime->cpu_error_stat = 0;
> +
> id = crime->id;
> rev = id & CRIME_ID_REV;
> id = (id & CRIME_ID_IDBITS) >> 4;
> --
> 2.47.3
applied to mips-next
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2026-11-17 17:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 9:45 [PATCH 0/3] MIPS: SGI fixes Imre Kaloz
2026-10-13 9:45 ` [PATCH 1/3] MIPS: sgi-ip32: Clear latched CRIME errors at boot Imre Kaloz
2026-11-17 16:55 ` Thomas Bogendoerfer [this message]
2026-10-13 9:45 ` [PATCH 2/3] MIPS: sgi-ip32: Reserve the firmware memory Imre Kaloz
2026-11-17 16:56 ` Thomas Bogendoerfer
2026-10-13 9:45 ` [PATCH 3/3] MIPS: SGI-IP30: fix the defconfig defaults for the Bridge PROM and RTC Imre Kaloz
2026-11-05 15:22 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avyHHHEjSpmUDEa2@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=kaloz@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®