mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@oss.nxp.com>
To: Alex Guo <alexguo1023@gmail.com>
Cc: vkoul@kernel.org, afaerber@suse.de, mani@kernel.org,
	Frank.Li@kernel.org, dmaengine@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: owl: Check IRQ lookup result
Date: Tue, 17 Nov 2026 13:13:07 -0500	[thread overview]
Message-ID: <avyZM-6gM4amnQMT@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <CAAi4Z-d5eV8FM5sYJj1gqudWyioF++fG8P6uGX_LxbiKSXjekw@mail.gmail.com>

On Sun, Nov 15, 2026 at 02:45:05PM +0800, Alex Guo wrote:
> owl_dma_probe() passes the result of platform_get_irq() to
> devm_request_irq() even when the lookup fails. The request can replace
> the original error with -EINVAL.
>
> Return the lookup error before requesting the DMA interrupt, so a
> deferred probe can be retried.
>
> A similar issue was fixed in commit 47c3e06ed95a
> ("spi: tegra210-quad: Fix missing IRQ check in tegra_qspi_probe").
>

Drop this paragraph.

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> Fixes: 47e20577c24d ("dmaengine: Add Actions Semi Owl family S900 DMA driver")
> Signed-off-by: Alex Guo <alexguo1023@gmail.com>
> ---
> Build-tested the affected driver object with Clang 18 for arm64.
> No hardware test was performed.
>
>  drivers/dma/owl-dma.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/dma/owl-dma.c b/drivers/dma/owl-dma.c
> index 31a6c6e01a75..daea82718229 100644
> --- a/drivers/dma/owl-dma.c
> +++ b/drivers/dma/owl-dma.c
> @@ -1156,6 +1156,9 @@ static int owl_dma_probe(struct platform_device *pdev)
>          * simplification.
>          */
>         od->irq = platform_get_irq(pdev, 0);
> +       if (od->irq < 0)
> +               return od->irq;
> +
>         ret = devm_request_irq(&pdev->dev, od->irq, owl_dma_interrupt, 0,
>                                dev_name(&pdev->dev), od);
>         if (ret) {
> --
> 2.43.0

      reply	other threads:[~2026-11-17 18:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15  6:45 Alex Guo
2026-11-17 18:13 ` Frank Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avyZM-6gM4amnQMT@lizhi-Precision-Tower-5810 \
    --to=frank.li@oss.nxp.com \
    --cc=Frank.Li@kernel.org \
    --cc=afaerber@suse.de \
    --cc=alexguo1023@gmail.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-actions@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®