From: Frank Li <Frank.li@oss.nxp.com>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
Vinod Koul <vkoul@kernel.org>, Frank Li <Frank.li@nxp.com>,
Sashiko <sashiko-bot@kernel.org>
Subject: Re: [PATCH v3 4/6] dmaengine: plx_dma: add dma_rmb() after observing write-back status
Date: Tue, 17 Nov 2026 14:25:46 -0500 [thread overview]
Message-ID: <avyqOgwLE2B5rQW5@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20261117165135.746241-5-logang@deltatee.com>
On Tue, Nov 17, 2026 at 10:51:33AM -0600, Logan Gunthorpe wrote:
> Completing a descriptor involves two loads that must be ordered:
>
> 1. Reading desc->hw->flags_and_size and checking that VALID is clear.
> 2. Reading the destination buffer, which may happen in:
> a. dma_unmap_page() via dmaengine_unmap(), when a bounce buffer
> is in use.
> b. The client's callback, or its processing after polling with
> tx_status().
>
> On a weakly ordered CPU like arm64, nothing forces load 2 to happen
> after load 1, even though load 2 is only reached when load 1 says the
> transfer is done. The CPU can predict that the VALID check won't
> break out of the loop and issue load 2 early. If the device hadn't
> finished writing at that moment, load 2 returns stale data, and when
> load 1 then confirms the prediction nothing is redone, so the stale
> data is used. This is the load-load control dependency case described
> in Documentation/memory-barriers.txt.
>
> Add a dma_rmb() after the status check so loads after it can't be
> satisfied before the status read.
>
> Fixes: 4d3df16840a2 ("dmaengine: plx-dma: Implement descriptor submission")
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Link: https://lore.kernel.org/dmaengine/20260717223217.B6FBF1F000E9@smtp.kernel.org
> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> drivers/dma/plx_dma.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/dma/plx_dma.c b/drivers/dma/plx_dma.c
> index d3b814933989..7af29b901bd5 100644
> --- a/drivers/dma/plx_dma.c
> +++ b/drivers/dma/plx_dma.c
> @@ -148,6 +148,13 @@ static void plx_dma_process_desc(struct plx_dma_dev *plxdev)
> if (flags & PLX_DESC_FLAG_VALID)
> break;
>
> + /*
> + * Don't allow any read of the data the device wrote to be
> + * performed before the status read above shows the
> + * descriptor is complete.
> + */
> + dma_rmb();
> +
> res.residue = desc->orig_size - (flags & PLX_DESC_SIZE_MASK);
>
> if (flags & PLX_DESC_WB_SUCCESS)
> --
> 2.47.3
>
next prev parent reply other threads:[~2026-11-17 19:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 16:51 [PATCH v3 0/6] plx_dma fixes Logan Gunthorpe
2026-11-17 16:51 ` [PATCH v3 1/6] dmaengine: plx_dma: don't call pci_irq_vector() under rcu_read_lock() Logan Gunthorpe
2026-11-17 16:51 ` [PATCH v3 2/6] dmaengine: plx_dma: fix descriptor ring leak in alloc_chan_resources() Logan Gunthorpe
2026-11-17 16:51 ` [PATCH v3 3/6] dmaengine: plx_dma: use writel() for the 32-bit PLX_REG_CTRL register Logan Gunthorpe
2026-11-17 16:51 ` [PATCH v3 4/6] dmaengine: plx_dma: add dma_rmb() after observing write-back status Logan Gunthorpe
2026-11-17 19:25 ` Frank Li [this message]
2026-11-17 16:51 ` [PATCH v3 5/6] dmaengine: plx_dma: use spin_lock_bh() in plx_dma_process_desc() Logan Gunthorpe
2026-11-17 16:51 ` [PATCH v3 6/6] dmaengine: plx_dma: don't invoke client callbacks with ring_lock held Logan Gunthorpe
2026-11-17 19:31 ` Frank Li
2026-11-17 22:46 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avyqOgwLE2B5rQW5@lizhi-Precision-Tower-5810 \
--to=frank.li@oss.nxp.com \
--cc=Frank.li@nxp.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=sashiko-bot@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®