From: Frank Li <Frank.li@oss.nxp.com>
To: Lee Jones <lee@kernel.org>
Cc: Vinod Koul <vkoul@kernel.org>, Frank Li <Frank.Li@kernel.org>,
Akinobu Mita <akinobu.mita@gmail.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2 11/11] dmaengine: dmatest: Avoid unsigned underflow in min_odd()
Date: Tue, 17 Nov 2026 14:51:34 -0500 [thread overview]
Message-ID: <avywRv126XZTrR3N@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20261117163809.622249-12-lee@kernel.org>
On Tue, Nov 17, 2026 at 04:37:12PM +0000, Lee Jones wrote:
> When either argument to min_odd() is zero (for example when a DMA device
> reports max_xor or max_pq as 0), val evaluates to 0 and val - 1
> underflows to UINT_MAX. In dmatest_func(), this sets src->cnt to
> UINT_MAX, which wraps around the (src->cnt + dst->cnt) >= 255 check and
> causes dmatest_alloc_test_data() to pass 0 to kcalloc() and dereference
> ZERO_SIZE_PTR.
>
> Return 0 from min_odd() when the minimum value is 0, and abort
> dmatest_func() if src->cnt is 0.
>
> Fixes: 8be9e32b310c ("dmatest: adjust invalid module parameters for number of source buffers")
> Closes: https://sashiko.dev/#/bug/linux-ca967586-4fc1-47a3-8616-4a9d21fe7455
> Cc: stable@vger.kernel.org
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
>
> v1 => v2: No changes
>
> drivers/dma/dmatest.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
> index 2ae3469397f3..5f768bb9a29f 100644
> --- a/drivers/dma/dmatest.c
> +++ b/drivers/dma/dmatest.c
> @@ -457,6 +457,9 @@ static unsigned int min_odd(unsigned int x, unsigned int y)
> {
> unsigned int val = min(x, y);
>
> + if (!val)
> + return 0;
> +
> return val % 2 ? val : val - 1;
> }
>
> @@ -650,6 +653,9 @@ static int dmatest_func(void *data)
> } else
> goto err_thread_type;
>
> + if (!src->cnt)
> + goto err_free_coefs;
> +
> /* Check if buffer count fits into map count variable (u8) */
> if ((src->cnt + dst->cnt) >= 255) {
> pr_err("too many buffers (%d of 255 supported)\n",
> --
> 2.56.0.679.gc527c65306-goog
>
prev parent reply other threads:[~2026-11-17 19:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 16:37 [PATCH v2 00/11] dmaengine: Fix teardown races, resource leaks, and error handling Lee Jones
2026-11-17 16:37 ` [PATCH v2 01/11] dmaengine: pl08x: Defer OF DMA controller registration until slave setup Lee Jones
2026-11-17 18:44 ` Linus Walleij
2026-11-17 19:37 ` Frank Li
2026-11-17 16:37 ` [PATCH v2 02/11] dmaengine: ae4dma: Let the pending work exit before cancelling it Lee Jones
2026-11-17 19:38 ` Frank Li
2026-11-17 16:37 ` [PATCH v2 03/11] dmaengine: ae4dma: Unregister DMA engine in ae4_pci_remove() Lee Jones
2026-11-17 19:40 ` Frank Li
2026-11-17 16:37 ` [PATCH v2 04/11] dmaengine: ptdma: Unmap descriptor in pt_do_cleanup() Lee Jones
2026-11-17 19:41 ` Frank Li
2026-11-17 16:37 ` [PATCH v2 05/11] dmaengine: ptdma: Remove completed descriptor under vc.lock in pt_cmd_callback_work() Lee Jones
2026-11-17 19:42 ` Frank Li
2026-11-17 16:37 ` [PATCH v2 06/11] dmaengine: amlogic: Destroy free_wq after devres DMA device unregistration Lee Jones
2026-11-17 19:43 ` Frank Li
2026-11-17 16:37 ` [PATCH v2 07/11] dmaengine: arm-dma350: Query dma_cookie_status() under vc.lock in d350_tx_status() Lee Jones
2026-11-17 19:44 ` Frank Li
2026-11-17 16:37 ` [PATCH v2 08/11] dmaengine: bestcomm: Defer publishing bcom_eng until initialisation completes Lee Jones
2026-11-17 19:48 ` Frank Li
2026-11-17 16:37 ` [PATCH v2 09/11] dmaengine: bestcomm: Check rh_create() return value in bcom_sram_init() Lee Jones
2026-11-17 19:49 ` Frank Li
2026-11-17 16:37 ` [PATCH v2 10/11] dmaengine: jz4780: Fix descriptor cleanup on hwdesc setup failure Lee Jones
2026-11-17 19:50 ` Frank Li
2026-11-17 19:54 ` Paul Cercueil
2026-11-17 16:37 ` [PATCH v2 11/11] dmaengine: dmatest: Avoid unsigned underflow in min_odd() Lee Jones
2026-11-17 19:51 ` Frank Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avywRv126XZTrR3N@lizhi-Precision-Tower-5810 \
--to=frank.li@oss.nxp.com \
--cc=Frank.Li@kernel.org \
--cc=akinobu.mita@gmail.com \
--cc=dmaengine@vger.kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®