mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: vjardin@free.fr
Cc: Dong Aisheng <aisheng.dong@nxp.com>,
	 Fabio Estevam <festevam@gmail.com>, Frank Li <Frank.Li@nxp.com>,
	Jacky Bai <ping.bai@nxp.com>,
	 Pengutronix Kernel Team <kernel@pengutronix.de>,
	NXP S32 Linux Team <s32@nxp.com>,
	 Linus Walleij <linusw@kernel.org>, Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	 Sascha Hauer <s.hauer@pengutronix.de>,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	 linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,
	Ioana Ciornei <ioana.ciornei@nxp.com>
Subject: Re: [PATCH v7 6/6] arm64: dts: lx2160a: drop the I2C bus recovery of i2c6 and i2c7
Date: Tue, 17 Nov 2026 23:32:26 +0200	[thread overview]
Message-ID: <avzGrorxOg2GmYOl@lxl00025.wbi.nxp.com> (raw)
In-Reply-To: <20261117-for-upstream-lx2160a-rcw-pinmux-v1-v7-6-5d7201970629@free.fr>

On Tue, Nov 17, 2026 at 03:53:16PM +0100, Vincent Jardin via B4 Relay wrote:
> From: Vincent Jardin <vjardin@free.fr>
> 
> IIC7 and IIC8, the i2c6 and i2c7 nodes, exist only on the SDHC2_DAT[7:4]
> pads, and one RCW field, SDHC2_DAT74_PMUX, muxes all four of them:
>  - 0b010 gives both buses
>  - 0b001 gives GPIO2[18:15]
> 
> The bus recovery of one controller therefore switches the pads of the
> other one to GPIO too, and breaks a transfer of that bus, or its
> target role.
> No lock shared by the two drivers can avoid that.
> 
> The description cannot work either: both nodes point at the same two
> states of the same pad-mux group, so the controller that probes second
> fails with "pin ... already requested".
> No board enables either bus, which is why it did not show.
> 
> Drop the pinctrl and the recovery GPIOs of both nodes, and the two states
> nothing else uses. A board that uses one of the buses can add its own.

You bring a good point, not sure why you didn't bring it on v6 prior to
sending this new series?

As you say, a board may choose to use just one of iic7/iic8, and in that
case, bus recovery should work, as we don't care about the pin states of
the other unused bus. I failed to see this yesterday and deemed the
entire configuration as deletable.

Now I think it's pretty strange to delete the pinctrl and gpio phandles
from the common SoC dtsi and to tell board authors to duplicate them
themselves if they are in that situation.

I think a better alternative would be to add some comments like
"Bus recovery functional only if i2c7 is disabled" above i2c6, and
"Bus recovery functional only if i2c6 is disabled" above i2c7?

I'm not sure whether maintainers could just ignore this patch while
applying?

> 
> Suggested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> Link: https://lore.kernel.org/all/avtsY-7-I7_pdyD0@lxl00025.wbi.nxp.com/
> Signed-off-by: Vincent Jardin <vjardin@free.fr>
> ---
>  arch/arm64/boot/dts/freescale/fsl-lx216x.dtsi | 20 --------------------
>  1 file changed, 20 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx216x.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx216x.dtsi
> index b0bb7bf944059..64903e935131b 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx216x.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx216x.dtsi
> @@ -852,16 +852,6 @@ esdhc0_data75_pins: sdhc1-dir-sdhc-pins {
>  					groups = "sdhc1-dir";
>  				};
>  
> -				gpio1_18_15_pins: iic8-iic7-gpio-pins {
> -					function = "gpio";
> -					groups = "sdhc2-data74";
> -				};
> -
> -				i2c6_i2c7_pins: iic8-iic7-i2c-pins {
> -					function = "i2c";
> -					groups = "sdhc2-data74";
> -				};
> -
>  				i2c0_pins: iic1-i2c-pins {
>  					function = "i2c";
>  					groups = "iic1";
> @@ -1038,11 +1028,6 @@ i2c6: i2c@2060000 {
>  			clock-names = "ipg";
>  			clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL
>  					    QORIQ_CLK_PLL_DIV(16)>;
> -			pinctrl-names = "default", "gpio";
> -			pinctrl-0 = <&i2c6_i2c7_pins>;
> -			pinctrl-1 = <&gpio1_18_15_pins>;
> -			scl-gpios = <&gpio1 16 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> -			sda-gpios = <&gpio1 15 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>  			status = "disabled";
>  		};
>  
> @@ -1055,11 +1040,6 @@ i2c7: i2c@2070000 {
>  			clock-names = "ipg";
>  			clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL
>  					    QORIQ_CLK_PLL_DIV(16)>;
> -			pinctrl-names = "default", "gpio";
> -			pinctrl-0 = <&i2c6_i2c7_pins>;
> -			pinctrl-1 = <&gpio1_18_15_pins>;
> -			scl-gpios = <&gpio1 18 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> -			sda-gpios = <&gpio1 17 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>  			status = "disabled";
>  		};
>  
> 
> -- 
> 2.43.0
> 
>

      reply	other threads:[~2026-11-17 21:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 14:53 [PATCH v7 0/6] lx2160a: change the pad muxes through the RCW override Vincent Jardin via B4 Relay
2026-11-17 14:53 ` [PATCH v7 1/6] dt-bindings: pinctrl: add the NXP LX2160A RCW pad mux Vincent Jardin via B4 Relay
2026-11-17 21:07   ` Vladimir Oltean
2026-11-17 14:53 ` [PATCH v7 2/6] dt-bindings: soc: fsl: layerscape-dcfg: add the LX2160A pad-mux child Vincent Jardin via B4 Relay
2026-11-17 21:07   ` Vladimir Oltean
2026-11-17 14:53 ` [PATCH v7 3/6] soc: fsl: guts: add the RCW override of the pad muxes Vincent Jardin via B4 Relay
2026-11-17 21:10   ` Vladimir Oltean
2026-11-17 22:26     ` Christophe Leroy (CS GROUP)
2026-11-17 14:53 ` [PATCH v7 4/6] pinctrl: freescale: add the Layerscape RCW pad-mux driver Vincent Jardin via B4 Relay
2026-11-17 21:25   ` Vladimir Oltean
2026-11-17 14:53 ` [PATCH v7 5/6] arm64: dts: lx2160a: describe the pad muxes as the DCFG RCW override Vincent Jardin via B4 Relay
2026-11-17 21:26   ` Vladimir Oltean
2026-11-17 14:53 ` [PATCH v7 6/6] arm64: dts: lx2160a: drop the I2C bus recovery of i2c6 and i2c7 Vincent Jardin via B4 Relay
2026-11-17 21:32   ` Vladimir Oltean [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avzGrorxOg2GmYOl@lxl00025.wbi.nxp.com \
    --to=vladimir.oltean@nxp.com \
    --cc=Frank.Li@nxp.com \
    --cc=aisheng.dong@nxp.com \
    --cc=chleroy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=ioana.ciornei@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=ping.bai@nxp.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=s32@nxp.com \
    --cc=shawnguo@kernel.org \
    --cc=vjardin@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®