From: Herbert Xu <herbert@gondor.apana.org.au>
To: Changwei Zou <changwei.zou@canonical.com>
Cc: sahil.malhotra@nxp.com, davem@davemloft.net,
horia.geanta@nxp.com, pankaj.gupta@nxp.com, gaurav.jain@nxp.com,
jeffbarnes@linux.microsoft.com, stephane.debusne@cynove.com,
iuliana.prodan@nxp.com,
martin.kepplinger-novakovic@ginzinger.com, lukas@wunner.de,
sahil.malhotra@oss.nxp.com, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 0/2] crypto: caam - Fix RSA error-path unmap and unaligned dst buffers
Date: Fri, 20 Nov 2026 17:29:34 +0800 [thread overview]
Message-ID: <awAS_kKAVkL2uWKT@gondor.apana.org.au> (raw)
In-Reply-To: <20261114060032.872141-1-changwei.zou@canonical.com>
On Sat, Nov 14, 2026 at 05:00:30PM +1100, Changwei Zou wrote:
> This series fixes two issues in the rsa-caam driver.
>
> Patch 1 fixes wrong unmap operations where rsa_pub_unmap() was called
> regardless of the key type.
>
> Patch 2 adds a bounce buffer to handle unaligned RSA destination
> buffers on DMA-incoherent hardware such as i.MX8, fixing intermittent
> -EKEYREJECTED errors when loading signed kernel modules.
>
> Changes in v6:
> - Patch 1: Factor the priv_form switch into rsa_priv_unmap(), shared by
> rsa_priv_f_done() and rsa_pdb_unmap(), removing the duplicated switch.
> - Patch 2: Hoist req_ctx to function scope in set_rsa_priv_f{1,2,3}_pdb(),
> removing the duplicate block-local declarations in the src/dst branches.
Your series didn't apply for Sashiko:
https://sashiko.dev/#/patchset/20261114060032.872141-1-changwei.zou%40canonical.com
Please rebase and resubmit.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2026-11-20 9:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 6:00 Changwei Zou
2026-11-14 6:00 ` [PATCH v6 1/2] crypto: caam - Fix wrong unmap operations Changwei Zou
2026-11-16 18:05 ` Sahil Malhotra
2026-11-14 6:00 ` [PATCH v6 2/2] crypto: caam - Use bounce buffer for unaligned RSA destination buffers Changwei Zou
2026-11-16 18:05 ` Sahil Malhotra
2026-11-18 23:13 ` Changwei Zou
2026-11-20 9:29 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=awAS_kKAVkL2uWKT@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=changwei.zou@canonical.com \
--cc=davem@davemloft.net \
--cc=gaurav.jain@nxp.com \
--cc=horia.geanta@nxp.com \
--cc=iuliana.prodan@nxp.com \
--cc=jeffbarnes@linux.microsoft.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=martin.kepplinger-novakovic@ginzinger.com \
--cc=pankaj.gupta@nxp.com \
--cc=sahil.malhotra@nxp.com \
--cc=sahil.malhotra@oss.nxp.com \
--cc=stephane.debusne@cynove.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®