On Thu, Nov 19, 2026 at 09:57:44AM -0800, Kyle Hendry via B4 Relay wrote: > From: Kyle Hendry > > The rzn1 system controller has two resets that need to be cleared for the > mii converter to work. They are not directly associated with any clocks > so they need a reset controller to set them. > > They are documented in the PWRCTRL_SWITCHCTRL (0x4000C188) register as: > > Bit 3: RSTN_CLK25 - Active low Reset for Timestamp signal selection logic > Bit 4: RSTN_ETH - Active low Reset for RGMII/RMII Converter (50 MHz). > > Add a reset controller and add resets for those bits. > > Signed-off-by: Kyle Hendry General approach looks good to me, just some minor comments... > +static const struct regbit r9a06g032_resets[] = { > + RB(0x188, 3), > + RB(0x188, 4), > +}; Please add the DT name of the reset as a comment after each line. + RB(0x188, 3), /* RST_TS */ or similar. > +static int r9a06g032_reset_set(struct reset_controller_dev *rcdev, > + const char *func, bool set, unsigned long id) > +{ *func was likely debug help and is unused now and can go. > + struct r9a06g032_priv *priv = rcdev_to_priv(rcdev); > + unsigned long flags; > + > + spin_lock_irqsave(&priv->lock, flags); > + clk_rdesc_set(priv, r9a06g032_resets[id], set); > + spin_unlock_irqrestore(&priv->lock, flags); > + > + return 0; > +} > + > +static int r9a06g032_reset(struct reset_controller_dev *rcdev, > + unsigned long id) > +{ > + r9a06g032_reset_set(rcdev, "reset", true, id); > + udelay(5); For future reference, please add a comment pointing to chapter in the docs where it is saying 5us is needed. Rest looks good!