From: Herbert Xu <herbert@gondor.apana.org.au>
To: T Pratham <t-pratham@ti.com>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
Sebin Francis <sebin.francis@ti.com>,
Manorit Chawdhry <m-chawdhry@ti.com>,
Praneeth Bajjuri <praneeth@ti.com>,
Vishal Mahaveer <vishalm@ti.com>
Subject: Re: [PATCH v13 00/15] Fix several issues in DTHEv2 driver
Date: Fri, 20 Nov 2026 17:54:34 +0800 [thread overview]
Message-ID: <awAY2r7Rum8H6Vig@gondor.apana.org.au> (raw)
In-Reply-To: <20261112081204.1146395-1-t-pratham@ti.com>
On Thu, Nov 12, 2026 at 01:41:48PM +0530, T Pratham wrote:
> This series fixes a handful of independent and mostly benign till now
> issues in the DTHEv2 driver which were flagged by bots and AI agents.
> Except for the fifth patch in this series which was found in an internal
> testing.
>
> The Sashiko review on DTHEv2 hashing driver patch series v5 pointed out
> some pre-existing issues which needed to be fixed [1].
>
> One of the issues had already been flagged by kernel test bot and a fix
> sent on the list by Mert [2].
>
> I included this patch in this series with minor edits. Then the Sashiko
> review page for [2] had more comments [3]
>
> Overall this resulted in a bunch of fixes patches which would have
> deviated the DTHEv2 hashing driver series had they been included with
> it. So I clubbed them together in a new patch series which is this.
>
> Signed-off-by: T Pratham <t-pratham@ti.com>
> ---
> Links:
> [1]: https://sashiko.dev/#/patchset/20260807110501.975130-1-t-pratham%40ti.com
> [2]: https://lore.kernel.org/all/20260613085858.32580-1-mertsftl@gmail.com/
> [3]: https://sashiko.dev/#/patchset/20260613085858.32580-1-mertsftl%40gmail.com
>
> Changelog:
> v13:
> - Put kref in probe error path (regression reported by Sashiko).
> v12:
> - Rebased and resolved merge conflicts. No functional changes.
> v11:
> - Changed order of operations in probe.
> - Added comments in AEAD Tag helper functions.
> v10:
> - Corrected typo (dev --> ctx->dev)
> v9:
> - Changed extensive completion re-init based wait to using kref in
> patch 04/15
> v8:
> - Minor fix based on Sashiko comment (corrected spinlock)
> v7:
> - Fixes based on Sashiko comments (added locking around
> dthe_put_drvdata)
> v6:
> - Fixes based on Sashiko comments (waitqueue -> completion; DMA
> alignment for cache coherency)
> v5:
> - Fix spinlock inconsistency patch
> v4:
> - Fixes based on Sashiko comments
> v3:
> - Fixes based on Sashiko comments
> - Some reordering of patches
> v2:
> - Fixes based on Sashiko comments
>
> Link to previous versions:
> v12: https://lore.kernel.org/all/20261107160631.2592763-1-t-pratham@ti.com/
> v11: https://lore.kernel.org/all/20261107145618.2349562-1-t-pratham@ti.com/
> v10: https://lore.kernel.org/all/20261016124456.1802080-1-t-pratham@ti.com/
> v9: https://lore.kernel.org/all/20261016114806.1749515-1-t-pratham@ti.com/
> v8: https://lore.kernel.org/all/20261001085245.2922974-1-t-pratham@ti.com/
> v7: https://lore.kernel.org/all/20260930125859.1749849-1-t-pratham@ti.com/
> v6: https://lore.kernel.org/all/20260930112533.1593952-1-t-pratham@ti.com/
> v5: https://lore.kernel.org/all/20260918102245.2784000-1-t-pratham@ti.com/
> v4: https://lore.kernel.org/all/20260910175619.2122149-1-t-pratham@ti.com/
> v3: https://lore.kernel.org/all/20260910104202.1537226-1-t-pratham@ti.com/
> v2: https://lore.kernel.org/all/20260827132318.613876-1-t-pratham@ti.com/
> v1: https://lore.kernel.org/all/20260827105711.527182-1-t-pratham@ti.com/
> ---
>
> Mert Seftali (1):
> crypto: ti - Use list_first_entry_or_null() in dthe_get_dev()
>
> T Pratham (14):
> crypto: ti - Fix spinlock inconsistency in DTHEv2
> crypto: ti - Fix potential memory corruption on highmem pages
> crypto: ti - Fix use-after-free of dev_data on DTHEv2 driver removal
> crypto: ti - Trim scatterlists to correct length in AES
> crypto: ti - Align buffers to cacheline for DMA
> crypto: ti - Separate padding buffer for src and dst
> crypto: ti - Validate sg_nents_for_len() return value in DTHEv2 AES
> crypto: ti - Validate sg_nents_for_len() return value in DTHEv2 AEAD
> crypto: ti - Terminate DMA on all error paths in AES to clear
> descriptors
> crypto: ti - Terminate DMA on all error paths in AEAD to clear
> descriptors
> crypto: ti - Do AEAD software fallback on only ENOMEM
> crypto: ti - Correct AEAD tag operations against dma cache
> invalidation
> crypto: ti - Change lengths in AES to u64 to avoid potential overflows
> crypto: ti - Change lengths in AEAD to u64 to avoid potential
> overflows
>
> drivers/crypto/ti/dthev2-aes.c | 378 +++++++++++++++++++-----------
> drivers/crypto/ti/dthev2-common.c | 84 +++++--
> drivers/crypto/ti/dthev2-common.h | 66 +++++-
> 3 files changed, 365 insertions(+), 163 deletions(-)
>
>
> base-commit: 99f506c86bf8b6909564fff64eeaa64dec5996b9
> --
> 2.34.1
All applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2026-11-20 9:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 8:11 T Pratham
2026-11-12 8:11 ` [PATCH v13 01/15] crypto: ti - Use list_first_entry_or_null() in dthe_get_dev() T Pratham
2026-11-12 8:11 ` [PATCH v13 02/15] crypto: ti - Fix spinlock inconsistency in DTHEv2 T Pratham
2026-11-12 8:11 ` [PATCH v13 03/15] crypto: ti - Fix potential memory corruption on highmem pages T Pratham
2026-11-12 8:11 ` [PATCH v13 04/15] crypto: ti - Fix use-after-free of dev_data on DTHEv2 driver removal T Pratham
2026-11-12 8:11 ` [PATCH v13 05/15] crypto: ti - Trim scatterlists to correct length in AES T Pratham
2026-11-12 8:11 ` [PATCH v13 06/15] crypto: ti - Align buffers to cacheline for DMA T Pratham
2026-11-12 8:11 ` [PATCH v13 07/15] crypto: ti - Separate padding buffer for src and dst T Pratham
2026-11-12 8:11 ` [PATCH v13 08/15] crypto: ti - Validate sg_nents_for_len() return value in DTHEv2 AES T Pratham
2026-11-12 8:11 ` [PATCH v13 09/15] crypto: ti - Validate sg_nents_for_len() return value in DTHEv2 AEAD T Pratham
2026-11-12 8:11 ` [PATCH v13 10/15] crypto: ti - Terminate DMA on all error paths in AES to clear descriptors T Pratham
2026-11-12 8:11 ` [PATCH v13 11/15] crypto: ti - Terminate DMA on all error paths in AEAD " T Pratham
2026-11-12 8:12 ` [PATCH v13 12/15] crypto: ti - Do AEAD software fallback on only ENOMEM T Pratham
2026-11-12 8:12 ` [PATCH v13 13/15] crypto: ti - Correct AEAD tag operations against dma cache invalidation T Pratham
2026-11-12 8:12 ` [PATCH v13 14/15] crypto: ti - Change lengths in AES to u64 to avoid potential overflows T Pratham
2026-11-12 8:12 ` [PATCH v13 15/15] crypto: ti - Change lengths in AEAD " T Pratham
2026-11-20 9:54 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=awAY2r7Rum8H6Vig@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-chawdhry@ti.com \
--cc=praneeth@ti.com \
--cc=sebin.francis@ti.com \
--cc=t-pratham@ti.com \
--cc=vishalm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®