From: Johan Hovold <johan@kernel.org>
To: Joshua Crofts <crofts@kernel.org>
Cc: "Bin Liu" <b-liu@ti.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Felipe Balbi" <balbi@ti.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Sashiko <sashiko-bot@kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] usb: musb: fix use-after-free in musb_remove()
Date: Fri, 20 Nov 2026 15:51:24 +0100 [thread overview]
Message-ID: <awBebBuAg2w6ZitD@hovoldconsulting.com> (raw)
In-Reply-To: <20261120-usb-uaf-fix-v2-1-cc3cb2a38ad5@kernel.org>
On Fri, Nov 20, 2026 at 03:23:14PM +0100, Joshua Crofts wrote:
> Currently in musb_remove(), musb_platform_exit() drops the PHY refcount
> before usb_phy_shutdown() is called, causing a use-after-free bug.
This is too strongly worded. There is a potential for a use-after-free
here but it's extremely unlikely to ever be an issue in practice as the
phy driver would need to be unloaded by root while they are already
unbinding the host controller.
Why would root want to do that to themselves?
Johan
next prev parent reply other threads:[~2026-11-20 14:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 14:23 Joshua Crofts
2026-11-20 14:51 ` Johan Hovold [this message]
2026-11-20 14:56 ` Joshua Crofts
2026-11-20 14:58 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=awBebBuAg2w6ZitD@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=b-liu@ti.com \
--cc=balbi@ti.com \
--cc=crofts@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-bot@kernel.org \
--cc=stable@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®