From: Johan Hovold <johan@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Daniel Scally <djrscally@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Bartosz Golaszewski <brgl@kernel.org>,
Andi Shyti <andi.shyti@kernel.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
driver-core@lists.linux.dev, linux-acpi@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/8] driver core: platform: fix swnode use-after-free on device release
Date: Fri, 20 Nov 2026 16:33:25 +0100 [thread overview]
Message-ID: <awBoRYvZEdI40B_R@hovoldconsulting.com> (raw)
In-Reply-To: <20261117101336.980216-1-johan@kernel.org>
On Tue, Nov 17, 2026 at 11:13:28AM +0100, Johan Hovold wrote:
> When fixing a use-after-free regression in 7.3, I noticed that the
> software node implementation is internally inconsistent.
>
> Specifically, the firmware node pointer of a struct device may point to
> either a primary or secondary firmware node, but in several places
> kernel-doc and comments suggests that the firmware node pointer always
> points to a primary node (cf. [1][2]).
>
> This series fixes the 7.3 regression along with a similar issue in i2c
> core due which are both stem from the fact that
> device_remove_software_node() happens to drop a reference to a primary
> software node that was never added by device_add_software_node().
>
> The next two patches clarify that device_remove_software_node() should
> only be used to remove nodes added by device_add_software_node() and
> stops touching primary nodes.
>
> The rest of the series addresses further inconsistencies.
>
> The first two fixes could go into 7.4 and the rest (which depends on the
> fixes) into 7.5. And preferably with an ack from the i2c maintainer for
> patches 2/8 and 4/8.
> Johan Hovold (8):
> driver core: platform: fix swnode use-after-free on device release
> i2c: core: fix swnode use-after-free on client deregistration
I have applied these two for 7.4 now.
> software node: fix device_add_software_node() kernel doc
> software node: ignore primary nodes in device_remove_software_node()
> driver core: platform: warn on bad fwnode assignment
> driver core: platform: tests: fix swnode reuse test description
> software node: fix software_node_notify() primary node comment
> device property: fix fwnode_get_next_child_node() comments
Johan
prev parent reply other threads:[~2026-11-20 15:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 10:13 Johan Hovold
2026-11-17 10:13 ` [PATCH v3 1/8] " Johan Hovold
2026-11-17 10:13 ` [PATCH v3 2/8] i2c: core: fix swnode use-after-free on client deregistration Johan Hovold
2026-11-17 10:13 ` [PATCH v3 3/8] software node: fix device_add_software_node() kernel doc Johan Hovold
2026-11-17 15:06 ` Rafael J. Wysocki (Intel)
2026-11-17 10:13 ` [PATCH v3 4/8] software node: ignore primary nodes in device_remove_software_node() Johan Hovold
2026-11-17 14:01 ` Andy Shevchenko
2026-11-18 9:36 ` Johan Hovold
2026-11-18 10:39 ` Andy Shevchenko
2026-11-17 10:13 ` [PATCH v3 5/8] driver core: platform: warn on bad fwnode assignment Johan Hovold
2026-11-17 15:24 ` Rafael J. Wysocki (Intel)
2026-11-17 10:13 ` [PATCH v3 6/8] driver core: platform: tests: fix swnode reuse test description Johan Hovold
2026-11-17 10:13 ` [PATCH v3 7/8] software node: fix software_node_notify() primary node comment Johan Hovold
2026-11-17 15:25 ` Rafael J. Wysocki (Intel)
2026-11-17 10:13 ` [PATCH v3 8/8] device property: fix fwnode_get_next_child_node() comments Johan Hovold
2026-11-17 15:26 ` Rafael J. Wysocki (Intel)
2026-11-20 15:33 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=awBoRYvZEdI40B_R@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brgl@kernel.org \
--cc=dakr@kernel.org \
--cc=djrscally@gmail.com \
--cc=driver-core@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®