From: "Uwe Kleine-König" <ukleinek@kernel.org>
To: Zhu Jun <zhujun2@cmss.chinamobile.com>
Cc: nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
claudiu.beznea@tuxon.dev, linux-pwm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pwm: atmel-tcb: Fix the channel restart write on resume
Date: Fri, 20 Nov 2026 17:06:35 +0100 [thread overview]
Message-ID: <awBvPEph3wqbEqxV@monoceros> (raw)
In-Reply-To: <20261112071615.154385-1-zhujun2@cmss.chinamobile.com>
[-- Attachment #1: Type: text/plain, Size: 685 bytes --]
On Thu, Nov 12, 2026 at 03:16:15PM +0800, Zhu Jun wrote:
> atmel_tcb_pwm_resume() passes the start command as the register address
> and the channel control register offset as the value. The command is
> 0x5, which is not an aligned register address, so regmap rejects the
> write and an enabled PWM channel is not restarted after resume.
>
> Pass the channel control register first and the clock-enable and
> software-trigger bits second.
>
> Fixes: 061f8572a31c ("pwm: atmel-tcb: Switch to new binding")
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next
Thanks
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2026-11-20 16:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 7:16 Zhu Jun
2026-11-20 16:06 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=awBvPEph3wqbEqxV@monoceros \
--to=ukleinek@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=zhujun2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®