From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=pass header.oldest-pass=0 smtp.remote-ip=52.101.84.29 ARC-Seal: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=pass; t=1795196911; b=L+mYMQiVo7e9iXjuD3//0h93ltOHw4S8VgC8SCKVVyQgqP1jkCxAcos/yoUmfyw8CQzX jCsVkl+GmPYgvzptCAIc5cdsbXPOehQn692eKd7NkMK+54jxm5MtJ3pPdRBvxeYJj1hvP rQMKVm3yaHrZIm48GotfWeTmz9jKAcISYpqZX0+4W5eJ7e/Ype+GnKysZXfO3C6ca4Vnn tRBSWm9NAmg1wecx6Y91M6krCpicPNjmPpmF2jJRELIdibmWcZtqpomLu9vBqcSPrJDve fSDfTMs78/qwZU60tbF5eQxJcOA95Ax16ibSW4S0wdFS/TiaqsYRCDR6TwVpbwgkRXQ== ARC-Message-Signature: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795196911; h=DMARC-Filter:DKIM-Signature:Received:Received:Date:From:To:Cc: Subject:Message-ID:References:Content-Type:Content-Disposition: In-Reply-To:X-ClientProxiedBy:MIME-Version:X-MS-PublicTrafficType: X-MS-TrafficTypeDiagnostic:X-MS-Office365-Filtering-Correlation-Id: X-MS-Exchange-SenderADCheck:X-MS-Exchange-AntiSpam-Relay: X-Microsoft-Antispam:X-Microsoft-Antispam-Message-Info: X-Forefront-Antispam-Report: X-MS-Exchange-AntiSpam-MessageData-ChunkCount: X-MS-Exchange-AntiSpam-MessageData-0:X-OriginatorOrg: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-OriginalArrivalTime: X-MS-Exchange-CrossTenant-FromEntityHeader: X-MS-Exchange-CrossTenant-Id:X-MS-Exchange-CrossTenant-MailboxType: X-MS-Exchange-CrossTenant-UserPrincipalName: X-MS-Exchange-Transport-CrossTenantHeadersStamped; bh=xkxYiItbZ86vgJA1OvkWNQ5hPRrqzZPLxGON1VjSx2o=; b=y5JkIVXrcrC46SJ0hPYiTrKlx2g4GrVYWQ2aQUQRZfHN0/9uRtp+yHyELqNesihZayOa BmyUN2jEpYiFpcOYJX69v7v+w3Q2vCNZmZpOOJkEXXWNITVUdTQmLmxBS0MBl/H6Y9Um8 PuzAGnwySwBUOPvMQrFcHhQJe/bOX0VBZ3W8d+biD3mALMZw+xAXFb+mu+PxRKtV1H3II vpcnhtAxYISzi5RQ2Hc4qLex+8pb/zrHI0+0/weAor/zH7v9R1A+YuR3U6ghM0bUedS3w RvhGN4d0gc2sCa9ZsRaHsBR07VMvhELMk0vTplT1x+j7/IohkPp5YbGEphDm3H4cBZQ== ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.a=rsa-sha256 header.s=selector1-NXP1-onmicrosoft-com header.b=qIjlDkhl; arc=pass header.oldest-pass=0 smtp.remote-ip=52.101.84.29 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11010029.outbound.protection.outlook.com [52.101.84.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (secp384r1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85B64606A339; Fri, 20 Nov 2026 17:48:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 85B64606A339 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.a=rsa-sha256 header.s=selector1-NXP1-onmicrosoft-com header.b=qIjlDkhl ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KeygLr8t6WqgvfvdpRMjDKLK/Eue4Jzdn7Np6y8+ISjzjFwpAktqCUVLHSevivXsHg+K9e8wALSL7HpT59whyZj+71Vq5OUCzk5/HZ8RKmz/bwggD6E3NKAxYNvpukPDtCz/BLfilk702VOZkOtbpSweDicLsdXg3KbWdXabGQgQr7pTE+iPi7csa/9FcUI8pfo4MnMRT52TFFaIGgHxweAHPSeHFDQ5iKLU4WAVWxmi79Z/zb3UpHyQ4uG8Esn6EEZ9wN0EpZ/LJbNqa3WxHS4lr8gJJFwWFLBPPxJd5pAK9HH1tnKNofoVYfxecJ3J4J3E4nHZLe2W32f9qL/KSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xkxYiItbZ86vgJA1OvkWNQ5hPRrqzZPLxGON1VjSx2o=; b=Z2TxYXah1jSt1IWiFAo5RsXgCZRI0gRRdO79T0I2+CFKAcRyWQMv356URZRe6hAmAg5D+ybdxzhM7ha56/r7SO4UXAZ7zRd73R+Epv55lapT4j82Wv59QdASQppxpLfZy6cjAs4cdHdDPo0hlvl0uyh25ZErw8DBDLhEntRIbZgzXc3guyHmhzCH29sR4zOvkTbscEjZes4qB3/UWQ3L5w4PF3MTZ1kU/SdjjX4P/cGuGBY/v00GbApW6VIbm8tromNaAKRnw8t9m24tki9QF69F7S7AUOEJgNSjT/KtECxAPNhYGZBVKIfS5nPlySRmxEC7CGCB0obNc1uwi7O2iQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xkxYiItbZ86vgJA1OvkWNQ5hPRrqzZPLxGON1VjSx2o=; b=qIjlDkhlV/mMARttRccWhtMT5K85icYOIyGRtR0iw0Caq7g2NJ1dd31kdGI/CNK+aItLrMNZO2q9WHh3DRMjaxKA4suLsfiBQoDYnwXGV83STctCyvrVQwa1kxF8YmBbdzu0yvUlZlS6bZJFjpP+0FJTSCPaB/odB5hUHUC4qsDiu361e+StWoang2F97NqXuvZwxe5kEJvss7PIiZos8n+sbIRbKWIYr24UBy5UUz2vz3SbgpUCouKQycaraM51jNjTwkyEgGGOlWWAd16RU2jMtlEN6IQSypSLaFXVA6F5VSh1v8lDT0UH8ukzkLv+PTDh7g7z7yDZuKPDgzTK6w== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from MI3PR04MB12438.eurprd04.prod.outlook.com (2603:10a6:290:76::14) by DB9PR04MB8409.eurprd04.prod.outlook.com (2603:10a6:10:244::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.639.12; Fri, 20 Nov 2026 17:48:25 +0000 Received: from MI3PR04MB12438.eurprd04.prod.outlook.com ([fe80::c715:c32:8bb1:b70b]) by MI3PR04MB12438.eurprd04.prod.outlook.com ([fe80::c715:c32:8bb1:b70b%4]) with mapi id 15.21.0639.010; Fri, 20 Nov 2026 17:48:25 +0000 Date: Fri, 20 Nov 2026 11:48:15 -0600 From: Frank Li To: Amelie Delaunay Cc: Vinod Koul , Frank Li , Maxime Coquelin , Alexandre Torgue , dmaengine@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jerome Audu , stable@vger.kernel.org Subject: Re: [PATCH 1/4] dmaengine: stm32-dma3: clear flags before signaling transfer completion Message-ID: References: <20261120-dma3-fixes-v1-0-f29c1f437399@foss.st.com> <20261120-dma3-fixes-v1-1-f29c1f437399@foss.st.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261120-dma3-fixes-v1-1-f29c1f437399@foss.st.com> X-ClientProxiedBy: PH7PR02CA0016.namprd02.prod.outlook.com (2603:10b6:510:33d::15) To MI3PR04MB12438.eurprd04.prod.outlook.com (2603:10a6:290:76::14) X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MI3PR04MB12438:EE_|DB9PR04MB8409:EE_ X-MS-Office365-Filtering-Correlation-Id: 0c0530a7-3483-479b-dd6c-08df472e7a06 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|23010399003|1800799024|376014|7416014|366016|261026121527099003|261022075727099003|261021123027099003|261021121427099003|261102123227099003|11063799006|4143699003|56012099006|10067099003|261009223027099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: tgO/SDmwgpI2oj6xrhy/PZePvw7l1PTxEtDVJI06zEGI3ARbd3rtADWNSMsj3w/ovr5a6m6DWlDHii/1ETC7r/qo8io1x94Hj4f48fTCXMX/3pLxDPHvtxsRYXuWLX+HL7P0vZuPxgZtyjJWfvU7vwKiRQOWEaa6dqGyQtraDtV+Ks1qVRNzo3sSPxD5Rzn/MWlEAf81Pi7+I0mA/LXIdrXJSceHcvo3tbFPyQCDMC3sJCrMo1sN0SKThjjx3BUTfvzqrkhNTpqodEO0ORMLmlFFUN4HR3zrYtczzAcuGn08EKg9poiI38xdgTQntonMyS9G7QxDO8kE/hBOxGWB0rom6rV7a/bUaXE51fYilyY5+w9Lq+K0yG6AwooOlln9306IxGEdQ+PrT++ZuIyAyFjJaUmN99tmJgAygFhRUCwArJsBPecyiKUR3RPFI6HpAd8Qm4Wac3mXSbvA1uUYzR/jJ9WSzJH+kh/JKZYyUPrG34mMcyNTK7d9dqD6j68iRd30JYFODtzYMZql/ni15jfCyCmrOom8D1j5HPAodY9cW+8k2g5mWdg1pMyIqCEhN9/POuHaQVgVAaNNIU3PXqamvuqPr/N93amF3LqnG3736pwgxiSTe/0zw0HehrNdxyLp7gN4+oDaofF0YDbORrWnF/RRNErbiI+qVhdM/f8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MI3PR04MB12438.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(23010399003)(1800799024)(376014)(7416014)(366016)(261026121527099003)(261022075727099003)(261021123027099003)(261021121427099003)(261102123227099003)(11063799006)(4143699003)(56012099006)(10067099003)(261009223027099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?63eG07+5jER/3chhKKpInLyAXqRoEUkjHXiU/HVS2qE3SNldZ0Pa81CCEAJI?= =?us-ascii?Q?7OhvCEAD2aUxXKiKfnu2sfyDVyBUvNpVsn3ZKg6GZEUCpuouWZVMNEAwjm1Z?= =?us-ascii?Q?QiHB7A+PL6AcKwBf86ArWs+dh4LogqOsRHqL7vlGK86+zzZPkTA1zkuEN0Cj?= =?us-ascii?Q?NVkmpqEl5IBQ1+Fs7iAMwiRT/X9xBlN562x54TrkGNJWKTCxlGIPFUtCqwWo?= =?us-ascii?Q?wBM0zdwmyVoWRi74V9W/DwTCmdIOIrgpjzBXh8DVdNDQM5F+pUeUq/njsFph?= =?us-ascii?Q?bHrMgkMo1KnVSrdbVyz/cILjsvlbuSGEccbregDK+KbfJkVJRtYHnDXBT6yo?= =?us-ascii?Q?5m2gXavkANY924OS0G3vCo6NxC+5db+b1RcM2plooWuL8Ouq8UG7f5Sj4oND?= =?us-ascii?Q?DSdb98Eq43xEK6MO5lOfwl7Oji9M7uGjOyy82mvbB10DXOU4k6fhiX1BjSte?= =?us-ascii?Q?Qn5aIdqw/IS6F/5u7ZveBVmlpjxg8uiCPnxDIajF2l9plnkQkXW+SeBpilPG?= =?us-ascii?Q?5roZ7EmJFndw1AHPdI71G+v5VukeL1it+vvjiW9Q/9gaOHfhtPPJAKr11ELO?= =?us-ascii?Q?lAW9ySsKlg/YtbSESstwNBmWDPnqpraOwnR8bjrzvf7Nq0J1l5EJnxAN0ZlV?= =?us-ascii?Q?LV2IBIqn0sB5ssAXKCYha38P97bITJtRjh6m7fNMpxJJPp6n5HmrLVxZy4Zw?= =?us-ascii?Q?3HWolkprPWzexhWgJ5TsluDmG7FZRKyt3Cov1yVJAy6unTu6DX/dbPNcrx0S?= =?us-ascii?Q?FcjkcZVgvboKMoxTV674gjD5zhzavnEqObtEbVTJdvY5XiEpmzjv06AOiRPn?= =?us-ascii?Q?5Fasr/CaAg7xEnHd+y8w0zmWyaPvnUPc1bUYJgX2ROSwjjOqDUNgbKi1i0gL?= =?us-ascii?Q?jJtSwxIIxsnSiSqRUruei4WPWxwyAbATrV2q88DiHvzF33glZyNzEJ0g12dZ?= =?us-ascii?Q?N684M7e5DHuEZVJ8x6MfQyQY37/jYs6rL6ghYM4rNtFobM6cqmMDSAGTlFvO?= =?us-ascii?Q?5M05vMNlID/cgABrIpE9h0KSyB596uJ/4gJoMpp4xp5U2FIpJnl7KoSJgRKM?= =?us-ascii?Q?vFfHpH5xXJpECz67mRy4XPHIxsdy1kRhvOCbjrYWEHHAnM/LN0XCKhBzM+PF?= =?us-ascii?Q?PvZzNFtisNRRC5uUgGkekGd0Ri/rvF9jZDHl3wSaEk2N7ZRSYkOinCcPN6hv?= =?us-ascii?Q?uVc5VT5v3sjj38MpCvu/lSD4O9Pfb2bcvDgtAku3ZpWlqFFE6hnPAju3oZQG?= =?us-ascii?Q?/Bho7VZerK1g2bPRmRnPxEdy+KDikG9y7cGA6A8fTXW/ZyhwXOMJ/FdE8zoj?= =?us-ascii?Q?IP0KBrtmXDwTIH6cnJLqodFzDazqg4ybIA2D1hUPHfBnaZmPQUfGA4z9bbrs?= =?us-ascii?Q?TUfgbLLAPK8m+gKt3/r8UpCVqYM1Qe4GDzoGrXNssH6u9UF6jkWflJ9KLLjS?= =?us-ascii?Q?eXMG5Sacb/IQIWYPzoidjcwAp3gTCwDXM11W0atXXhHojTpv9Fp0IwhO3RL6?= =?us-ascii?Q?ZxZFI1AUckPm63a0dJwPdSVRWmgbbBhRJUipOEq48jEGVhm1hFSK6rnGWEGj?= =?us-ascii?Q?igfItNqVxk+ZnH5JgPfVl/AeaK3LdSBomhw0nAXTFJFkcDsjtwmL7Ci8xImx?= =?us-ascii?Q?yp4eBZ/l1sQZlq2uyp6bgNYQlb8bvJjIv59nP3SailzJB/4eON5SLfb9ZbCI?= =?us-ascii?Q?qy1uWPSLcvZ8bs7Qj1Pi/roCVltz9w2zfp1MaY7rnQOoPvyjTWUhVkrfngfu?= =?us-ascii?Q?BeYAQCW5dOV8UXqsP25XaLJ5UFvuDGbf/FHronYqv6VcQ4tv6cqm?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c0530a7-3483-479b-dd6c-08df472e7a06 X-MS-Exchange-CrossTenant-AuthSource: MI3PR04MB12438.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2026 17:48:25.2643 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TLzgVM/rECeqVwv7YcSdxjZGcPHxKpojnbzwVM2D7nLOuzlhkjEqR9U9E7RI/L/bj67KsT+D5hUOnaYqjGSpDB5IhN5/EE22HRXRoHsR0hTEG3uYJMS9toUfgxmIZa0U X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8409 On Fri, Nov 20, 2026 at 10:18:01AM +0100, Amelie Delaunay wrote: > From: Jerome Audu > > On a Transfer Complete event, a new transfer can be started from > stm32_dma3_chan_complete(). The new transfer may finish while the end of > stm32_dma3_chan_irq() is still executing, in which case the flag clearing > done at the end of the handler also clears the new transfer's Transfer > Complete flag without the end of that transfer being handled, which may > lead to a timeout. > > Clear the flags before handling completion to make sure that if > stm32_dma3_chan_complete() starts an ultra-fast transfer, its TCF flag is > not accidentally cleared. This reordering is also safe for the other > handled interrupt conditions, since csr holds the channel status and is > used to select the handling path. Can you rephrase commit message. clean irq flags should just after get status before do actually handle. Actual handle may cause new irqs. It is quite common pattern for irq handler. Some thing like Move clear irq state just after fetch state to avoid lost irq because actual handle work (i.e stm32_dma3_chan_complete()) may issue new irq. Frank > > Fixes: f561ec8b2b33 ("dmaengine: Add STM32 DMA3 support") > Cc: stable@vger.kernel.org > Signed-off-by: Jerome Audu > Signed-off-by: Amelie Delaunay > --- > drivers/dma/stm32/stm32-dma3.c | 19 +++++++++---------- > 1 file changed, 9 insertions(+), 10 deletions(-) > > diff --git a/drivers/dma/stm32/stm32-dma3.c b/drivers/dma/stm32/stm32-dma3.c > index 4fe226541efa..a464e0cefd64 100644 > --- a/drivers/dma/stm32/stm32-dma3.c > +++ b/drivers/dma/stm32/stm32-dma3.c > @@ -1008,7 +1008,7 @@ static irqreturn_t stm32_dma3_chan_irq(int irq, void *devid) > { > struct stm32_dma3_chan *chan = devid; > struct stm32_dma3_ddata *ddata = to_stm32_dma3_ddata(chan); > - u32 misr, csr, ccr; > + u32 misr, csr, ccr, cfcr; > > spin_lock(&chan->vchan.lock); > > @@ -1021,6 +1021,14 @@ static irqreturn_t stm32_dma3_chan_irq(int irq, void *devid) > csr = readl_relaxed(ddata->base + STM32_DMA3_CSR(chan->id)); > ccr = readl_relaxed(ddata->base + STM32_DMA3_CCR(chan->id)) & CCR_ALLIE; > > + /* > + * Half Transfer Interrupt may be disabled but Half Transfer Flag can be set, > + * ensure HTF flag to be cleared, with other flags. > + */ > + cfcr = csr & (ccr | CCR_HTIE); > + if (cfcr) > + writel_relaxed(cfcr, ddata->base + STM32_DMA3_CFCR(chan->id)); > + > if (csr & CSR_TCF && ccr & CCR_TCIE) { > if (chan->swdesc->cyclic) > vchan_cyclic_callback(&chan->swdesc->vdesc); > @@ -1050,15 +1058,6 @@ static irqreturn_t stm32_dma3_chan_irq(int irq, void *devid) > stm32_dma3_chan_reset(chan); > } > > - /* > - * Half Transfer Interrupt may be disabled but Half Transfer Flag can be set, > - * ensure HTF flag to be cleared, with other flags. > - */ > - csr &= (ccr | CCR_HTIE); > - > - if (csr) > - writel_relaxed(csr, ddata->base + STM32_DMA3_CFCR(chan->id)); > - > spin_unlock(&chan->vchan.lock); > > return IRQ_HANDLED; > > -- > 2.43.0 >