From: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
To: Rik van Riel <riel@surriel.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
David Hildenbrand <david@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Suren Baghdasaryan <surenb@google.com>,
Christoph Hellwig <hch@infradead.org>,
Yuan-Hao Hsu <aa9736195201@gmail.com>,
John Hubbard <jhubbard@nvidia.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH v5 5/8] mm/gup: break out gup_lookup_pte() helper
Date: Fri, 20 Nov 2026 19:01:42 +0000 [thread overview]
Message-ID: <awCZDX2IG2VKgSKx@gremlin> (raw)
In-Reply-To: <5f18488c8234ee28e9c638abacf4961311d866f6.camel@surriel.com>
On Fri, Nov 20, 2026 at 01:10:47PM -0500, Rik van Riel wrote:
> On Fri, 2026-11-20 at 17:33 +0000, Lorenzo Stoakes (ARM) wrote:
> > On Thu, Nov 19, 2026 at 10:04:04PM -0500, Rik van Riel wrote:
> >
> >
> > Right, I think I need to see it in context to judge really :) but
> > obviously we
> > can't be introducing completely dead code like that, even
> > incrementally.
>
> Agreed. That's been cleaned up now.
Thanks :)
> >
> > >
> > > >
> > > > 'need_no_page_table' isn't a great name either. Maybe is_none or
> > > > something?
> > > >
> > > Maybe pte_is_none?
> >
> > OK, let's see how that looks in context.
> >
> > Since you've not replied to the rest of the reviews I will assume
> > implicit 'ack,
> > will do's or what not on those? ;)
>
> Those are all "will do's", or rather already done
> but not posted yet because I'm combing through the
> series for other nits like that to address.
Ack, thanks!
--
Cheers, Lorenzo
next prev parent reply other threads:[~2026-11-20 19:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 21:01 [PATCH v5 0/8] mm/gup: walk and batch whole PTE tables in slow GUP Rik van Riel
2026-11-16 21:01 ` [PATCH v5 1/8] mm/gup: break out gup_fill_pages() helper Rik van Riel
2026-11-16 21:01 ` [PATCH v5 2/8] mm/gup: break out gup_flush_pages() helper Rik van Riel
2026-11-16 21:01 ` [PATCH v5 3/8] mm/gup: convert follow_page_mask() to return a long Rik van Riel
2026-11-16 21:01 ` [PATCH v5 4/8] mm/gup: split out folio grab-and-store helper Rik van Riel
2026-11-16 21:01 ` [PATCH v5 5/8] mm/gup: break out gup_lookup_pte() helper Rik van Riel
2026-11-17 13:48 ` Lorenzo Stoakes (ARM)
2026-11-20 3:04 ` Rik van Riel
2026-11-20 17:33 ` Lorenzo Stoakes (ARM)
2026-11-20 18:10 ` Rik van Riel
2026-11-20 19:01 ` Lorenzo Stoakes (ARM) [this message]
2026-11-16 21:01 ` [PATCH v5 6/8] mm/gup: return a huge page's full count from follow_page_mask() Rik van Riel
2026-11-16 21:01 ` [PATCH v5 7/8] mm/gup: walk multiple PTEs per follow_page_pte() call Rik van Riel
2026-11-16 21:01 ` [PATCH v5 8/8] mm/gup: batch contiguous same-folio PTEs into one refcount grab Rik van Riel
2026-11-17 13:30 ` [PATCH v5 0/8] mm/gup: walk and batch whole PTE tables in slow GUP Lorenzo Stoakes (ARM)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=awCZDX2IG2VKgSKx@gremlin \
--to=ljs@kernel.org \
--cc=aa9736195201@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=hch@infradead.org \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=riel@surriel.com \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®