From: Benjamin Marzinski <bmarzins@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Hannes Reinecke <hare@suse.de>,
Keith Busch <kbusch@kernel.org>,
"Martin K . Petersen" <mkp@kernel.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: stack max_user_discard_sectors
Date: Fri, 20 Nov 2026 14:43:59 -0500 [thread overview]
Message-ID: <awCi_9_Xykc_Mmk-@redhat.com> (raw)
In-Reply-To: <20261120154040.GB28611@lst.de>
On Fri, Nov 20, 2026 at 04:40:40PM +0100, Christoph Hellwig wrote:
> On Mon, Nov 09, 2026 at 02:39:27PM -0500, Benjamin Marzinski wrote:
> > t->max_discard_sectors = min_not_zero(t->max_discard_sectors,
> > b->max_discard_sectors);
> > + t->max_user_discard_sectors = min_not_zero(t->max_user_discard_sectors,
> > + b->max_user_discard_sectors);
>
> I don't think we should take the underlying max_user_discard_sectors
> into account here, just max_discard_sectors.
Is that to handle devices that call blk_queue_disable_discard()? I
didn't think about that. Makes sense.
> But otherwise yes, this
> should be stacked.
>
> Please avoid the overly long lines, though.
Sure.
-Ben
prev parent reply other threads:[~2026-11-20 19:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 19:39 Benjamin Marzinski
2026-11-20 15:40 ` Christoph Hellwig
2026-11-20 19:43 ` Benjamin Marzinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=awCi_9_Xykc_Mmk-@redhat.com \
--to=bmarzins@redhat.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkp@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®