From: Lukas Wunner <lukas@wunner.de>
To: Hongtao Zhang <zhanghongtao35@huawei.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
bhelgaas@google.com, ilpo.jarvinen@linux.intel.com,
mani@kernel.org, sathyanarayanan.kuppuswamy@linux.intel.com,
liuyongqiang13@huawei.com
Subject: Re: [PATCH v1] PCI: Make PCIe link wait timeout configurable via pcie_link_timeout=
Date: Sat, 21 Nov 2026 22:51:44 +0100 [thread overview]
Message-ID: <awIScN3rXFv6v9x2@wunner.de> (raw)
In-Reply-To: <20261121110806.1158344-1-zhanghongtao35@huawei.com>
On Sat, Nov 21, 2026 at 07:08:06PM +0800, Hongtao Zhang wrote:
> PCIE_LINK_RETRAIN_TIMEOUT_MS fixes the timeout for waiting on PCIe
> link training and link state transitions at 1000 ms, matching the
> PCIe spec's minimum recommendation for declaring a non-responsive
> device broken.
>
> As hardware evolves, some combinations of newer devices and newer
> boards may need more than 1 sec to bring the link up.
The code adheres to the spec. If certain hardware doesn't adhere
to the spec, that is generally handled by adding a quirk that sets
a higher timeout for the specific device. If we'd provide a way
for a blanket increase of the timeout, it would disincentivize
reporting broken devices and submitting patches with quirks for them.
Thanks,
Lukas
prev parent reply other threads:[~2026-11-21 21:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-21 11:08 Hongtao Zhang
2026-11-21 21:51 ` Lukas Wunner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=awIScN3rXFv6v9x2@wunner.de \
--to=lukas@wunner.de \
--cc=bhelgaas@google.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liuyongqiang13@huawei.com \
--cc=mani@kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=zhanghongtao35@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®