mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Josh Poimboeuf <jpoimboe@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, leitao@debian.org,
	 keescook@chromium.org, hpa@zytor.com,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH 2/6] objtool: Add instrumentation_weak()
Date: Sat, 21 Nov 2026 19:40:04 -0800	[thread overview]
Message-ID: <awJjRvCwceyMA8Nw@jpoimboe> (raw)
In-Reply-To: <20261102114000.552033727@infradead.org>

On Mon, Nov 02, 2026 at 12:25:51PM +0100, Peter Zijlstra wrote:
> The strict pairing of instrumentation_begin()/instrumentation_end() gets in the
> way of tail-call optimizations, since it requires writing code like:
> 
>   int bar(void);
> 
>   noinstr int foo(void)
>   {
>     int ret;
>     instrumentation_begin();
>     ret = bar();
>     instrumentation_end();
>     return ret;
>   }
> 
> Introduce instrumentation_weak(), which is like instrumentation_begin() but
> does not nest and does not pair. This way one can write:
> 
>   noinstr int foo(void)
>   {
>     instrumentation_weak();
>     return bar();
>   }
> 
> And get tail-calls without objtool getting upset.

I find the "weak" naming to be rather... weak.

instrumentation_begin_unpaired() ?

instrumentation_enable() ?


-- 
Josh

  reply	other threads:[~2026-11-22  3:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-02 11:25 [PATCH 0/6] x86: Harden syscall dispatch Peter Zijlstra
2026-11-02 11:25 ` [PATCH 1/6] x86_64/entry: Unconditionally use -fno-jump-table Peter Zijlstra
2026-11-02 14:28   ` Breno Leitao
2026-11-22  3:36   ` Josh Poimboeuf
2026-11-02 11:25 ` [PATCH 2/6] objtool: Add instrumentation_weak() Peter Zijlstra
2026-11-22  3:40   ` Josh Poimboeuf [this message]
2026-11-02 11:25 ` [PATCH 3/6] x86_64/entry: Make syscall dispatch noinstr Peter Zijlstra
2026-11-02 11:25 ` [PATCH 4/6] x86_64/entry: Mark all syscalls __noendbr Peter Zijlstra
2026-11-02 17:06   ` David Laight
2026-11-03  8:51     ` Peter Zijlstra
2026-11-03 21:54       ` David Laight
2026-11-22  3:35   ` Josh Poimboeuf
2026-11-02 11:25 ` [PATCH 5/6] objtool: Allow EXPORT_SYMBOL() of __noendbr functions Peter Zijlstra
2026-11-02 11:25 ` [PATCH 6/6] x86_64/entry: Mark C noinstr __noendbr Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=awJjRvCwceyMA8Nw@jpoimboe \
    --to=jpoimboe@kernel.org \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=leitao@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=peterz@infradead.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®