From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netdev-bot+sashiko@kernel.org
Cc: florian.fainelli@broadcom.com, netdev@vger.kernel.org,
fw@strlen.de, phil@nwl.cc, davem@davemloft.net,
edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, shuah@kernel.org, toshiaki.makita1@gmail.com,
linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net 1/4] netfilter: flowtable: do not queue offload work after DESTROY
Date: Sun, 22 Nov 2026 23:16:03 +0100 [thread overview]
Message-ID: <awNpo-FYuOlgfP5a@chamomile> (raw)
In-Reply-To: <179538224441.3135.6950839726802616846@kernel.org>
On Sun, Nov 22, 2026 at 09:17:24PM +0000, netdev-bot+sashiko@kernel.org wrote:
> The creating CPU then carries on:
>
> CPU1 (creator) CPU2 (GC)
> flow_offload_add()
> rhashtable_insert_fast(REPLY)
> rhashtable_insert_fast(ORIGINAL)
> nf_flow_offload_gc_step()
> teardown, NF_FLOW_HW clear
> flow_offload_del()
> flow_offload_free()
> call_rcu()
> nf_flow_offload_add()
> set_bit(NF_FLOW_HW)
> nf_flow_offload_refresh()
> nf_flow_offload_work_alloc()
> test_and_set_bit(NF_FLOW_PENDING) succeeds
> NF_FLOW_HW_DYING clear, new check passes
> queue FLOW_CLS_REPLACE
Yes, PENDING needs to be held from flow_offload_add() path for this.
next prev parent reply other threads:[~2026-11-22 22:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 20:12 [PATCH net 0/4] netfilter: flowtable: Preliminary fixes Florian Fainelli
2026-11-18 20:12 ` [PATCH net 1/4] netfilter: flowtable: do not queue offload work after DESTROY Florian Fainelli
2026-11-21 23:23 ` Pablo Neira Ayuso
2026-11-22 21:17 ` netdev-bot+sashiko
2026-11-22 22:16 ` Pablo Neira Ayuso [this message]
2026-11-18 20:12 ` [PATCH net 2/4] netfilter: flowtable: restore the GRE conntrack timeout on teardown Florian Fainelli
2026-11-21 23:10 ` Pablo Neira Ayuso
2026-11-22 21:17 ` netdev-bot+sashiko
2026-11-18 20:12 ` [PATCH net 3/4] selftests: netfilter: check hardware offload work after DESTROY Florian Fainelli
2026-11-22 21:17 ` netdev-bot+sashiko
2026-11-18 20:12 ` [PATCH net 4/4] selftests: netfilter: check the GRE timeout after flowtable teardown Florian Fainelli
2026-11-22 21:17 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=awNpo-FYuOlgfP5a@chamomile \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=phil@nwl.cc \
--cc=shuah@kernel.org \
--cc=toshiaki.makita1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®