From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 178D8EB64D7 for ; Wed, 21 Jun 2023 12:31:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231948AbjFUMbI (ORCPT ); Wed, 21 Jun 2023 08:31:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230098AbjFUMbG (ORCPT ); Wed, 21 Jun 2023 08:31:06 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D241ADD for ; Wed, 21 Jun 2023 05:31:00 -0700 (PDT) Received: from kwepemm600007.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4QmN846FJ3zqVVZ; Wed, 21 Jun 2023 20:28:20 +0800 (CST) Received: from [10.174.185.210] (10.174.185.210) by kwepemm600007.china.huawei.com (7.193.23.208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 21 Jun 2023 20:30:57 +0800 Subject: Re: [PATCH] irqchipi/gic-v4: Ensure accessing the correct RD when and writing INVLPIR To: Marc Zyngier CC: Thomas Gleixner , Zenghui Yu , "open list:IRQCHIP DRIVERS" , , , References: <20230412041510.497-1-jiangkunkun@huawei.com> <86y1mxl9m4.wl-maz@kernel.org> <86bkikmvjk.wl-maz@kernel.org> <87zg4ypmlq.wl-maz@kernel.org> From: Kunkun Jiang Message-ID: Date: Wed, 21 Jun 2023 20:30:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <87zg4ypmlq.wl-maz@kernel.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.174.185.210] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemm600007.china.huawei.com (7.193.23.208) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mrac, On 2023/6/17 15:35, Marc Zyngier wrote: > On Tue, 16 May 2023 13:01:59 +0100, > Kunkun Jiang wrote: >> Hi Marc, >> >> On 2023/5/16 18:15, Marc Zyngier wrote: >>> On Thu, 13 Apr 2023 04:57:17 +0100, >>> Kunkun Jiang wrote: >>>>> Wouldn't it be nice if irq_to_cpuid() could work out whether it is >>>>> dealing with a LPI or a VLPI like it does today, but also directly >>>>> with a VPE? We could then use the same code as derect_lpi_inv(). I >>>>> came up with this the hack below, which is totally untested as I don't >>>>> have access to GICv4.1 HW. >>>>> >>>>> Could you give it a spin? >>>> Nice, I will test it as soon as possible. >>> Did you ever managed to test this? >> Sorry,I've only been coordinating the GICv4.1 environment in the last >> few days. I have tested it with GICv4 many times, and it doesn't recur. >> However, another call trace occurs with GICv4.1 when the device driver >> is loaded in Guest. I haven't found out why. Maybe you can help analyze it. > I also went back to my patch, and it is a bit bogus (it doesn't even > compile to start with). I've now posted new version[1] that should at > least fix the bug you initially reported. > > Can you please test it and reply to it? I haven't coordinated the environment well these days. I'll test it out after Dragon Boat Festival. Thanks, Kunkun Jiang > Thanks, > > M. > > [1] https://lore.kernel.org/r/20230617073242.3199746-1-maz@kernel.org >