From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012010.outbound.protection.outlook.com [52.101.43.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3BB71624D5 for ; Fri, 3 Apr 2026 04:02:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.10 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775188954; cv=fail; b=QL6AM6XnN/Ktvjp/382vS2egV7gRQcXk/YdOadXs3Cw75WLdIpWb/CZmomUbXhyUrCt7VQQu7cxHO20zFwqJuApEyLlvkVhN/IgB+Rt0CNwfShgXCHFP+hzFjjtPX4M4Bmohf9tf7YrInaIYnNcg6JMFbVqmsSwhf5rWk+HSvXM= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775188954; c=relaxed/simple; bh=akvKA0FuRvcAHeTFaE33/FB+eWn2sr52D2624WKDO4I=; h=Message-ID:Date:MIME-Version:Subject:From:To:CC:References: In-Reply-To:Content-Type; b=AftG7NnJz0Wr5tSlb0yR4y+w2QQt93mBXpESM5d8OAmN8778TkzyrQT7zbYODsbjRuyhXhrthEQ6uCAeLr1Y+mX30e04XNicjO6hgaxrl55IS3naOsoeTlDgv34EpiSkOLYqU9SH/UrzndeqdcWMuaATOTbwxDoyMyu0ujsC6g0= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=gcFKjIku; arc=fail smtp.client-ip=52.101.43.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="gcFKjIku" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mFGlKMsw0kRUwiR/W2hWqOMQIswszndf8K/z1oRB6ehRhDb80kYd/Dc524e6gzFoQvKe5X+Pouik8v3lsPdDoKAK9aIw5yNE6lHc3wJkRWPkuNi5nMDYuhpomuydwdCg4mte7sI6H18TLWytYMXC2tTzDXN5d/EediTDQ1sy0U59rPeiglMjoCG1UIwlAf1BTXjhU1SM2+iYrIbj0YdvAXcItgUfy3QeYQOhib2WvpfiZgg9zItNOO/D+jmApm5xaJiRIjC4aCaQ3FDJ3e5mXzcvepnI52rygfrMnRdTG/omeYPtibP+HR9ddIPqpf4hSaUfYmzzH3ISouAEaDfxbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=44+YE+D2KCBuESZiBJ7SiS8Nz73WhZy5183ByH5QJFA=; b=yFMQYmqOGqR3OdB9VmKzo8wvzj+Kw87RY/NtajcjPsElEMuij4GLpBZPssFZr5/d+9e/Mtng+CVsuONtqRY7pVPNghVhOIE3cxriVf6h+nBg8RLB2rZS5C/a5gXSe/amsGgfVcb3cqcgjRKSitDcYhk9qCuxevtq5prTzqWrsF5iw3kGtwWHvknmFJQp+buMxakcZad4rdmL4TTzHzDarB9AuXCo5h5QNpcGeGRFs2U5b1G+XWK4ADB+cjxwqG0kRhd8IpNbwmtmLBeAz+fyy6uQlC4FizV5OHgSEmUKzz/JKxO+YT0ik2zjPG3rwTJaa2aG73cAjzDRmsgFFPKgng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=infradead.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=44+YE+D2KCBuESZiBJ7SiS8Nz73WhZy5183ByH5QJFA=; b=gcFKjIkuJhwWAZt0TShF11bPqx2QqdmjtxojFE0WyM6V21xO1uaXsz06HgRP/5/rVqLs6pn0d4G/4xCY5FWktPNYime7O3+N4UiG9YCQHywma0zBUcvfiw5i5cJ8Lv77EJOLMfVD+ZVBu6Am527LjlP4sk67s0Ms+EKlEh7ftuA= Received: from BY1P220CA0008.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:59d::16) by DS2PR12MB9565.namprd12.prod.outlook.com (2603:10b6:8:279::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.19; Fri, 3 Apr 2026 04:02:27 +0000 Received: from SJ1PEPF0000231B.namprd03.prod.outlook.com (2603:10b6:a03:59d:cafe::a8) by BY1P220CA0008.outlook.office365.com (2603:10b6:a03:59d::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9769.18 via Frontend Transport; Fri, 3 Apr 2026 04:02:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by SJ1PEPF0000231B.mail.protection.outlook.com (10.167.242.232) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.17 via Frontend Transport; Fri, 3 Apr 2026 04:02:26 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.17; Thu, 2 Apr 2026 23:02:26 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 2 Apr 2026 23:02:26 -0500 Received: from [10.136.42.52] (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Thu, 2 Apr 2026 23:02:23 -0500 Message-ID: Date: Fri, 3 Apr 2026 09:32:22 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/7] sched/fair: Increase weight bits for avg_vruntime From: K Prateek Nayak To: Peter Zijlstra CC: Vincent Guittot , , , , , , , , , , , , References: <20260219075840.162631716@infradead.org> <20260219080624.942813440@infradead.org> <20260223115100.GI2995752@noisy.programming.kicks-ass.net> <0d3680c3-3e17-47b8-8fdb-0cc1f97ffce0@amd.com> <99fa12f9-71d3-4766-8742-a3adc9ce4271@amd.com> <20260402102215.GT3738010@noisy.programming.kicks-ass.net> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Received-SPF: None (SATLEXMB04.amd.com: kprateek.nayak@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF0000231B:EE_|DS2PR12MB9565:EE_ X-MS-Office365-Filtering-Correlation-Id: 7a013afe-fdf3-4620-96f7-08de9135d1af X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|36860700016|7416014|376014|18002099003|56012099003|22082099003; X-Microsoft-Antispam-Message-Info: 02B3YuuTI8k9xUZh39UPhKQkZlb4oTwfe6oA+hum2VBZFNNMPF9ZmUZ/A3mDO4k53kKBwODSHdHJWkVftbYtbt/BE2U3WeqHYFlc+FQfUKzrZCjRg4AILehkQ7AK6aqHhzMOTkBjgfO+8LN2DKmornPBOaXkR9QfxyagCelVCCFhgGZVDu7NuEO7X5hSmPk2zEV0gSegV0Hr5IhA9l0cW7JL3LSXX0LbbdmDQx/kf9yrYHgApbwlaZuFSlic9NHUycTESK3gPmRz5W2/4CW8DyHvdjdeORbaemKMmDxqCEuiI8dd9Yk1wjs/pldA4D1JQWv8FJQBp5QQ3uPp94EJofM9WABl0dR77XPP3OgjKi5kOiRvHul+x80iC2273yWmv1IjENO4C/OwdI7x5h/xqAd0siTr3+LRjo/Dj9FznjCzBk7VJEz8CrMnn+wuj8a0DquFFh4iTYs9FOVeDYb3nMl6lL7ChxHFvTBqL5N9nEW40SdFkX5krTmdCxJpHAogwaqz2540nyaMVcvxvmjzt+l/9QhrLxiX5ofZdDDE8hxBFpbgkRvYohKtLuKvJyQCB2a5T6SkxSti5vYZi/CNMI5lVvLyHbSdJZyRn7mgTkNkmfkbkLpGnZ8Bt+K44iFv3ozJgAL1yrW3LLhwz35Vduyfa+XxACejKjNagGHD7gpRdp7T4NVnYHzjEWLWFA+2SReqCuJDR7Lcu5v58Y9aIafBqxw0vxqhhHKTetfXLK51dyRgl6hDjFsYawV0Qm+RIHIqeboCuX7zyREbzw+2Ow== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(36860700016)(7416014)(376014)(18002099003)(56012099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 12hrrHvDLS2LoMeUv84yt9TeuNFTqqHsGNmU8hz2JQiAwFJqk/lY0ayhhAoczRMGa0/4CC4PBxkZGApHO8jAg5eobXyxfd1lm60YbA0zA8zSDuKAgRw0UTrAPkzhUlhCPJR4RB9P2UUKPHtAZZggwtsPG8LdwpiJeyt9PzwSFyH8TmEX4L8/cY4b53CeBuUQnSpQohvJhj2ow5TBIxVcbkJLNFEhzAlBrBAkqTQM9gkuN4RfRr+zEmjaZTnOhb2NaiDQxZ7ZxhLpD3CDfHOh+WZdmUOzweaoNBhuvhs5wGmSZMxfrWJ9I0BzcwXbvkXl8bmFCVLtO2YedvHtudgVmLIv8SKXJK0rUF0bYVylnD6NNakRX7tCi2+ixCLFAoAVEF7yypY5zplp23+p9JVm+ddKEtlyws5GPEwJ4iRF9BkrJaqIGoovO54zgZ/9pPJj X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2026 04:02:26.9736 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7a013afe-fdf3-4620-96f7-08de9135d1af X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF0000231B.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS2PR12MB9565 On 4/2/2026 4:26 PM, K Prateek Nayak wrote: >> That is, something like the below... But with a comment ofc :-) >> >> Does that make sense? > > Let me go queue an overnight test to see if I trip that warning or > not. Didn't trip any warning and the machine is still up and running after 15 Hours so feel free to include: Tested-by: K Prateek Nayak Perhaps the comment can read something like: /* * A heavy entity can pull the avg_vruntime close to its * vruntime post enqueue but the zero_vruntime point is * only updated at the next update_deadline() / enqueue * / dequeue. * * Until then, the sum_w_vruntime grow quadratically, * proportional to the entity's weight (w_i) as: * * sum_w_vruntime -= (lag_i * (W + w_i) / W) * w_i * * If w_i > W, it is beneficial to pull the * zero_vruntime towards the entity's vruntime (V_i) * since the sum_w_vruntime would only grow by * (lag_i * W) which consumes lesser bits than leaving * the zero_vruntime at the pre-enqueue avg_vruntime. */ if (weight > load) update_zero = true; Feel free to reword as you see fit :-) -- Thanks and Regards, Prateek