From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755664AbcHYOmf (ORCPT ); Thu, 25 Aug 2016 10:42:35 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:56861 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754854AbcHYOm2 (ORCPT ); Thu, 25 Aug 2016 10:42:28 -0400 Subject: Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open To: , Jiri Kosina , Greg Kroah-Hartman References: <20160818135932.219369981@linuxfoundation.org> <20160818135938.484441980@linuxfoundation.org> <0df64efc-85fe-1de7-f15f-233f1e5fdad8@compro.net> <20160824201701.GB2133@kroah.com> <6b0f11af-84a4-ef0c-0033-7a10de189813@compro.net> CC: , , Wim Osterholt From: Jens Axboe Message-ID: Date: Thu, 25 Aug 2016 08:41:26 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <6b0f11af-84a4-ef0c-0033-7a10de189813@compro.net> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: BLUPR17CA0073.namprd17.prod.outlook.com (10.162.85.169) To BN6PR15MB1187.namprd15.prod.outlook.com (10.172.205.141) X-MS-Office365-Filtering-Correlation-Id: ba55ead5-86c2-4dc1-77bb-08d3ccf5e64c X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1187;2:MgNKlaxu7gg76ayXvLK/Vuv4L7+WbHdFJJfn6+v/2BVPBdVHz3tNA2lzO2xa1LBNDBxU5ZBr5hsSnO4GYxm5K/8i4CxaxkQ5PU/xM0dUuuxa66wAHY0cOzOUz5vJraJgLkjBMQj5EG5+D5u7iuFgcfGYGJZYd9dQJsL55pajW43zslW7ymGsRf2phYjHcwOD;3:9mT9JjiOHC9u+43/03uKeIu8zNxyDbMlSeCoGAfXW5ka/sCZuf7qS6LTV0+fXcssV7ZuZocy0xhPzc3/qHgpKgWa5jcxC8T/2iyKPRUCkGRTkKHgwW6RJbf4MHocXMqb X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1187; X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1187;25:hrHbWrEgnyF7q6Cup17o6ca2XeVzfrQJe+RfHSJx8GLgpw7b2ZtZWJxr0e7GYtmzpT34laJiCk+9e5zFhdZdfr/iaex0aSVy9NmtRKVSpAt++vGbirrHloZLjRTgth8OHHweq19o0eLz9vQoJ5vK0MHpw6GZ1jFy1oPu4ngX4x/qRdrnCfJ9K9gqOrkxrpfi3jUjDt3GL8zVThHuHcyN2I5/DdvMB76r1/+VFqkaZKT5oJc4JE0gshsEGJzH9+08jo2AyhuKg8pHwTZyUuijZiQnWnm5rKb6KMjoQOKDnMwG43v4DA6jRa76VzpxuqD7NRi1XYhCIB2z7ncafFxICI51cyfQUTGef/jDi3i606U63Xin8EjEADoCYz9RjvdYAGlho26r8xpljjpHa+Hf+lREGRTAQbEIXFL2OCGxQk98kSgH6Pcs7Uv4rKJ4fTzmmSjB55QPox0bbOO8gD5kHvI0W0OzwhmnzQp2L47UF2TP2lfjUvk+sCdkK8mLyfhJnhGjDww9P7YGKgg/riengjnpZoFTljArNciSueSi48Kuwno2VzmjlSex2kvh6kAWnJOt19ZaNpzCHOBoa8tZRxtkZnUUbHOlhUKa29aa5jcwgN4Bs1TxMfyTnal+ilcqZ0s8GXNZaeTFReauOIclfS+7t7k5iW7v5wQcYTe19u8n/cDcNq3b/MNXOibyQACA;31:8n9/pINJWX8FlSB/fxccHo8UQycOghWIHejcPHdVAdChuPkMQvEc/RQSbc8QRLvu//31Ju0lrO6G2DnkC0w0Uul8fMo0WaPCD58Z4vwkyOdLqk1BabQFAP5XxisJOgD1H9xgriB+RjON9SkF1XrVxRkjRW8H0Eu+P2E27mrNs8OVQ/s6osRXaEtjrtHH2G6eFYG9eYP1IApTpQQkKcyhqfJapoe/uUAKoC3Ml2mP558= X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1187;20:8AxolvXCE3dcR52qKGeSeuQ94bXl8gBrVo4kYVlP8Qe/hoZhcsbuZ4mLFVrLJ6SW8juACTpytM+LLELoWn0BHC/ohU1iuTleWokNIgRtinM5tRCQuD5uoskeb7hnuvw1ksQFySGD3eZptujjADiPpaPVgwvuCJzYLcWaSQzSA54=;4:RqXNk7CRRPSYr/XrDxdLnFH/z8DH+ZGNmSxAqReSmByLXnI1s88woV3MWaD1L1hE+VI0djy7JNUTIBUTkw4LTf3+Ypf6WPXJdnra38h8NSegJpDLI7SJokXqc7SV8/MjBk0Fxl+MKRSCrPt9rElBfRZvVTs3CDSfQv9lqHG3eDX12UkmqLKCGFYk+nxgAAFHa3NZuiMxdS4VfaN68ffiicO3LC5Ss7VRnFUQNbqPKUwrFZVvW+ZILZMjZkKtJl6lKxUKBu150N4OiznUdQJ2oA3kfqygg3Nu0T9MAd685Too1sZs6TTCaWFlE3+rIUx1x7GIic1qCwVS+De7P+EV72gmDfVRO/Nk3mxPBkfLLIpF0ZgtXQnyO6X+Be6Ek4alTl8UgBZZD9jAPC9H/RdmIg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:BN6PR15MB1187;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1187; X-Forefront-PRVS: 0045236D47 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(189002)(24454002)(377454003)(199003)(81156014)(93886004)(117156001)(305945005)(7846002)(101416001)(586003)(3846002)(106356001)(6116002)(23746002)(189998001)(81166006)(2950100001)(97736004)(2906002)(8676002)(5660300001)(7736002)(77096005)(92566002)(68736007)(83506001)(50986999)(5001770100001)(4001350100001)(65956001)(66066001)(33646002)(65806001)(64126003)(230700001)(42186005)(47776003)(4326007)(31696002)(50466002)(86362001)(54356999)(36756003)(76176999)(31686004)(105586002)(65826006);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR15MB1187;H:[192.168.1.153];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN6PR15MB1187;23:4rZhjpS1/Nv7uty8ePm0zFHu4rvGDf4zPQmfQ?= =?Windows-1252?Q?ct/3j0pckEZn5OsWntq1MwJkTz9/iEgIxBSucwNHabJpF+wtT4eNNw5B?= =?Windows-1252?Q?KT+KgMqTHg8BC3gn8N/RqjziDhRirbjrLtgvdRAmQj6A/2CrSZMqYMIu?= =?Windows-1252?Q?AiywZ0Or+qxn361BWmj6UmxpLSdUGpgRAEF9xw9r7zNrQkgDYz8keFEt?= =?Windows-1252?Q?Ln7xpD20FL4Yl6eyt54JuY627XoQxSlVehukUEtEU1tcEYxQZqfWGqys?= =?Windows-1252?Q?0nuJa0cJxOqjpSQgiso4XqAy9tnbh0fLuNEPZX3xzsQrxzsNXzwgnZm/?= =?Windows-1252?Q?uLQMTMO9UlyW6/LCoGgHYVVIdQ4ntjsrrim1lmZasKl3sd9TzOr52QVU?= =?Windows-1252?Q?y+Ho14BamEz+ff43I9rXW0RF45CzBUxk4KD24IIIdX4ZnqNv1JjweIrG?= =?Windows-1252?Q?vaCTen7+1dlWdrj/UmokIPCGAlwvHGjQwWBkVtGH03IcIht5ON5/D7ZX?= =?Windows-1252?Q?HGcLoj9iX5E5lOSH+bmarz1w2ZDdCmQJo7H2ZtEF1Sy1aQmtoB8xdXXW?= =?Windows-1252?Q?I4UV+sukHo+sf/HRUh0VijozXxjfM2luLbrcLP3H3454ohWInvra0qoU?= =?Windows-1252?Q?63hEBf8ItcT1W6uZ6vUwK4C8FaJYTwRd2n0NEGrcfoyqTZOHwhFu6hSb?= =?Windows-1252?Q?Tnzf7VzNE+z+z/cLsdkxN/sn5pH8dOy5FA908d2r2pfSYoO0xbsAcdBz?= =?Windows-1252?Q?7HqcdFi2bHQQj0Nksk0gYtKMzG4Qt1/YKVtHPYMacaHaA7pcYJ7J07Sg?= =?Windows-1252?Q?bqiyKkAkZRq7ASplnIr0eqYW44Ze1muoSt/hBCqZWH12B8nZRDL0fPvQ?= =?Windows-1252?Q?9UrNpn8qAB+ScO+sQ0VGUtqdyBeUZWp1oVy31iYyRR+DnhkCcfEWragy?= =?Windows-1252?Q?yx5/2kNxskzBP+mpfs5CRrEG7Ww/eQkYnkAEQ/ndpHTuPAmfAr7WV89O?= =?Windows-1252?Q?1EXTHlWOqAVjsRcJ7q+Bz7Dz43TKSrTIsszzTIDGQEAtVKQ5yU472rsH?= =?Windows-1252?Q?OhXlV5L9TWKkZVd7LHYsv/E5tV9kBmr8ZUIucQPX+V6LZmVcHCbsus1l?= =?Windows-1252?Q?58RXqA+C42abtLbKza0LClCh0LVpg92lnci0M9Da4TJd4kZV1GoEY/hS?= =?Windows-1252?Q?ws+wDTVgrY4wGPUjfaDve2p9S8AuaYCErjQkrHazDbrRMPwGS5lAfCuI?= =?Windows-1252?Q?dzcQ+xxA/WHXU7sW5psRtfSRN/RJ3O+KlOIKQN4feGZC24Hzv+WKkmIO?= =?Windows-1252?Q?i+0noxE91iKv17hnppadhUEQuI3UYslrtLSYfF1UgyfjpVdKCnT32lj3?= =?Windows-1252?Q?8+2RgWAJGFR47YoCO6EvJj9+A3IKa8CEg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1187;6:SlZ0fP1xdCserEbDsDlHryNc2NNWG3XBOxHdMuGx74IKBZQDl/7b4rIGwYLgiaXvD0jHK4uC1A0BmcwlONW8CzVyB2il8ZYa34P0kIe0V3biif7bgjxUmJNhNSEzUWq8smMhzARFBhkE4Dz6YVB2VkhpH+hOvAykILbCzAgkqRfSeufzqdyT1Y49vtr+1IXLt0zmy5kAAHFC+hwgtjysTpurMVda3PO7jrfUvlJ4zPFZYcPjpH+WUJfFGxG0QTeeAQ/ipz1ivjIvcnQJpLiySdddU2RQTq8+6RgY/6VNpik=;5:37f9rtg3MXYxJSi6eg36XJnW7SdOoGC3xhRaLSppDwtjq6zzLO7NSskhGIPk0WPNO1BwAtYSDTZq6S6Bklz03xbQBN+J2/dXKIY/6qc+fjDOCdx0szATgFz/H1bzwhx6NYSTBJkkUhGFZ+IwS5en6w==;24:S96XkKFgyip/oRvWGiVDfuYXub4RZNWXpV8PEEutliYN4jX0M1/UM0nbSntaIU8KG6uw3AfUUWKhotwzc+cjb4irW4wtJNXb+9q/GB3te1U=;7:TTj3fHaGmkT7+e1ePd7psz2jywH0gL7sfiWwPMUdREgiQatk9y/7QeOw6bD1hY4i3qdL7Z/zOW0bKIpitZl7taAiC+glc5+Nf8w8tgpjL5oqFkh4rA8+BadEZGJH75slXuNWxT98vSxm/mLT0ktRJmrKaCGHnukZl2HUhFqM7lc9Hs6KkGjxPZMhIE2OdVDaiVqGl83h9riAwKZ7vjs2NPXBqdRO0jhXLCIh3Qxf/7akBdMl7wxOK0FMAztl3umQ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1187;20:QeQGdSHkgZ2zzwHebRZueJLcrJZ1/gIU9Upx5UD0vVFY2au15QbagXsb5gRhQM3fhNT9Du7U8Gz7oKlTPmV4TlW/GLSpe4HeVZ3MwCFxelu27DQ9XK7T/vX+1XnxaFv0uEc7eNcQkujwXE0Keq8TQdk06EnFtz6ojC7dx3uYxko= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Aug 2016 14:41:28.6472 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1187 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-25_08:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/25/2016 07:08 AM, Mark Hounschell wrote: > On 08/24/2016 05:11 PM, Jiri Kosina wrote: >> On Wed, 24 Aug 2016, Greg Kroah-Hartman wrote: >> >>>> I have a problem with this patch. It only fixes one of the regressions >>>> caused by the original change to the floppy driver. It does not >>>> address the >>>> user land breakage of removing the NODELAY flag checks. >>> >>> Does the same problem also happen in Linus's tree? If not, any hints on >>> the patch that might have fixed it there? >> > > Yes, it does. IMHO the entire patch (between 4.4 and 4.5 that broke user > land multiple ways) should be reverted and a fix for what ever obscure > BUG was supposed to be fixed should be "retried". > >> That's still an unresolved issue, and it's on my list to things to look >> into. >> >> This particular patch though fixes a different issue, and should be >> applied to -stable. >> > > This patch fixes a bug that was introduced to fix "some other obscure > BUG" that has nothing to do whatever with the "physical floppy" device. > And it broke user land in at least 2 ways. All this patch does is revert > part of the original patch so that it is only broke in 1 way to user > land. It should revert the whole thing IMHO. Which patch is this? If that is truly the case, it should be reverted asap. -- Jens Axboe