From: Mark Brown <broonie@kernel.org>
To: "Torreno, Alexis Czezar" <AlexisCzezar.Torreno@analog.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] regulator: adp5055: Add driver for adp5055
Date: Fri, 4 Apr 2025 12:51:25 +0100 [thread overview]
Message-ID: <b01583e1-dc95-49ef-99fe-1eedbe48cadd@sirena.org.uk> (raw)
In-Reply-To: <PH0PR03MB63517B73D2E5F9B46FAA6D41F1A92@PH0PR03MB6351.namprd03.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 716 bytes --]
On Fri, Apr 04, 2025 at 02:33:27AM +0000, Torreno, Alexis Czezar wrote:
> > This is absolutely standard enable GPIO support, just let the core handle
> > everything. Otherwise this looks fine.
> May I ask which core function is the suggested to use here?
> I assume I need to change the line in ops:
> -> .is_enabled = adp5055_is_enabled,
> Not sure which function handles both GPIO and registers since as far as I
> understand 'regulator_is_enabled_regmap()' only handles software/registers and
> 'regulator_is_enabled()' only checks the gpio?
The core handles GPIOs separately to the enable function, this is a very
standard feature even things that actually need custom enable functions
can make use of it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2025-04-04 11:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 2:43 [PATCH v3 0/2] Add support for ADP5055 triple buck regulator Alexis Czezar Torreno
2025-04-03 2:43 ` [PATCH v3 1/2] regulator: dt-bindings: adi,adp5055-regulator: Add adp5055 support Alexis Czezar Torreno
2025-04-03 6:40 ` Krzysztof Kozlowski
2025-04-04 2:33 ` Torreno, Alexis Czezar
2025-04-03 2:43 ` [PATCH v3 2/2] regulator: adp5055: Add driver for adp5055 Alexis Czezar Torreno
2025-04-03 11:08 ` Mark Brown
2025-04-04 2:33 ` Torreno, Alexis Czezar
2025-04-04 11:51 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b01583e1-dc95-49ef-99fe-1eedbe48cadd@sirena.org.uk \
--to=broonie@kernel.org \
--cc=AlexisCzezar.Torreno@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®