From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B982335567 for ; Wed, 14 Jan 2026 12:07:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768392453; cv=none; b=XCB5wv9So1L133noW38qQ7q/OECLIWdGz9bB8wDVzEYokMAW6FX7adiKpVx/RV8pxX8H7GjdA4qJC+2kYbSbUb9c6FdbIucTkanOMZPjVEDiLyXj/5dC4aL/IE7c3KGFrnkaHXm3t9Ih5TVmfHFpX7o9kMuN4Mx+g7/S7/RUhEY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768392453; c=relaxed/simple; bh=g1MQKVst3vRRBpjP4tpMGE6XBbtC6OuH91l+ejamYwo=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=ul189wucMHRT8Ak5KstKIL7P07kjkm2R0vAs5opGuYzlL6glf6Tnel6HPLd52YLuDoSTnq/8bGZAcvdB+uR0c/GhtZBIdpwQmLK8RSWuGPvyvHJX6YOjjgwGxOhx1pCn6vYzm/vOiKuLHnEMBG+Hlp5SyvzJyRznCJ+TTydjzts= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=KB/yeEGl; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KB/yeEGl" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-47edffe5540so12598135e9.0 for ; Wed, 14 Jan 2026 04:07:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768392447; x=1768997247; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=4dooFeIUOZ2AYn0yuxNU1dgV5MLYuRIoZtKgKCQ/5bI=; b=KB/yeEGlzIeSgbfxCVOi+poSqKwc0ASdSFrlvBFjjire9y4zCP2YNR3CY891ytymWg jkOSH5rn4ocQ+hYSwdcYBO4B7cnbkd75v7jGbSSVVYGDJgKEbDcT7/w643frMZTWKmn0 L6Vvo7eUf1IUGNiX6M5Agqc+eu+aIcyVvSfbftSJJqq7ujayM6QVUwk6yWp4dLpwPbNA 47DXstlHtU4HHpXWVl+AxF/9brTF13g4kA+aPxeOjC3VQt4ZLzVBj7zfovBZG4tRVxuj Y2XNbtM2/3P1HXmGLxTUUrf46mhp9kLXLYq9gqFeP3o0gKFbuACVIeNGx/nAbtD3aY1e W9vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768392447; x=1768997247; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4dooFeIUOZ2AYn0yuxNU1dgV5MLYuRIoZtKgKCQ/5bI=; b=jg46U4ODuAzCQQzgSb2w3xyqte6hYO7V3OalJug3CTGKaPDyFyj8UhwUqCWObwJ4Q2 FhOdxTs1HYFpct4MIGRvnVTzMCq8xqH6UM3t7nWilLUxCHvI65rsqBimZ2flKLKoGgL0 ZOvI+plUsP4UPBeVWVuokqO2zvzaAfoN9PkirwY13pKWw6av+8HTKYUM97/Pr7dYBY4r H8UZA/riHtrxL0oVRwN4JCk4U1bZTfo5yc/rivRTHZZwsLjODAadLGF6uC5cI7yEuptm f2GP67LLvKh8Wh7CP1sY9n+4KTzy1qhfj5RJ9epaeeQEDXPPXL+e7ucPGNXmrlCdLsFn 5pfg== X-Forwarded-Encrypted: i=1; AJvYcCXcIqA7ZDEQrfmC0f7XyhQzy5/veSbQJxFyi2L8/h+8zNGHYsBOm5SZurZ8XCOIt1UsWrPuaTBF5Iqz8w4=@vger.kernel.org X-Gm-Message-State: AOJu0YwQEmJX8xxGEqBTaZAKoBJ/5PZs1waLtkT3N/vIpetrW8QKtaAy 49WdjRDKcPiZtQdLkWoTD3pPnOBZ14DHO5T7yit8u0GNeeoFOXJilDDXTFq9sjbmq5E= X-Gm-Gg: AY/fxX5K6I4vaeCtgRMRqeGPArIBE4Z3F2rA//dP+JK8OY7YgP+4bByRps7QOS7Oh63 oc5Cc9iEifOm/6PS+yxyAwLLT0BKPfAyrPdkQw3NP1HZC0hSVNWsdA3yoEzmZ9wf9h0O/lNBAUS zMD0c+ZNSghXw+cWOFxHaEU8kECwnP1Djz/m3B7HNOgnKn5PhiF/41VlDWsdFjoOyhKwsRYFBle RS9aEEuxccJya91kgKf+b62cUI103t+stm6AqD6d91K7Pd3KVqVC8aTShuS0N8lO5GiPJ+jtaIG 1S+iHDcU9rfJj1OOtyrb0ZFwoh7kX1EM7TmT+Rz/IkycRJfaqfJ9rGNfIHyk4piLRDfCSFP4zd6 HLVmlosp0xi16ckb9CRq0C5ER9OCfAEusI9o7mx1+jSdaVAUXlTAkiYUqQaTNwt0KwVkjA32rMQ MSxm/7HsFygEui2PXWerzFb+d44PZXQ7hP7De9LnOD1y8humX2OWK2/UpYbZlsqaE= X-Received: by 2002:a05:600c:5285:b0:47a:935f:61a0 with SMTP id 5b1f17b1804b1-47ee30709e8mr30476765e9.0.1768392446880; Wed, 14 Jan 2026 04:07:26 -0800 (PST) Received: from ?IPV6:2a01:e0a:3d9:2080:b357:7e03:65d5:1450? ([2a01:e0a:3d9:2080:b357:7e03:65d5:1450]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47ee281dde4sm19667005e9.4.2026.01.14.04.07.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jan 2026 04:07:26 -0800 (PST) Message-ID: Date: Wed, 14 Jan 2026 13:07:25 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: Neil Armstrong Subject: Re: [PATCH v2 1/2] dt-bindings: arm: amlogic: add Khadas VIM1S binding To: Nick Xie , Krzysztof Kozlowski Cc: khilman@baylibre.com, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, xianwei.zhao@amlogic.com, christianshewitt@gmail.com, krzk+dt@kernel.org, robh@kernel.org, conor+dt@kernel.org, nick@khadas.com References: <20260114062549.68954-1-nick@khadas.com> <20260114062549.68954-2-nick@khadas.com> <20260114-slick-passionate-mink-216a3a@quoll> <39bb1820-6e4d-4f50-87e0-93844d779f6c@kernel.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/14/26 12:25, Nick Xie wrote: > Krzysztof Kozlowski 于2026年1月14日周三 18:33写道： >> >> On 14/01/2026 11:07, Nick Xie wrote: >>> Krzysztof Kozlowski 于2026年1月14日周三 16:51写道： >>>> >>>> On Wed, Jan 14, 2026 at 02:25:48PM +0800, Nick Xie wrote: >>>>> Add devicetree binding for Khadas VIM1S board based on >>>>> Amlogic S4 S905Y4 SoC. >>>>> >>>>> Signed-off-by: Nick Xie >>>> >>>> You still have the same From/SoB mismatch. >>> >>> OK, I will fix it in next version. >>> >>>> >>>>> --- >>>>> Documentation/devicetree/bindings/arm/amlogic.yaml | 6 ++++++ >>>>> 1 file changed, 6 insertions(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml >>>>> index 08d9963fe9259..55663e0f7f915 100644 >>>>> --- a/Documentation/devicetree/bindings/arm/amlogic.yaml >>>>> +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml >>>>> @@ -247,6 +247,12 @@ properties: >>>>> - amlogic,aq222 >>>>> - const: amlogic,s4 >> >> Look here >> >>>>> >>>>> + - description: Boards with the Amlogic Meson S4 S905Y4 SoC >>>>> + items: >>>>> + - enum: >>>> >>>> Yopu already have exactly such enum with such description, so your >>>> compatible goes there. Look - it is called "Boards" - plural. >>> >>> The exist board aq222 is based on SoC S905X2, but the new board vim1s >>> is baed on S905Y4, >>> they are different SoC, so we need to put S905Y4 under S805X2 ? >> >> What is the point of having two separate lists with enums ending the >> same SoC compatible? > > Actually S805X2 and S905Y4 are different SoC. So maybe like this ? > > S805X2: > - description: Boards with the Amlogic Meson S4 S805X2 SoC > items: > - enum: > - amlogic,aq222 > - const: amlogic,s805x2 > - const: amlogic,s4 > > S905Y4: > - description: Boards with the Amlogic Meson S4 S905Y4 SoC > items: > - enum: > - khadas,vim1s > - const: amlogic,s905y4 > - const: amlogic,s4 It's ok for me, but you'll need to update the aq222 DT aswell. > > Same as Amlogic A311D & S922X > > S922X: > - const: amlogic,s922x > - const: amlogic,g12b > > A311D: > - const: amlogic,a311d > - const: amlogic,g12b > >> >>> >>>> >>>>> + - khadas,vim1s >>>>> + - const: amlogic,s4 >> >> And here. >> >>>> >>>> Best regards, >>>> Krzysztof >>>> >> >> >> Best regards, >> Krzysztof