From: Joe Perches <joe@perches.com>
To: korantwork@gmail.com, apw@canonical.com, dwaipayanray1@gmail.com,
lukas.bulwahn@gmail.com
Cc: alexs@kernel.org, linux-kernel@vger.kernel.org,
Xinghui Li <korantli@tencent.com>
Subject: Re: [PATCH] checkpatch: Add the backport commit format check
Date: Mon, 05 Dec 2022 04:39:18 -0800 [thread overview]
Message-ID: <b0194f880b217e905a9ce571e5b86b974beaef0b.camel@perches.com> (raw)
In-Reply-To: <20221205094826.44844-1-korantwork@gmail.com>
On Mon, 2022-12-05 at 17:48 +0800, korantwork@gmail.com wrote:
> From: Xinghui Li <korantli@tencent.com>
>
> The backport commit has been used to be misreported as Error
> by checkpatch.pl like this:
>
> 'ERROR: Please use git commit description style
> 'commit <12+ chars of sha1> ("<title line>")' - ie:......
> commit <sha1> upstream.
>
> total: 1 errors, 0 warnings, 8 lines checked
> '
> So, add the backport commit format check to avoid the above mistake.
nak.
I don't believe this should be an accepted style.
and
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> ERROR("GIT_COMMIT_ID",
> - "Please use git commit description style 'commit <12+ chars of sha1> (\"<title line>\")' - ie: '${init_char}ommit $id (\"$description\")'\n" . $herectx);
> + "Please use git commit description style 'commit <12+ chars of sha1> (\"<title line>\")' - ie: '${init_char}ommit $id (\"$description\")'\nor check the backport commit description format\n" . $herectx);
Output messages are only single line not multiple lines.
next prev parent reply other threads:[~2022-12-05 12:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 9:48 korantwork
2022-12-05 12:39 ` Joe Perches [this message]
2022-12-05 13:11 ` Xinghui Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0194f880b217e905a9ce571e5b86b974beaef0b.camel@perches.com \
--to=joe@perches.com \
--cc=alexs@kernel.org \
--cc=apw@canonical.com \
--cc=dwaipayanray1@gmail.com \
--cc=korantli@tencent.com \
--cc=korantwork@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®