From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-a5-smtp.messagingengine.com (fout-a5-smtp.messagingengine.com [103.168.172.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C24C233923 for ; Sun, 12 Jul 2026 21:06:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.148 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783890391; cv=none; b=KscWQzqTvr4hfb8rScF7o7AsXa+cySxw32LKi4Pa0BLsIETe0Q2Gwq4oz9M8+YwgniNzk/B2/zoB37j1PvjZpl9wh/ly0gmsQ6PY39tFWgmbaT7cfDuIJNTCxRKXpCGgg+PnPOEPnt7BOQuflrPE95jMbAVBhz62TtlwcilaGSw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783890391; c=relaxed/simple; bh=gbTpgLSlk6j5GzT6lNNblMutGWhUGY9BadbN+VJD070=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=B2R0YO2+k+yTymx+CY5phkRYbl267lbKV+lLb+f6Sm8VlfuqSqOcBVLs6TbZ8BoG51orUdP7hKFLmzNk9N+tfcexWbubjU11PygrQU6rZNUsQleIST3oBdyjPZq26zYyu+TrGTp098W1aLo9u1OaT5ZbeF6guBIf1AYI3r7zveY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de; spf=pass smtp.mailfrom=arndb.de; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b=mjbuPEmF; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=FZK0NTPQ; arc=none smtp.client-ip=103.168.172.148 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arndb.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="mjbuPEmF"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="FZK0NTPQ" Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfout.phl.internal (Postfix) with ESMTP id ECC36EC01B7; Sun, 12 Jul 2026 17:06:27 -0400 (EDT) Received: from phl-imap-05 ([10.202.2.95]) by phl-compute-04.internal (MEProxy); Sun, 12 Jul 2026 17:06:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1783890387; x=1783976787; bh=VNpaj/maNL0E1QeJjWf/EuHS6fHaisLyfyeXNe/3uV8=; b= mjbuPEmFXp+PnMONr5np7w6FgzP+0861ryq4KHUe7UQ3hDIoXgOm0LJ8V3Ae57X4 aaKTNkOc52d80K0I7567Xt34NkxG0cOooEol0QhmKHkKwqcxvUMOyFCahjfk9fVG 55WzycbEN7NsG9dlT6aEKPT4Vy9F476/e9wA2Vi4ov0rYXrm88Db4oxMQm4AyWM8 dOqEQiqHCkGi9t6WRZ5UEpPlm1ySSB2123TwCjOwj8VGFdyb907zKomDaJuxZcBw 8k1kfsXZy66BKulLp5sCyCG+hgFkWmrS69CP2kV5+kiBebHE0XDveFI8AI21nU35 Qzzb2Fde7mnkwzjN0nI52Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1783890387; x= 1783976787; bh=VNpaj/maNL0E1QeJjWf/EuHS6fHaisLyfyeXNe/3uV8=; b=F ZK0NTPQ1wP7kjVJp9KB2RimARZEK5uddEiSvUZOlVoMi52l0IT6XQW0/WH5DSbl9 /+U40U++6DEsOpfzyYc0N5SzlIb54gFT05xpTSpb3RPTW91/9++YT02Ql0MAsgTN OEabBtx3hidImtB9m7N62mAdgNHGf6Knn9dPgz5jvcLOyVrXDwf90DMSlMS3270k /5//fVh09J0c+JXpB4i3bO2SZw/m/mfkrkB7uTOjMgbJiqlwgjc9/L6ftvKlZFlu uPESIOgqItb9o9OC8fauWffXtfWuzmawSlBvO5llZuK18cN/lAdUl6mFgM0nO2EW 6lX0DK1sLQU9aawcDPPzg== X-ME-Sender: X-ME-Proxy-Cause: dmFkZTE9y5C/6RIdS+5QVbQ29xta7Gw2toEPS1iuIlAx8rzJVQT3j9cubDQryc46qus1Pu Idr96Bwew5Kd7xVwCdS6Dt7pwXOD9wzscTOZHEu3dK6v5UVUp3HN7/J0twgmyCdONaGeBD p7JDetbzGJSScU5K94RmmVmBPlDHD1iaHOL27wRFddbZ16KeVHH2ojlMM9qu+tUsH0OqiD TO3vrmI10eW09YG0tGvuSQRg1TVpA+lDLK53n+RWOuYTumuYFCwJQZeL0VYdqB31AtrHOO CEU4LAWotUtKo7xWR9G79aTMKHZSyGgMVA1KScmkAN1lg4Gm5b0yXIMi2u4ysjtV+ZG1Te QR9MhTEg6n2ukUnTx1BLhhoY9RgqdEEEN2auejwik8VZegxzLGsXwNGRhT+izp1CxCNlud 3hP1MPK4cL6Ed4pRHUu8F4KjBCtfOFSrdYLVxEHuGV0XGjb6y7/ioC8E7cFadsNzxN+hn0 SVflZRr5xBYCoUmqjNlwdEPkgGkFQradPkNc2iFEichqWqxAgHyU/qEhgbpbYkede+sQGf 7W6rU0VWi2LaCzpy8Q5Q0IdGBjRq3zoHdHbQ3IlnZklu/xqkW9J+ZVONylWdLAt8/xFB10 VvMvJEcZkgtJQOm5tcX3omnc2pFTeAAZvI66nJ4EO7RUXs0fDfz3xVgYPbcw X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id AD9B9182007E; Sun, 12 Jul 2026 17:06:27 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: AMjyoxKQRD77 Date: Sun, 12 Jul 2026 23:04:51 +0200 From: "Arnd Bergmann" To: "Karl Mehltretter" , "Vladimir Zapolskiy" , "Piotr Wojtaszczyk" Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Message-Id: In-Reply-To: <20260712205617.44944-1-kmehltretter@gmail.com> References: <20260712205617.44944-1-kmehltretter@gmail.com> Subject: Re: [PATCH] ARM: lpc32xx: only run arch_initcalls on LPC32xx hardware Content-Type: text/plain Content-Transfer-Encoding: 7bit On Sun, Jul 12, 2026, at 22:56, Karl Mehltretter wrote: > lpc32xx_check_uid() and lpc32xx_pm_init() are arch_initcalls that poke > LPC32xx-only registers (the CLKPWR unique-ID and the EMC control > register). Since the multiplatform conversion they also run on other > ARCH_MULTI_V5 boards, where the access faults, e.g. on versatile: > > Unable to handle kernel paging request at virtual address f4004130 > PC is at lpc32xx_check_uid+0x2c/0x9c > > Bail out of both unless we are running on an LPC32xx SoC, reusing the > machine's DT_MACHINE compatible list so the guard can't drift from it. > > Fixes: 75bf1bd7d2f9 ("ARM: lpc32xx: allow multiplatform build") > Signed-off-by: Karl Mehltretter Hi Karl, This fix looks correct to me, but I think it would be better to replace the arch_initcall() entries with a direct function call from lpc3250_machine_init(), which also runs at the arch_initcall level and is already guarded properly. The calls should be entered in link order, which would mean common.c, pm.c, phy3250.c. Arnd