From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C7C833A01D for ; Thu, 16 Oct 2025 13:48:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760622489; cv=none; b=AY4vMfxtCgz/sljnTMiLO8LzDE7EIODl5K7WfJxCfvucx/IIT8h1ij3pvFrvDqi2HsRCkSJ8V3GRdg4exmyLY1hKaQdik5xJ1BopSOB83MEqB+PItjwfkV/SxNN5J87IA9Z7XIwPXQrM8sV36FjGplnZCxvDEhiEx9fWPViU7Ng= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760622489; c=relaxed/simple; bh=sSDe1mGlkEL2RtCUFKIHhbHVM3TXv73UeokYbvF2fOY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Px4PodX2fnjOAvZXdSblB/0Ua7miuBJtCEMQlv8Rmo9Misz+xa9kFO3ucv2/n+zOnutgmKoXhRcvug7lzG8iF0dkAoC3vCFRiDS1X/EgGExrhi15ko/0whXTyzfiR1eWKaD/oP9+lJdeMfY6/YPyYJyaENVofxAy5igSFRVxZVQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=wf0mGeeX; arc=none smtp.client-ip=209.85.167.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wf0mGeeX" Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-580585075aeso127029e87.2 for ; Thu, 16 Oct 2025 06:48:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760622484; x=1761227284; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=gcAg85FBlDnXHKhY+clR6LHNWXAePe89oWLFHhsgwvw=; b=wf0mGeeXXJaeC+ph0tGH1pvKZc02ZCHXYW6ydDgGVrmiB03NAe5eLQ98FshU2Cu6Em /UmyNTG6MuiwZjgoa0KX7oIgMs1QL26i2GEBEKh+l8F4jFgB/e3DNNMvhKvC9HnMtMmp 4utiEufqWdXjm/mejyYDaGc6Vc1xRAhCa+hirOBmJHZ2+AeC1qHm07yh/z3bYhXTtnT7 peJJUNuCrOSy7bf2b/nsBNHPJi8upVnQKKXvPkfEFYN5/o7LO01NKVM+J0/LAewRqIyK tGWaT71xNnuez7SsU0wkvgfcv4Rnbrlheow0yVjS1qOXi0UDfWU9pHdLtWUOfsxJ/1K+ O3qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760622484; x=1761227284; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=gcAg85FBlDnXHKhY+clR6LHNWXAePe89oWLFHhsgwvw=; b=HFH6YyPUBZE+vBUlrBww+D9EyE6V7ZCY5sLLlfGDao6nAK9VxgJMvTY5/ipeJ5LMFF p3qd48WKR4TULjMYt+3zdW7XPofxnvopiHgU7k6BuN4bnMoPmBuCrBMnNiHs8CPlVzf1 ssJ+y8gkxXZAKci8PnTHBGsRTMzTSjczv25QmU78lL9ojOfBLvPhblQYgsP27i2eGpfB drv6C1MpYEKtmRPTkv1qwK1hnXtTpXAlBcCcgpfvw9Qb4bSrJ2or4IYmQqGENGa9eNgO fWbDq7nHYe3mWkNtndH5DVoE64DIKC0tMDe7wdr9Y+vRHcPIzLQ2mXskbXWyvnMlX/89 p2/A== X-Forwarded-Encrypted: i=1; AJvYcCWnCv5wosz9f2XF8O849Fep0iUqP6XBju8XLafzbyMeH2J8G3Xm1QbLvkOZ+bAFQk02QRSLmyqE3O2MK90=@vger.kernel.org X-Gm-Message-State: AOJu0YwlgurrehO3GOhKyaZBquU6bUnPlqW54/vSrMdXIYRl3siNZRfx OaU5dEskIo70U+X9KNRh2WGbLzg7+Iwsj0Xii31iyU3eEvjgF1b5rsmcHq7aNilvr8I= X-Gm-Gg: ASbGncsaM5LExpQPf38PS72aGQZdJlRCLrGkEtN3xYi877XY0cz7rJuZ9PVe7d4Pg8c YisHvA21ny9kWkKxh7adYh9Zwx+YYbfs9SwQcqDXi96KdiDPGBj5XMTxITKuqzKQ0rCToR2VuuQ gQHmiO8YQImHZP+DuMIXIyjIjQpI+9x+wP8Ldd02qeRMZrt2LKOxHfqXbmbbyUC+FO4bMNg9tPg DXEIBgy7A906QRkj5W/AAraVpp6p7p9E7XbrM9M42rhJRHNyYDM9ttf0OdP9IqVf8kMjO+XedeF NSCXBnTridpaXLl1X6SNGcoUscF0igmEOsEeucYY9x/jJqmxiQ/Whmsg+x6N19OimcUqgbXwpcT irdMkcaOK0O11EIeOuWwCcA89kpvHFp4m5cjggkb3n5DtNq2CN9l6TCZbHZoEhuPMy6KmxmpPEt IFa+Q45gTmiKYYbSyuJ33ETKRZVyGZ/S8XEVEE31npR4g5splcMpZ0bE+LhZ3tEvM7K1rcH9T0H Vkvr2to X-Google-Smtp-Source: AGHT+IFJNT+AAD99Hz3zpEUaGMgFi/cx8sgcMYMp0PdSXJ1mbaKwn/y+9OKRg8oSB9qI/6dBNhERfA== X-Received: by 2002:a05:6512:3ca5:b0:55f:461e:b458 with SMTP id 2adb3069b0e04-591d8550df2mr36408e87.4.1760622484271; Thu, 16 Oct 2025 06:48:04 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-590885768desm7109937e87.98.2025.10.16.06.48.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Oct 2025 06:48:03 -0700 (PDT) Message-ID: Date: Thu, 16 Oct 2025 16:48:02 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] arm64: dts: qcom: sm6150: Add camss node To: Wenmeng Liu , Robert Foss , Todor Tomov , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251016-sm6150-camss-v1-0-e7f64ac32370@oss.qualcomm.com> <20251016-sm6150-camss-v1-3-e7f64ac32370@oss.qualcomm.com> From: Vladimir Zapolskiy In-Reply-To: <20251016-sm6150-camss-v1-3-e7f64ac32370@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/16/25 13:22, Wenmeng Liu wrote: > Add node for the SM6150 camera subsystem. > > Signed-off-by: Wenmeng Liu > --- > arch/arm64/boot/dts/qcom/sm6150.dtsi | 121 +++++++++++++++++++++++++++++++++++ > 1 file changed, 121 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm6150.dtsi b/arch/arm64/boot/dts/qcom/sm6150.dtsi > index 3d2a1cb02b628a5db7ca14bea784429be5a020f9..ebfb336439b4fdfa567c0e011cd4da88a6290dfd 100644 > --- a/arch/arm64/boot/dts/qcom/sm6150.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm6150.dtsi > @@ -3646,6 +3646,127 @@ videocc: clock-controller@ab00000 { > #power-domain-cells = <1>; > }; > > + camss: isp@acb3000 { > + compatible = "qcom,sm6150-camss"; > + > + reg = <0x0 0x0acb3000 0x0 0x1000>, > + <0x0 0x0acba000 0x0 0x1000>, > + <0x0 0x0acc8000 0x0 0x1000>, > + <0x0 0x0ac65000 0x0 0x1000>, > + <0x0 0x0ac66000 0x0 0x1000>, > + <0x0 0x0ac67000 0x0 0x1000>, > + <0x0 0x0acaf000 0x0 0x4000>, > + <0x0 0x0acb6000 0x0 0x4000>, > + <0x0 0x0acc4000 0x0 0x4000>; > + reg-names = "csid0", > + "csid1", > + "csid_lite", > + "csiphy0", > + "csiphy1", > + "csiphy2", > + "vfe0", > + "vfe1", > + "vfe_lite"; > + > + clocks = <&camcc CAM_CC_CAMNOC_AXI_CLK>, > + <&camcc CAM_CC_CPAS_AHB_CLK>, > + <&camcc CAM_CC_CSIPHY0_CLK>, > + <&camcc CAM_CC_CSI0PHYTIMER_CLK>, > + <&camcc CAM_CC_CSIPHY1_CLK>, > + <&camcc CAM_CC_CSI1PHYTIMER_CLK>, > + <&camcc CAM_CC_CSIPHY2_CLK>, > + <&camcc CAM_CC_CSI2PHYTIMER_CLK>, > + <&gcc GCC_CAMERA_HF_AXI_CLK>, > + <&camcc CAM_CC_SOC_AHB_CLK>, > + <&camcc CAM_CC_IFE_0_CLK>, > + <&camcc CAM_CC_IFE_0_AXI_CLK>, > + <&camcc CAM_CC_IFE_0_CPHY_RX_CLK>, > + <&camcc CAM_CC_IFE_0_CSID_CLK>, > + <&camcc CAM_CC_IFE_1_CLK>, > + <&camcc CAM_CC_IFE_1_AXI_CLK>, > + <&camcc CAM_CC_IFE_1_CPHY_RX_CLK>, > + <&camcc CAM_CC_IFE_1_CSID_CLK>, > + <&camcc CAM_CC_IFE_LITE_CLK>, > + <&camcc CAM_CC_IFE_LITE_CPHY_RX_CLK>, > + <&camcc CAM_CC_IFE_LITE_CSID_CLK>; > + > + clock-names = "camnoc_axi", > + "cpas_ahb", > + "csiphy0", > + "csiphy0_timer", > + "csiphy1", > + "csiphy1_timer", > + "csiphy2", > + "csiphy2_timer", > + "gcc_axi_hf", > + "soc_ahb", > + "vfe0", > + "vfe0_axi", > + "vfe0_cphy_rx", > + "vfe0_csid", > + "vfe1", > + "vfe1_axi", > + "vfe1_cphy_rx", > + "vfe1_csid", > + "vfe_lite", > + "vfe_lite_cphy_rx", > + "vfe_lite_csid"; > + > + interconnects = <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY > + &config_noc SLAVE_CAMERA_CFG QCOM_ICC_TAG_ACTIVE_ONLY>, > + <&mmss_noc MASTER_CAMNOC_HF0 QCOM_ICC_TAG_ALWAYS > + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>; > + interconnect-names = "ahb", > + "hf_mnoc"; > + > + interrupts = , > + , > + , > + , > + , > + , > + , > + , > + ; > + interrupt-names = "csid0", > + "csid1", > + "csid_lite", > + "csiphy0", > + "csiphy1", > + "csiphy2", > + "vfe0", > + "vfe1", > + "vfe_lite"; > + > + iommus = <&apps_smmu 0x820 0x40>; > + > + power-domains = <&camcc IFE_0_GDSC>, > + <&camcc IFE_1_GDSC>, > + <&camcc TITAN_TOP_GDSC>; > + power-domain-names = "ife0", > + "ife1", > + "top"; > + > + status = "disabled"; Please remove empty lines between properties all above. > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + }; > + > + port@1 { > + reg = <1>; > + }; > + > + port@2 { > + reg = <2>; > + }; > + }; > + }; > + > camcc: clock-controller@ad00000 { > compatible = "qcom,qcs615-camcc"; > reg = <0 0x0ad00000 0 0x10000>; > Reviewed-by: Vladimir Zapolskiy -- Best wishes, Vladimir