From: Pavel Skripkin <paskripkin@gmail.com>
To: Martin Kaiser <martin@kaiser.cx>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Michael Straube <straube.linux@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] staging: r8188eu: merge _mgt_dispatcher into mgt_dispatcher
Date: Wed, 13 Apr 2022 23:39:04 +0300 [thread overview]
Message-ID: <b028d269-4dd8-7165-6220-d42c1e0e588c@gmail.com> (raw)
In-Reply-To: <20220413200742.276806-3-martin@kaiser.cx>
Hi Martin,
On 4/13/22 23:07, Martin Kaiser wrote:
> All that the _mgt_dispatcher function does is to call a function from
> a function pointer. It's not worth having a separate function for this.
>
> Merge _mgt_dispatcher into mgt_dispatcher.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
[code snip]
> +
> + if (ptable->func) {
> + /* receive the frames that ra(a1) is my address or ra(a1) is bc address. */
> + if (memcmp(GetAddr1Ptr(pframe), myid(&padapter->eeprompriv), ETH_ALEN) &&
> + !is_broadcast_ether_addr(GetAddr1Ptr(pframe)))
> + return;
> + ptable->func(padapter, precv_frame);
> + }
> }
Looks like each `mlme_sta_tbl` element has `func` member initialized. I
think, we can remove this check.
With regards,
Pavel Skripkin
next prev parent reply other threads:[~2022-04-13 20:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 20:07 [PATCH 0/4] staging: r8188eu: some more cleanups Martin Kaiser
2022-04-13 20:07 ` [PATCH 1/4] staging: r8188eu: use ieee80211 helper to read the qos tid Martin Kaiser
2022-04-13 20:07 ` [PATCH 2/4] staging: r8188eu: merge _mgt_dispatcher into mgt_dispatcher Martin Kaiser
2022-04-13 20:39 ` Pavel Skripkin [this message]
2022-04-17 10:33 ` Martin Kaiser
2022-04-13 20:07 ` [PATCH 3/4] staging: r8188eu: use ieee80211 helpers in mgt_dispatcher Martin Kaiser
2022-04-13 20:07 ` [PATCH 4/4] staging: r8188eu: pkt_newalloc is not used Martin Kaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b028d269-4dd8-7165-6220-d42c1e0e588c@gmail.com \
--to=paskripkin@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®