From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40B933264D4 for ; Tue, 19 May 2026 07:27:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779175629; cv=none; b=Xo/udhnvsI2J/SCeleRfb3fkAVUO+/bN1fm8LyXlB5jB68/bJcZr5MPZLdbwUxbicUOXYB69H/698g67O6TYCH7ufDjJcBTqjqHN4yBwzcfH9sDQPa6+hS9HYwNH+p8jkfbdvSQlk7K18dKo777MWgPA6XD+uyLz79q6Y4zW2Pc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779175629; c=relaxed/simple; bh=v+IdkKQNQEB4PKIbUhLb3vJHN6L0jkaJPJKTaR8XEVE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=G3YgZ853dvdSAA0VXyB0JJ7cQ57ZdE4CvubkYM/OMx8pLsdqNhS/aKqCJ8UZqopy9r460jveGamqVDPSUdTOuiEngsXRRNpHC0GaKQ54eQcrh60WoJSqpiCu0PgfnWaFOFKi/ZX37MsQbcik9EUuPf8bBL8EpYqXsWV0wqAW+WA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RERe0nhL; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=H2RB1BT2; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RERe0nhL"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="H2RB1BT2" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64J4sYWe254349 for ; Tue, 19 May 2026 07:27:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= utMyKzcFS3nlxzF6C6V7bnijzPGvaVgfCyXA1B5b1iU=; b=RERe0nhLWi4CRDxh g2MAN7OG8I3bFpm7BKfHKN1bSo6r4WioWuKjw0hYomEzET0+WMKnkwd31Bz9YjtF nG5y2E43D2CHO9V6tmMnsqd2ktDcKFxSMqU62jtP0AlY75pHAWmYpe+679LMWxnh CzWvJALzJTnNclcaQtQNXbXz8sQkvTE745L3WuCTNxEijECJAdD9OsRIQpNvAiLK wmQNqAov4VBQwMQoD2+JCwpOyryLYTo+H6NrVIgC0uyQfQLUv4eafXaQnTH1j+/y KMm6ic4P32jVbW2HNJWpDpGlvQzj0WrI+fMWsDVQfSZhOWmP6bTuQzhXYxFOzHDh RcRHlQ== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e8h87rkgu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 19 May 2026 07:27:07 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2bd6cc53fd6so33247775ad.3 for ; Tue, 19 May 2026 00:27:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779175626; x=1779780426; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=utMyKzcFS3nlxzF6C6V7bnijzPGvaVgfCyXA1B5b1iU=; b=H2RB1BT2fLVBEa2x7i7PnZPSyrTE6B381ryCu+SCNuVMnFhtyPcL+5A7DPMbgfcpL0 2YERY62ut0kW+KsbCD6gHrzaJzKqiAYxjpx3qOG/OsejDNo1Iq1/GJw7tZ45y0pY+2aY qJMQo4uVPzOa0cGeCSk4kGPmbmti83DpxYIw89VLrqLGV2XZqksjBUYTcnVgy5/bcwMl BH1E4YJJwQNMMJtDqNXaS2pHnPBQMjVgfy8EB7U8bgnmQa4Aws3hgRTNuIe981P1pVc4 StpLWSgNNLmsoOz8WVYQdsSj0MoJ6nNThLZcF+KaYItuLXoyfBEboxYZ5ZXrv87c4tjM XnjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779175626; x=1779780426; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=utMyKzcFS3nlxzF6C6V7bnijzPGvaVgfCyXA1B5b1iU=; b=NXlLWvz/4bIm0XSueU+LI05Tsg/p9l5aZAxBq9ga1UuIHWNBnXJ0G5b7bBqu62JxMh w7SCT7EQ1tmnOGrnEiuSE0tycto5tNwv5Z+r/ZG7KxJq3BbWadcGi8Yzh1EthdglkPTA Kw7iBOypHZniPDfP5fBBDmQxs9VFbYblQBko3tSeOwkvHxPufbpsVcGYz1Khx7jbCjuW LwI53K0Ru/C7KAsDmd+FEP4Ho6zEWPUHx1ohe+0z6CjW8jwTO0MsCbIsIsjN8cAP6cIs +d7LdV62pUuxM1HpG506LETY4E/j4dMkQfrXWGOjCdEGcEj8sdbPDz3QCcDFlp7ZnoEI w+4g== X-Forwarded-Encrypted: i=1; AFNElJ+ceCPVgIXZknJU/+RigV6n2mgfhopG9GP4ZDGgvWrHLFL5vdaxamJ+/FsSbJNhJpjigHpqUu04PoEVScY=@vger.kernel.org X-Gm-Message-State: AOJu0YygsRZgLGfIon0z3pvNh53/xtQCPS/YYymxsYR/bu0uJIP/7PFo hEfZ1kQ3UNLH/vMyODDhHo+JvyrfRE8Hr0yjdoP3eNHqNZdsaO7nU9phBQwPcMIMJcCkNhsAltB K/3HJ2SnSbQYxLr+LJrgOOP48bcDyC4jXxpURHhrLRF47uc5z/+5+i49PytyTa0nJaOw= X-Gm-Gg: Acq92OFQXNXDsosF1g5cRKEQeJ3oLj/NaORLGlg6DONIMABTQPXZAe6kb0meijn2zdM WZX9fUkCTWjpG3ZHd30BsCsHSU5YqTXeSaCgIvfRLY1icRUPQ2imGuKG3Haz6rDMS9EzggBNB3m kW/yeyg0Q6sOVvUeLEYCgWTyBJ7XCU1Xo9MtxGhxitv/i+x+oQOUtc7hhB0it6YwBn9JQyecsTq VKNN88jnmtGdOIeaVjDyOMl6EowS/z2nNsBL4TH+XBu23oERUeLSf2vt8wKpaZ5lNh6cKESgp2/ p/SIJvBf6hFIKeK/uFgW6iMrXgz6QFvDvlrETTo0/nff6IuVPCY5uNxOVoqBTOHxFDrqgKDmf3S 14DSn7J0+6hGa06079yL6vnQU1TMIqu77Mv7p/T198Ott2Pl5nQ8GyhpNVgNY+8npvtueDKWTEh pfwW+w+zSFNlSGycbYPQ== X-Received: by 2002:a17:903:950:b0:2bd:a3c5:6d96 with SMTP id d9443c01a7336-2bda3c56ef9mr137131325ad.14.1779175626144; Tue, 19 May 2026 00:27:06 -0700 (PDT) X-Received: by 2002:a17:903:950:b0:2bd:a3c5:6d96 with SMTP id d9443c01a7336-2bda3c56ef9mr137131115ad.14.1779175625661; Tue, 19 May 2026 00:27:05 -0700 (PDT) Received: from [10.133.33.114] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5c0605ddsm168210415ad.32.2026.05.19.00.27.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 May 2026 00:27:05 -0700 (PDT) Message-ID: Date: Tue, 19 May 2026 15:27:00 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 01/39] drm/msm/dp: remove cached drm_edid from panel To: Dmitry Baryshkov Cc: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260410-msm-dp-mst-v4-0-b20518dea8de@oss.qualcomm.com> <20260410-msm-dp-mst-v4-1-b20518dea8de@oss.qualcomm.com> <7cnjdge435t55s5vf66fkjfmkz7jvcbbax2uuismyc74mv4eia@toe2vu2folqa> Content-Language: en-US From: Yongxing Mou In-Reply-To: <7cnjdge435t55s5vf66fkjfmkz7jvcbbax2uuismyc74mv4eia@toe2vu2folqa> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: NYCz4nP9hyWtq93UI_ud3g4GpntJU2VY X-Proofpoint-ORIG-GUID: NYCz4nP9hyWtq93UI_ud3g4GpntJU2VY X-Authority-Analysis: v=2.4 cv=a9sAM0SF c=1 sm=1 tr=0 ts=6a0c10cb cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=kvofMlIKq05Gu29qcYUA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE5MDA3MiBTYWx0ZWRfXyVco/IamPQw6 Ldl2K+Eww83wprDiHKampoSeXxKLvBoKgYiEWc/fXM0g0bAPlC+OubInEarBvKJeLhUt5goo1be L3pwDSzivoX6u+2H00u4gCTSnVfSx1Rm1vYgdu5CNSWWsXoWnqPOcdN58ic+Qp513q/plKyvQnL rl8nrGGptvev/GafY4WFw9JvAL0OMebVJ6fHw8JLsSqv3LlcuIIfLZyZ3SG6zt6jaoW2MY8dG7+ MXT647Qh1q3J65+3GMr+T9LcYPkiGZeH38AtaZKEi89Ifq0/7RAJT8m8ijzaw0qqD2Q/9T1Ryao 6Y7XDVUb0P8sWWlV8D8w7ArJmH0/opzyFqkJPhuDDibebhVQMZDhEbBrOjDNZ7fPyTptEFnFMmM Un61FD42QgX1Z/OZ79uFroC+KFci6Mw68r9m+EdTI/gBRyDi8r/bwj9Ofn8UOJRxu9MhtQ+FVlx 3H7CRg1G4BXLkHj47CA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-19_02,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 impostorscore=0 adultscore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 suspectscore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605190072 On 4/10/2026 9:52 PM, Dmitry Baryshkov wrote: > On Fri, Apr 10, 2026 at 05:33:36PM +0800, Yongxing Mou wrote: >> The cached drm_edid seems unnecessary here. Use the drm_edid pointer >> directly in the plug stage instead of caching it. Remove the cached >> drm_edid and the corresponding oneliner to simplify the code. >> >> Signed-off-by: Yongxing Mou >> --- >> drivers/gpu/drm/msm/dp/dp_display.c | 27 +++++++++++------- >> drivers/gpu/drm/msm/dp/dp_panel.c | 57 ++++--------------------------------- >> drivers/gpu/drm/msm/dp/dp_panel.h | 13 +++------ >> 3 files changed, 26 insertions(+), 71 deletions(-) >> >> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c >> index 5c6a24ec140d..e28cc1bbb5b1 100644 >> --- a/drivers/gpu/drm/msm/dp/dp_display.c >> +++ b/drivers/gpu/drm/msm/dp/dp_display.c >> @@ -268,6 +268,7 @@ static int msm_dp_display_process_hpd_high(struct msm_dp_display_private *dp) >> const struct drm_display_info *info = &connector->display_info; >> int rc = 0; >> u8 dpcd[DP_RECEIVER_CAP_SIZE]; >> + const struct drm_edid *drm_edid; >> >> rc = drm_dp_read_dpcd_caps(dp->aux, dpcd); >> if (rc) >> @@ -275,10 +276,20 @@ static int msm_dp_display_process_hpd_high(struct msm_dp_display_private *dp) >> >> dp->link->lttpr_count = msm_dp_display_lttpr_init(dp, dpcd); >> >> - rc = msm_dp_panel_read_sink_caps(dp->panel, connector); >> + rc = msm_dp_panel_read_link_caps(dp->panel, connector); >> if (rc) >> goto end; >> >> + drm_edid = drm_edid_read_ddc(connector, &dp->aux->ddc); > > Where is it free? > Ohh, i miss it, will update next version >> + drm_edid_connector_update(connector, drm_edid); >> + >> + if (!drm_edid) { >> + DRM_ERROR("panel edid read failed\n"); >> + /* check edid read fail is due to unplug */ >> + if (!msm_dp_aux_is_link_connected(dp->aux)) > > Does this work for USB-C AltMode usecase? > For USB-C DP, i think it always TRUE, here should already existed before this patch.. >> + return -ETIMEDOUT; >> + } >> + >> msm_dp_link_process_request(dp->link); >> >> if (!dp->msm_dp_display.is_edp) >