From: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
To: Florian Eckert <fe@dev.tdt.de>
Cc: Eckert.Florian@googlemail.com, info@metux.net,
dvhart@infradead.org, andy@infradead.org,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] platform/x86/pcengines-apuv2: add legacy leds gpio definitions
Date: Wed, 10 Jul 2019 15:07:12 +0200 [thread overview]
Message-ID: <b029d90c-06b6-a261-5cde-8034de052d7c@metux.net> (raw)
In-Reply-To: <e4583be44ddaa1453c0caea37d73d57d@dev.tdt.de>
On 10.07.19 14:03, Florian Eckert wrote:
> I have back ported your pcengines-apuv2 device and gpio-amd-fch GPIO
> driver to the kernel version 4.19 on OpenWrt.
> If I compile and load this without the change no LEDs are visible in
> "/sys/class/leds"!
Maybe this old kernel just ignored all entries w/o gpio ID. Note that
these IDs are deprecated for quite a while and shouldn't be used in new
code anymore.
> From my point of view the connection between the GPIO and the LEDs
> subsystem is missing.
> How should the LED subsystem know which GPIO to use?
See gpiod_lookup_table.
> If I add the change to the pcengines-apuv2 device then the LEDs will be
> visilbe under "/sys/class/leds"
> and could be used, by OpenWrt userland.
>
> Mybe I miss something.
Your patch is only valid for your backport onto this old kernel, not for
recent mainline.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
next prev parent reply other threads:[~2019-07-10 13:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-04 9:02 [PATCH 0/3] Update pcengines-apuv2 platform device Florian Eckert
2019-07-04 9:02 ` [PATCH 1/3] platform/x86/pcengines-apuv2: add mpcie reset gpio export Florian Eckert
2019-07-08 19:44 ` Enrico Weigelt, metux IT consult
2019-07-10 12:30 ` Florian Eckert
2019-07-15 12:15 ` Enrico Weigelt, metux IT consult
2019-07-15 14:38 ` Florian Eckert
2019-07-16 18:23 ` Enrico Weigelt, metux IT consult
2019-07-22 11:25 ` Enrico Weigelt, metux IT consult
2019-07-04 9:02 ` [PATCH 2/3] platform/x86/pcengines-apuv2: add legacy leds gpio definitions Florian Eckert
2019-07-08 19:42 ` Enrico Weigelt, metux IT consult
2019-07-10 12:03 ` Florian Eckert
2019-07-10 13:07 ` Enrico Weigelt, metux IT consult [this message]
2019-07-04 9:02 ` [PATCH 3/3] platform//x86/pcengines-apuv2: update gpio button definition Florian Eckert
2019-07-08 19:27 ` Enrico Weigelt, metux IT consult
2019-07-22 11:27 ` Enrico Weigelt, metux IT consult
2019-07-23 7:06 ` Florian Eckert
2019-07-23 23:00 ` Enrico Weigelt, metux IT consult
2019-07-04 13:39 ` [PATCH 0/3] Update pcengines-apuv2 platform device Andy Shevchenko
2019-07-04 14:00 ` Florian Eckert
2019-07-04 14:26 ` Andy Shevchenko
2019-07-05 11:36 ` Florian Eckert
2019-07-08 19:39 ` Enrico Weigelt, metux IT consult
2019-07-08 19:45 ` Enrico Weigelt, metux IT consult
2019-07-10 12:54 ` Florian Eckert
2019-07-25 17:49 ` Andy Shevchenko
2019-07-25 19:12 ` Enrico Weigelt, metux IT consult
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b029d90c-06b6-a261-5cde-8034de052d7c@metux.net \
--to=lkml@metux.net \
--cc=Eckert.Florian@googlemail.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=fe@dev.tdt.de \
--cc=info@metux.net \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome