From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29C18C43334 for ; Mon, 20 Jun 2022 07:37:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239414AbiFTHhg (ORCPT ); Mon, 20 Jun 2022 03:37:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231954AbiFTHhc (ORCPT ); Mon, 20 Jun 2022 03:37:32 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28E30EE32; Mon, 20 Jun 2022 00:37:31 -0700 (PDT) Received: from fraeml708-chm.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4LRLzF1D8vz6H6l9; Mon, 20 Jun 2022 15:35:37 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml708-chm.china.huawei.com (10.206.15.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 20 Jun 2022 09:37:28 +0200 Received: from [10.195.35.72] (10.195.35.72) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 20 Jun 2022 08:37:26 +0100 Message-ID: Date: Mon, 20 Jun 2022 08:37:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 1/5] scsi: core: Remove reserved request time-out handling To: Christoph Hellwig CC: , , , , , , , , , , , , , , , , , References: <1655463320-241202-1-git-send-email-john.garry@huawei.com> <1655463320-241202-2-git-send-email-john.garry@huawei.com> <20220620055828.GA10192@lst.de> From: John Garry In-Reply-To: <20220620055828.GA10192@lst.de> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.195.35.72] X-ClientProxiedBy: lhreml744-chm.china.huawei.com (10.201.108.194) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/06/2022 06:58, Christoph Hellwig wrote: > On Fri, Jun 17, 2022 at 06:55:16PM +0800, John Garry wrote: >> The SCSI code does not currently support reserved commands. As such, >> requests which time-out would never be reserved, and scsi_timeout() >> 'reserved' arg should never be set. >> >> Remove handling for reserved requests and drop wrapper scsi_timeout() as >> it now just calls scsi_times_out() always. > > Please rename scsi_times_out to scsi_timeout so it still matches the > method name. > ok, note that some code comments and Documentation reference scsi_times_out() so I will need to fix them up also. > Otherwise looks good: > > Reviewed-by: Christoph Hellwig > > . Cheers, John