From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8715CE7A94 for ; Mon, 25 Sep 2023 11:31:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230493AbjIYLbx (ORCPT ); Mon, 25 Sep 2023 07:31:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229537AbjIYLbu (ORCPT ); Mon, 25 Sep 2023 07:31:50 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F29ECC6; Mon, 25 Sep 2023 04:31:42 -0700 (PDT) Received: from dggpemm500005.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4RvLFz4vpqzNnnZ; Mon, 25 Sep 2023 19:27:51 +0800 (CST) Received: from [10.69.30.204] (10.69.30.204) by dggpemm500005.china.huawei.com (7.185.36.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Mon, 25 Sep 2023 19:31:40 +0800 Subject: Re: [PATCH net-next v8 1/6] page_pool: frag API support for 32-bit arch with 64-bit DMA To: Ilias Apalodimas CC: Jesper Dangaard Brouer , , , , , , , Lorenzo Bianconi , Alexander Duyck , Liang Chen , Alexander Lobakin , Guillaume Tucker , Jesper Dangaard Brouer , Eric Dumazet , Linux-MM , Matthew Wilcox , Mel Gorman References: <20230912083126.65484-1-linyunsheng@huawei.com> <20230912083126.65484-2-linyunsheng@huawei.com> <84282e55-519c-0e17-30c5-b6de54d1001c@redhat.com> <15f95505-dba9-4afd-6980-5bdf0a64d507@huawei.com> From: Yunsheng Lin Message-ID: Date: Mon, 25 Sep 2023 19:31:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.69.30.204] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500005.china.huawei.com (7.185.36.74) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/9/25 18:37, Ilias Apalodimas wrote: > Hi > > On Wed, 20 Sept 2023 at 11:59, Yunsheng Lin wrote: >> >> On 2023/9/15 16:28, Jesper Dangaard Brouer wrote: >>> Hi Lin, >>> >>> This looks reasonable, but given you are changing struct-page >>> (include/linux/mm_types.h) we need to MM-list . >>> Also Cc Wilcox. >>> >>> I think it was Ilias and Duyck that validated the assumptions, last time >>> this patch was discussed. Thus I want to see their review before this is >>> applied. >> >> FWIW, PAGE_SIZE aligned buffer being PAGE_SIZE aligned in DMA is >> validated by Duyck: >> https://lore.kernel.org/all/CAKgT0UfeUAUQpEffxnkc+gzXsjOrHkuMgxU_Aw0VXSJYKzaovQ@mail.gmail.com/ >> >> And I had done researching to find out there seems to be no combination of >> the above arch with an address space >16TB: >> https://lore.kernel.org/all/2b570282-24f8-f23b-1ff7-ad836794baa9@huawei.com/ > > Apologies for the late reply. I just saw you sent a v9, I'll review > that instead, but I am traveling right now, will take a while Actually there is a newer v10, see: https://lore.kernel.org/all/20230922091138.18014-2-linyunsheng@huawei.com/ Thanks for the time reviewing. > > Thanks > /Ilias