From: "Ken Chen" <kenchen@google.com>
To: "Ananiev, Leonid I" <leonid.i.ananiev@intel.com>
Cc: suparna@in.ibm.com, "Andrew Morton" <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-aio <linux-aio@kvack.org>,
"Zach Brown" <zach.brown@oracle.com>,
"Chris Mason" <chris.mason@oracle.com>,
"Badari Pulavarty" <pbadari@us.ibm.com>
Subject: Re: [PATCH] aio: fix kernel bug when page is temporally busy
Date: Sat, 10 Feb 2007 10:05:24 -0800 [thread overview]
Message-ID: <b040c32a0702101005q7ff4a679xd3586531aa8a99cc@mail.gmail.com> (raw)
In-Reply-To: <B41635854730A14CA71C92B36EC22AAC804976@mssmsx411>
On 2/9/07, Ananiev, Leonid I <leonid.i.ananiev@intel.com> wrote:
> I have used EIOCBRETRY in the patch to minimize source code modification
> only.
> [...]
> A lot of errno's have different meaning in different functions or
> contexts. EAGAIN could be used instated of EIOCBRETRY for irredundant
> set.
I also think the original patch is wrong. It might shut up kernel
panic by eliminate double calls to aio_complete(), but it will
silently introduce data corruption.
If invalidate_inode_pages2_range() says it can not invalidate pages,
while dio to the same file offset range is in flight, something is
really wrong there. In generic_file_direct_IO, the function
explicitly flushes all dirty pages and wait on them before submits
DIO.
So any error value returned from invalidate_inode_pages2_range() has
to be taken seriously in the direct IO submit path instead of dropping
it to the floor.
- Ken
next prev parent reply other threads:[~2007-02-10 18:05 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-09 4:29 Ananiev, Leonid I
2007-02-09 4:35 ` Andrew Morton
2007-02-09 5:41 ` Ananiev, Leonid I
2007-02-09 5:52 ` Andrew Morton
2007-02-12 22:52 ` Ananiev, Leonid I
2007-02-12 23:21 ` Ananiev, Leonid I
2007-02-09 7:16 ` Suparna Bhattacharya
2007-02-09 9:52 ` Ananiev, Leonid I
2007-02-09 10:11 ` Jiri Kosina
2007-02-10 18:05 ` Ken Chen [this message]
2007-02-10 18:17 ` Ananiev, Leonid I
2007-02-10 18:27 ` Ananiev, Leonid I
2007-02-10 21:57 ` Ananiev, Leonid I
2007-02-15 9:16 ` Ananiev, Leonid I
2007-02-15 18:25 ` Zach Brown
2007-02-15 19:11 ` Ananiev, Leonid I
2007-02-15 19:22 ` Zach Brown
2007-02-15 21:06 ` Ananiev, Leonid I
2007-02-15 23:32 ` Ananiev, Leonid I
2007-02-16 0:01 ` Zach Brown
2007-02-16 12:18 ` Ananiev, Leonid I
2007-02-09 9:54 ` Jiri Kosina
2007-02-09 10:14 ` Andrew Morton
2007-02-09 10:40 ` Jiri Kosina
2007-02-09 11:05 ` Suparna Bhattacharya
2007-02-09 11:18 ` Ananiev, Leonid I
2007-02-09 17:02 ` Zach Brown
2007-02-10 19:36 Ananiev, Leonid I
2007-02-14 17:51 Ananiev, Leonid I
2007-02-15 3:30 ` Andrew Morton
2007-02-15 5:26 ` Ananiev, Leonid I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b040c32a0702101005q7ff4a679xd3586531aa8a99cc@mail.gmail.com \
--to=kenchen@google.com \
--cc=akpm@linux-foundation.org \
--cc=chris.mason@oracle.com \
--cc=leonid.i.ananiev@intel.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbadari@us.ibm.com \
--cc=suparna@in.ibm.com \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome