From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2992600AbXCWWx2 (ORCPT ); Fri, 23 Mar 2007 18:53:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S2992603AbXCWWx2 (ORCPT ); Fri, 23 Mar 2007 18:53:28 -0400 Received: from smtp-out.google.com ([216.239.33.17]:42902 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2992600AbXCWWx1 (ORCPT ); Fri, 23 Mar 2007 18:53:27 -0400 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=received:message-id:date:from:to:subject:cc:in-reply-to: mime-version:content-type:content-transfer-encoding: content-disposition:references; b=x47VVf5sPUrQQFRzjfiklmVfvx13EtqrNAtiD5ewwAEpGtg4HIW0Befy69/nRhjXY gvsHI+FXqhHWd/ug9CtAg== Message-ID: Date: Fri, 23 Mar 2007 15:53:17 -0700 From: "Ken Chen" To: "Nish Aravamudan" Subject: Re: [patch 1/2] hugetlb: add resv argument to hugetlb_file_setup Cc: "Adam Litke" , "William Lee Irwin III" , "Andrew Morton" , linux-mm@kvack.org, linux-kernel@vger.kernel.org In-Reply-To: <29495f1d0703231548k377e3f8ds5f2ae529c34e4380@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <29495f1d0703231548k377e3f8ds5f2ae529c34e4380@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On 3/23/07, Nish Aravamudan wrote: > Comment needs updating too. Thanks. How could I miss that :-( updated patch: diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c index 8c718a3..981886f 100644 --- a/fs/hugetlbfs/inode.c +++ b/fs/hugetlbfs/inode.c @@ -734,7 +734,7 @@ static int can_do_hugetlb_shm(void) can_do_mlock()); } -struct file *hugetlb_zero_setup(size_t size) +struct file *hugetlb_file_setup(size_t size, int resv) { int error = -ENOMEM; struct file *file; @@ -771,7 +771,7 @@ struct file *hugetlb_zero_setup(size_t s goto out_file; error = -ENOMEM; - if (hugetlb_reserve_pages(inode, 0, size >> HPAGE_SHIFT)) + if (resv && hugetlb_reserve_pages(inode, 0, size >> HPAGE_SHIFT)) goto out_inode; d_instantiate(dentry, inode); diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h index 3f3e7a6..55cccd8 100644 --- a/include/linux/hugetlb.h +++ b/include/linux/hugetlb.h @@ -163,7 +163,7 @@ static inline struct hugetlbfs_sb_info * extern const struct file_operations hugetlbfs_file_operations; extern struct vm_operations_struct hugetlb_vm_ops; -struct file *hugetlb_zero_setup(size_t); +struct file *hugetlb_file_setup(size_t, int); int hugetlb_get_quota(struct address_space *mapping); void hugetlb_put_quota(struct address_space *mapping); @@ -185,7 +185,7 @@ #else /* !CONFIG_HUGETLBFS */ #define is_file_hugepages(file) 0 #define set_file_hugepages(file) BUG() -#define hugetlb_zero_setup(size) ERR_PTR(-ENOSYS) +#define hugetlb_file_setup(size, resv) ERR_PTR(-ENOSYS) #endif /* !CONFIG_HUGETLBFS */ diff --git a/ipc/shm.c b/ipc/shm.c index 4fefbad..81c8344 100644 --- a/ipc/shm.c +++ b/ipc/shm.c @@ -365,8 +365,8 @@ static int newseg (struct ipc_namespace } if (shmflg & SHM_HUGETLB) { - /* hugetlb_zero_setup takes care of mlock user accounting */ - file = hugetlb_zero_setup(size); + /* hugetlb_file_setup takes care of mlock user accounting */ + file = hugetlb_file_setup(size, 1); shp->mlock_user = current->user; } else { int acctflag = VM_ACCOUNT;