From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932078AbXC3WG1 (ORCPT ); Fri, 30 Mar 2007 18:06:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932185AbXC3WG0 (ORCPT ); Fri, 30 Mar 2007 18:06:26 -0400 Received: from smtp-out.google.com ([216.239.33.17]:2828 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932078AbXC3WGZ (ORCPT ); Fri, 30 Mar 2007 18:06:25 -0400 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=received:message-id:date:from:to:subject:cc:in-reply-to: mime-version:content-type:content-transfer-encoding: content-disposition:references; b=CglBD/xvDBf+CeNnbHvvnEMdv6aUaS9AfcJnHVYXYIJkHvgMWJvG+SElD2LG7sTES 37dBaV7W33Pha0Tk/vfqA== Message-ID: Date: Fri, 30 Mar 2007 15:06:03 -0700 From: "Ken Chen" To: "Andrew Morton" Subject: Re: [patch] remove artificial software max_loop limit Cc: "Jan Engelhardt" , "Linux Kernel Mailing List" In-Reply-To: <20070330141524.5f6cff29.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070330141524.5f6cff29.akpm@linux-foundation.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On 3/30/07, Andrew Morton wrote: > So.. this change will cause a fatal error for anyone who is presently > using max_loop, won't it? If they're doing that within their > initramfs/initrd/etc then things could get rather ugly for them. probably, if they access loop device non-sequentially. > I don't know how much of a problem this will be in practice - do people use > max_loop much? I don't know either. > btw, did you test this change as both a module and as linked-into-vmlinux? as linked-into-vmlinux. why do you ask? It breaks if it is module? I made last minute change to a mutex name and shamely posted without doing a compile test. Besides that, is there something else breaks? - Ken