Re: panic with tg_shares_up again?

[Ken Chen <kenchen@google.com>]

On Tue, Dec 23, 2008 at 5:31 PM, Yinghai Lu <yinghai@kernel.org> wrote:
> > After a couple of hours joggling with type cast and different order in
> > which these two variables are checked, the compiler I'm using seems to
> > insist only check one byte out of sd_rq_weight.  I give up for the day
> > and removed the 'static' function declaration of
> > update_group_shares_cpu().  Without the 'static', the assembly looks
> > alright to me.
> >
> > I will ask compiler expert to see what's wrong with this code.  For
> > now, the following add on patch seems generate correct x86 assembly
> > code.
>
> maybe my compiler has some problem too?  just upgrade to opensuse 11.1 last week.
>
> yhlu@linux-mstp:~/xx/xx/kernel/tip/linux-2.6> gcc --version
> gcc (SUSE Linux) 4.3.2 [gcc-4_3-branch revision 141291]
> Copyright (C) 2008 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions.  There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

I'm shooting darts around, not sure what's going on yet.

- Ken