From: John Hubbard <jhubbard@nvidia.com>
To: Timur Tabi <ttabi@nvidia.com>,
Alistair Popple <apopple@nvidia.com>,
Joel Fernandes <joelagnelf@nvidia.com>
Cc: Alexandre Courbot <acourbot@nvidia.com>,
"lossin@kernel.org" <lossin@kernel.org>,
"ojeda@kernel.org" <ojeda@kernel.org>,
"boqun.feng@gmail.com" <boqun.feng@gmail.com>,
"a.hindborg@kernel.org" <a.hindborg@kernel.org>,
"simona@ffwll.ch" <simona@ffwll.ch>,
"tmgross@umich.edu" <tmgross@umich.edu>,
"alex.gaynor@gmail.com" <alex.gaynor@gmail.com>,
"nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rust-for-linux@vger.kernel.org" <rust-for-linux@vger.kernel.org>,
"bjorn3_gh@protonmail.com" <bjorn3_gh@protonmail.com>,
Edwin Peer <epeer@nvidia.com>,
"dirk.behme@gmail.com" <dirk.behme@gmail.com>,
"airlied@gmail.com" <airlied@gmail.com>,
"aliceryhl@google.com" <aliceryhl@google.com>,
"gary@garyguo.net" <gary@garyguo.net>,
"dakr@kernel.org" <dakr@kernel.org>
Subject: Re: [PATCH 2/4] gpu: nova-core: gsp: Fix length of received messages
Date: Mon, 15 Dec 2025 11:54:46 +0900 [thread overview]
Message-ID: <b046ae27-3d68-4b2b-9464-1d481a8b8faf@nvidia.com> (raw)
In-Reply-To: <7f80c6cfbcfb8097f79af6b95f10270743c5ab7f.camel@nvidia.com>
On 12/15/25 11:47 AM, Timur Tabi wrote:
> On Mon, 2025-12-15 at 11:46 +0900, John Hubbard wrote:
>> We should treat data that comes from the firmware as not yet
>> validated, external data.
>
> Maybe we should make it a policy that all data read from firmware / disk needs to be instantiate
> via a constructor that validates all the fields.
That's one approach, and maybe it will end up being the best and
most desirable approach.
But I'd stop short of making it a full-blown policy, because there
are other ways of validating the data that comes from the firmware,
and there's not (yet?) any real need to require one particular
solution, I think.
thanks,
--
John Hubbard
next prev parent reply other threads:[~2025-12-15 2:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 15:00 [PATCH 0/4] gpu: nova-core: Fixups for GSP message queue and bindings Alexandre Courbot
2025-11-21 15:00 ` [PATCH 1/4] gpu: nova-core: bindings: Add missing explicit padding Alexandre Courbot
2025-11-21 15:00 ` [PATCH 2/4] gpu: nova-core: gsp: Fix length of received messages Alexandre Courbot
2025-12-12 7:59 ` Joel Fernandes
2025-12-12 8:10 ` Dirk Behme
2025-12-14 23:43 ` Alistair Popple
2025-12-15 1:22 ` Joel Fernandes
2025-12-15 2:46 ` John Hubbard
2025-12-15 2:47 ` Timur Tabi
2025-12-15 2:54 ` John Hubbard [this message]
2025-12-15 3:48 ` Alistair Popple
2025-12-15 3:37 ` Alexandre Courbot
2025-12-14 23:29 ` Alistair Popple
2025-12-15 3:41 ` Alexandre Courbot
2025-11-21 15:00 ` [PATCH 3/4] gpu: nova-core: bindings: Derive `MaybeZeroable` Alexandre Courbot
2025-11-21 15:00 ` [PATCH 4/4] gpu: nova-core: gsp: Replace firmware version with "bindings" alias Alexandre Courbot
2025-11-23 3:04 ` [PATCH 0/4] gpu: nova-core: Fixups for GSP message queue and bindings Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b046ae27-3d68-4b2b-9464-1d481a8b8faf@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=dirk.behme@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=epeer@nvidia.com \
--cc=gary@garyguo.net \
--cc=joelagnelf@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=ttabi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®