From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932637AbdGXPPL (ORCPT ); Mon, 24 Jul 2017 11:15:11 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:34390 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932357AbdGXPPE (ORCPT ); Mon, 24 Jul 2017 11:15:04 -0400 Subject: Re: [PATCH v2 2/6] of: Add helper for mapping device node to logical CPU number To: Marc Zyngier , linux-arm-kernel@lists.infradead.org References: <1500892161-17634-1-git-send-email-suzuki.poulose@arm.com> <1500892161-17634-3-git-send-email-suzuki.poulose@arm.com> Cc: linux-kernel@vger.kernel.org, will.deacon@arm.com, mark.rutland@arm.com, peterz@infradead.org, Rob Herring From: Suzuki K Poulose Message-ID: Date: Mon, 24 Jul 2017 16:15:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Marc, On 24/07/17 14:14, Marc Zyngier wrote: > On 24/07/17 11:29, Suzuki K Poulose wrote: >> Add a helper to map a device node to a logical CPU number to avoid >> duplication. Currently this is open coded in different places (e.g >> gic-v3, coresight). The helper tries to map device node to a "possible" >> logical CPU id, which may not be online yet. It is the responsibility >> of the user to make sure that the CPU is online. The helper uses >> of_get_cpu_node() which uses arch specific backends to match the phyiscal >> ids. >> >> Cc: Rob Herring >> Cc: Mark Rutland >> Signed-off-by: Suzuki K Poulose >> --- >> drivers/of/base.c | 26 ++++++++++++++++++++++++++ >> include/linux/of_device.h | 7 +++++++ >> 2 files changed, 33 insertions(+) >> >> diff --git a/drivers/of/base.c b/drivers/of/base.c >> index 686628d..639af23 100644 >> --- a/drivers/of/base.c >> +++ b/drivers/of/base.c >> +int of_device_node_get_cpu(struct device_node *cpu_node) >> +{ >> + int cpu, thread; >> + bool found = false; >> + struct device_node *np; >> + >> + for_each_possible_cpu(cpu) { >> + np = of_get_cpu_node(cpu, &thread); > > nit: Since you don't need the thread here, you can pass NULL instead. > Sure, will do that in the next version. > > FWIW: > > Reviewed-by: Marc Zyngier > Thanks for taking a look. Suzuki