From: Scott Branden <scott.branden@broadcom.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Desmond Yan <desmond.yan@broadcom.com>
Cc: Kees Cook <keescook@chromium.org>,
linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH v6 11/14] misc: bcm-vk: add BCM_VK_QSTATS
Date: Tue, 17 Nov 2020 13:36:02 -0800 [thread overview]
Message-ID: <b04f3fdb-143b-ab34-b6e2-ac9fbb802ed0@broadcom.com> (raw)
In-Reply-To: <55f88956-48ea-08e3-c353-babb08f3a786@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1060 bytes --]
Hi Florian,
On 2020-10-02 6:39 p.m., Florian Fainelli wrote:
>
>
> On 10/2/2020 2:23 PM, Scott Branden wrote:
>> Add BCM_VK_QSTATS Kconfig option to allow for enabling debug VK
>> queue statistics.
>>
>> These statistics keep track of max, abs_max, and average for the
>> messages queues.
>>
>> Co-developed-by: Desmond Yan <desmond.yan@broadcom.com>
>> Signed-off-by: Desmond Yan <desmond.yan@broadcom.com>
>> Signed-off-by: Scott Branden <scott.branden@broadcom.com>
>
> would not it make more sense to have those debug prints be trace printks instead? Given what you explained in the previous patch version and the desire to correlate with other system wide activity, that might make more sense. Looking at the kernel's log for debugging performance or utilization or just to get a glimpse of what is going on is not quite suited past probe.
The debug prints have served our purpose up to this point.
But, in the interest of getting the other driver patches accepted I will drop this patch from the series and we will investigate further.
Thanks,
Scott
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4169 bytes --]
next prev parent reply other threads:[~2020-11-17 21:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 21:23 [PATCH v6 00/14] *Add Broadcom VK driver Scott Branden
2020-10-02 21:23 ` [PATCH v6 01/14] bcm-vk: add bcm_vk UAPI Scott Branden
2020-10-02 21:23 ` [PATCH v6 02/14] misc: bcm-vk: add Broadcom VK driver Scott Branden
2020-10-02 21:23 ` [PATCH v6 03/14] misc: bcm-vk: add autoload support Scott Branden
2020-10-02 21:23 ` [PATCH v6 04/14] misc: bcm-vk: add misc device to Broadcom VK driver Scott Branden
2020-10-02 21:23 ` [PATCH v6 05/14] misc: bcm-vk: add triggers when host panic or reboots to notify card Scott Branden
2020-10-02 21:23 ` [PATCH v6 06/14] misc: bcm-vk: add open/release Scott Branden
2020-10-02 21:23 ` [PATCH v6 07/14] misc: bcm-vk: add ioctl load_image Scott Branden
2020-10-02 21:23 ` [PATCH v6 08/14] misc: bcm-vk: add get_card_info, peerlog_info, and proc_mon_info Scott Branden
2020-10-02 21:23 ` [PATCH v6 09/14] misc: bcm-vk: add VK messaging support Scott Branden
2020-10-02 21:23 ` [PATCH v6 10/14] misc: bcm-vk: reset_pid support Scott Branden
2020-10-02 21:23 ` [PATCH v6 11/14] misc: bcm-vk: add BCM_VK_QSTATS Scott Branden
2020-10-03 1:39 ` Florian Fainelli
2020-11-17 21:36 ` Scott Branden [this message]
2020-10-02 21:23 ` [PATCH v6 12/14] misc: bcm-vk: add mmap function for exposing BAR2 Scott Branden
2020-10-02 21:23 ` [PATCH v6 13/14] MAINTAINERS: bcm-vk: add maintainer for Broadcom VK Driver Scott Branden
2020-10-02 21:23 ` [PATCH v6 14/14] misc: bcm-vk: add ttyVK support Scott Branden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b04f3fdb-143b-ab34-b6e2-ac9fbb802ed0@broadcom.com \
--to=scott.branden@broadcom.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=desmond.yan@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®