From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Wesley Cheng <quic_wcheng@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: usb: qcom,snps-dwc3: Add missing clock constraints
Date: Mon, 23 Mar 2026 09:38:10 +0100 [thread overview]
Message-ID: <b0648931-9194-45ba-ab44-c7ef01c75bb3@oss.qualcomm.com> (raw)
In-Reply-To: <20260319092348.35237-2-krzysztof.kozlowski@oss.qualcomm.com>
On 19/03/2026 10:23, Krzysztof Kozlowski wrote:
> The top-level part defines variable number of clocks and each "if:then:"
> block narrows them. It however narrows only the maxItems leaving
> minItems undefined, which then takes different values depending on
> dtschema being used.
>
> Recommended style is to avoid ambiguity in such case, thus if top-level
> part has broad constraints, then each "if:then:" must specify both upper
> and lower limits.
>
> Add missing constraints, mostly minItems but also maxItems for one
> variant.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>
> ---
>
> Apologies for sending two patches for the same file one after another as
> independent work. I do drive-by fixes when doing reviews and usually
> post such fix immediately.
I looked at Sashiko review of this patch and it nicely spotted more
issues in the original code (not my patch), so I will have more patches.
I will organize all of them into one patchset, so there will be v2 of this.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-03-23 8:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 9:23 Krzysztof Kozlowski
2026-03-23 8:38 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0648931-9194-45ba-ab44-c7ef01c75bb3@oss.qualcomm.com \
--to=krzysztof.kozlowski@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_wcheng@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®