mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Andrea Righi <arighi@nvidia.com>
Cc: David Vernet <void@manifault.com>,
	Changwoo Min <changwoo@igalia.com>,
	John Stultz <jstultz@google.com>,
	sched-ext@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 sched_ext/for-7.4] sched_ext: Keep proxy donors with slice left on the local DSQ
Date: Thu, 08 Oct 2026 08:04:23 -1000	[thread overview]
Message-ID: <b064c79615e33deb06e9483e4ddf23c4@kernel.org> (raw)
In-Reply-To: <asXxp0WabkwdB5aw@gpd4>

Hello, Andrea.

On Wed, Oct 07, 2026 at 09:15:51AM +0200, Andrea Righi wrote:
...
> I think we can do this without modifying sched/core.c, sched_ext can set an
> SCX_RQ_PROXY_BLOCKING flag around its calls to sched_proxy_block_task(). When
> proxy_reset_donor() invokes put_prev_task_scx(), that flag tells sched_ext not
> to reenqueue the donor and block_task() will dequeue it immediately afterward.
> This should avoid the transient enqueue/dequeue pair and the false ENQ_LAST
> warning.
...
> So we need to add two rq flags in this way, SCX_RQ_PROXY_PICK_PENDING and
> SCX_RQ_PROXY_BLOCKING, but the whole logic stays in ext.c (with the flags
> dfinition in sched.h). Does this approach makes sense to you?

Yeah, that sounds good to me.

Thanks.

--
tejun

      reply	other threads:[~2026-10-08 18:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-02 22:15 Andrea Righi
2026-10-06 20:28 ` Tejun Heo
2026-10-07  7:15   ` Andrea Righi
2026-10-08 18:04     ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b064c79615e33deb06e9483e4ddf23c4@kernel.org \
    --to=tj@kernel.org \
    --cc=arighi@nvidia.com \
    --cc=changwoo@igalia.com \
    --cc=jstultz@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sched-ext@lists.linux.dev \
    --cc=void@manifault.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®