From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C23CFC28B2B for ; Wed, 17 Aug 2022 01:39:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238243AbiHQBjD (ORCPT ); Tue, 16 Aug 2022 21:39:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238257AbiHQBi5 (ORCPT ); Tue, 16 Aug 2022 21:38:57 -0400 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BCAA3ED69; Tue, 16 Aug 2022 18:38:48 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4M6rH155CVzKK5b; Wed, 17 Aug 2022 09:37:17 +0800 (CST) Received: from [10.174.176.73] (unknown [10.174.176.73]) by APP2 (Coremail) with SMTP id Syh0CgDHsb2lRvxib5zWAQ--.29963S3; Wed, 17 Aug 2022 09:38:46 +0800 (CST) Subject: Re: [PATCH v7 8/9] blk-throttle: cleanup tg_update_disptime() To: Tejun Heo , Yu Kuai Cc: mkoutny@suse.com, axboe@kernel.dk, ming.lei@redhat.com, cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com, "yukuai (C)" References: <20220802140415.2960284-1-yukuai1@huaweicloud.com> <20220802140415.2960284-9-yukuai1@huaweicloud.com> From: Yu Kuai Message-ID: Date: Wed, 17 Aug 2022 09:38:45 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID: Syh0CgDHsb2lRvxib5zWAQ--.29963S3 X-Coremail-Antispam: 1UD129KBjvdXoWrZr1xJF1xXF4xJFyUur1UGFg_yoW3Cwb_GF yvyrW0y34UAFZavasxJ3ZxCa9rWr4rGFy3Xw4Ivw47Kry5Xan8Zan8G395Ar13Gw4DtrnI krWDGr4avrWSkjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUba8FF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j 6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUXVWUAwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r 4UM4x0Y48IcVAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x02628vn2kI c2xKxwCYjI0SjxkI62AI1cAE67vIY487MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4 AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE 17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMI IF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Wr1j6rW3 Jr1lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcS sGvfC2KfnxnUUI43ZEXa7VUbE_M3UUUUU== X-CM-SenderInfo: 51xn3trlr6x35dzhxuhorxvhhfrp/ X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Tejun£¡ ÔÚ 2022/08/17 4:09, Tejun Heo дµÀ: > On Tue, Aug 02, 2022 at 10:04:14PM +0800, Yu Kuai wrote: >> From: Yu Kuai >> >> tg_update_disptime() only need to adjust postion for 'tg' in >> 'parent_sq', there is no need to call throtl_enqueue/dequeue_tg(). >> >> Save a little overhead in tg_update_disptime() and prepare to cleanup >> flag 'THROTL_TG_PENDING', there are no functional changes. > > Does this actually help anything? Given that the heavy part of the operation > remains the same, this might not be much of an optimization. Is there even a > microbench that can show the difference? It's right heavy part remains the same, the patch just remove some unnecessary operations. And I didn't run benchmark to test that yet. Thanks, Kuai > > Thanks. >