From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org,
Jens Axboe <axboe@kernel.dk>, Hannes Reinecke <hare@suse.com>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH 1/3] irq: Allow to pass the IRQF_TIMER flag with percpu irq request
Date: Thu, 22 Jun 2017 12:36:24 +0200 [thread overview]
Message-ID: <b06ce7a4-6738-07e2-6d7a-c87bb8aeff46@linaro.org> (raw)
In-Reply-To: <20170622093146.GA25967@leverpostej>
On 22/06/2017 11:31, Mark Rutland wrote:
> Hi Daniel,
>
> On Tue, Jun 20, 2017 at 11:28:55PM +0200, Daniel Lezcano wrote:
>> In the next changes, we track when the interrupts occur in order to
>> statistically compute when is supposed to happen the next interrupt.
>>
>> In all the interruptions, it does not make sense to store the timer interrupt
>> occurences and try to predict the next interrupt as we know the expiration
>> time.
>>
>> The request_irq() has a irq flags parameter and the timer drivers use it to
>> pass the IRQF_TIMER flag, letting us know the interrupt is coming from a timer.
>> Based on this flag, we can discard these interrupts when tracking them.
>>
>> But, the API request_percpu_irq does not allow to pass a flag, hence specifying
>> if the interrupt type is a timer.
>>
>> Add a function __request_percpu_irq() where we can specify the flags. The
>> request_percpu_irq() function is changed to be a wrapper to
>> __request_percpu_irq() passing a zero flag parameter.
>>
>> For now, in order to prevent a misusage of this parameter, only the IRQF_TIMER
>> flag (or zero) is a valid parameter to be passed to the
>> __request_percpu_irq() function.
>>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>> Cc: Mark Rutland <mark.rutland@arm.com>
>
> Sorry for leading you round the garden path on the naming.
No problem ;)
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2017-06-22 10:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 21:26 [GIT PULL V11] irq: next irq tracking Daniel Lezcano
2017-06-20 21:28 ` [PATCH 1/3] irq: Allow to pass the IRQF_TIMER flag with percpu irq request Daniel Lezcano
2017-06-20 21:28 ` [PATCH 2/3] irq: Track the interrupt timings Daniel Lezcano
2017-06-22 14:47 ` Thomas Gleixner
2017-06-22 14:55 ` Daniel Lezcano
2017-06-20 21:28 ` [PATCH 3/3] irq: Compute the periodic interval for interrupts Daniel Lezcano
2017-06-22 15:25 ` Thomas Gleixner
2017-06-22 16:35 ` Daniel Lezcano
2017-06-22 9:31 ` [PATCH 1/3] irq: Allow to pass the IRQF_TIMER flag with percpu irq request Mark Rutland
2017-06-22 10:36 ` Daniel Lezcano [this message]
2017-06-20 22:04 ` [GIT PULL V11] irq: next irq tracking Thomas Gleixner
2017-06-21 10:57 ` Daniel Lezcano
2017-07-06 12:29 ` [PATCH V11] irq: Allow to pass the IRQF_TIMER flag with percpu irq request Daniel Lezcano
2017-07-06 21:21 ` [tip:irq/urgent] genirq: " tip-bot for Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b06ce7a4-6738-07e2-6d7a-c87bb8aeff46@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=axboe@kernel.dk \
--cc=bhelgaas@google.com \
--cc=hare@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®