From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C844434B1B4 for ; Tue, 10 Mar 2026 08:34:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773131686; cv=none; b=V503nDH2tZfdcyXD/LvA3yg9M4S2tTiYFV/AF9v5qWTj4947ftPjcoeKUo6L/pRzyj4vtevdfNtrJFNts82mrQUrq7qSNpXlL++OzYb0DZE04Uz+mDyXzpVEN8axaLmBrYXoVJR8+sdPK+gmd3J16BkK5yd9exU0EWers2DWjEk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773131686; c=relaxed/simple; bh=ezP+HmihB2fc2H5BNiKKSvsIsIA9loeb22H+jsjzvYY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=f9GYLsnkau3PyvwZui4DtLOIWvVS7jvW+7VKZ6KNjPPlrwBACQLq7qpvWTNnEiDsUnCE5Db0jP6dLSE89bqwi5hzrvOg9BCIs9IcF0clB3rlHMfWZ/PSj6mYmZXtahfAJZu6S/Gs+W+HkOSiVvvEXgA8t/kCIRHowehEr2Kc/RI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=mavhP1aE; arc=none smtp.client-ip=192.198.163.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="mavhP1aE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773131684; x=1804667684; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=ezP+HmihB2fc2H5BNiKKSvsIsIA9loeb22H+jsjzvYY=; b=mavhP1aEsLNxOAjlb60vDfv23YJG2S8nadRDRX8kwPb4p+ybMBZXaxu1 wPU3ui+iMUEeAxjxCfA3ljGhtB/T7xS/P5Jjgf1IQYL0fuGoUz3Sd3GE5 72vPalnWbtRWzIHpzlgBkingvUjPRyEaNjNaigFyBMRv3vaifxgcgJArA fj3uTqIx1lMofBTvZ3ExUK2XXgOyXjLeLXI9V25qo0PhntsSauseSyAUy tNPGbEOLkVVxJDT/ZrVYrFja3nuxTU0oiAbUPkDa7RxvnhT3U8cPjSI4l 1aedZSi9aFvLw+ZZRPU+VRbmnaQO5nnfvBtX/duxKvgMTHcK8RAd4xBrl A==; X-CSE-ConnectionGUID: DRbTojW5TfOqfSGaONOgig== X-CSE-MsgGUID: cQXANIlHTdOL+RzwONWOiA== X-IronPort-AV: E=McAfee;i="6800,10657,11724"; a="74249278" X-IronPort-AV: E=Sophos;i="6.23,111,1770624000"; d="scan'208";a="74249278" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2026 01:34:43 -0700 X-CSE-ConnectionGUID: 3s/uUMyjTD2rCVJcxbGmYg== X-CSE-MsgGUID: 3n1uhcXXRTWLN1rXEcyR4A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,111,1770624000"; d="scan'208";a="215447978" Received: from krybak-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.246.32]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2026 01:34:41 -0700 From: Jani Nikula To: renpanpan , linux-kernel@vger.kernel.org Cc: rodrigo.vivi@intel.com, renpanpan Subject: Re: [PATCH 4/5] drm/i915/opregion: hda: Use safer strscpy() instead of strcpy() In-Reply-To: <20260310080457.3072560-1-renpanpan@kylinos.cn> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <20260310080457.3072560-1-renpanpan@kylinos.cn> Date: Tue, 10 Mar 2026 10:34:38 +0200 Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Tue, 10 Mar 2026, renpanpan wrote: > Use a safer function strscpy() instead of strcpy() for copying to > arrays. > Only idiomatic code replacement, and no functional changes. This is not true, and the change introduces a bug. BR, Jani. > > Signed-off-by: renpanpan > --- > drivers/gpu/drm/i915/gvt/opregion.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gvt/opregion.c b/drivers/gpu/drm/i915/gvt/opregion.c > index d6e76ba31d60..e3bb7e0fcd9a 100644 > --- a/drivers/gpu/drm/i915/gvt/opregion.c > +++ b/drivers/gpu/drm/i915/gvt/opregion.c > @@ -151,7 +151,7 @@ static void virt_vbt_generation(struct vbt *v) > v->header.vbt_size = sizeof(struct vbt); > v->header.bdb_offset = offsetof(struct vbt, bdb_header); > > - strcpy(&v->bdb_header.signature[0], "BIOS_DATA_BLOCK"); > + strscpy(&v->bdb_header.signature[0], "BIOS_DATA_BLOCK"); > v->bdb_header.version = 186; /* child_dev_size = 33 */ > v->bdb_header.header_size = sizeof(v->bdb_header); -- Jani Nikula, Intel